Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036994Retail ModulesWeb POSpublic2017-10-03 13:322018-02-16 17:15
Reportermalsasua 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket48521
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036994: overpayment limit does not work when decimal separator is comma "," instead of dot "."
Descriptionwhen you have configured the organization to use the decimal separator comma "," the overpayment limit functionality does not work
Steps To Reproducebackooffice>
 .Organization window: "Vall Blanca Store"
  . decimal separator: ,
  . group separator: .
 . POS Terminal Type "VBS POS Terminal Type":
  . payment method "Credit Card"
   . Overpayment / Change Limit: 0

POS>
 . login in VBS-1
 . add new line Avalanche > total receipt: 150.50
 . payment window: new payment:
  . Card - Amount 200

DONE button should be disabled and message "Overpayment is not available" should be displayed
(see attachments)
Proposed Solutionin https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/e017003eded3/web/org.openbravo.retail.posterminal/js/model/order.js#l904 [^]
overpayment variable should not be formatted to String using OB.I18N.formatCurrency function
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng well.png (270,409) 2017-10-03 13:33
https://issues.openbravo.com/file_download.php?file_id=11134&type=bug
png wrong.png (266,930) 2017-10-03 13:33
https://issues.openbravo.com/file_download.php?file_id=11135&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-10-03 13:32malsasuaNew Issue
2017-10-03 13:32malsasuaAssigned To => Retail
2017-10-03 13:32malsasuaOBNetwork customer => Yes
2017-10-03 13:32malsasuaSupport ticket => 48521
2017-10-03 13:32malsasuaResolution time => 1508796000
2017-10-03 13:32malsasuaTriggers an Emergency Pack => No
2017-10-03 13:33malsasuaFile Added: well.png
2017-10-03 13:33malsasuaFile Added: wrong.png
2017-10-03 13:36malsasuaProposed Solution updated
2017-10-03 18:02eugeniIssue Monitored: eugeni
2017-10-09 20:03rqueraltaAssigned ToRetail => rqueralta
2017-10-09 20:03rqueraltaStatusnew => scheduled
2017-10-10 15:44hgbotCheckin
2017-10-10 15:44hgbotNote Added: 0099854
2017-10-10 15:44hgbotStatusscheduled => resolved
2017-10-10 15:44hgbotResolutionopen => fixed
2017-10-10 15:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/00a4f6cd4b71bd35511b31359436ed19b234a288 [^]
2017-10-13 14:18marvintmReview Assigned To => marvintm
2017-10-13 14:18marvintmStatusresolved => closed
2017-10-13 14:18marvintmFixed in Version => RR18Q1
2017-11-16 20:36hgbotCheckin
2017-11-16 20:36hgbotNote Added: 0100556
2017-11-24 11:33hgbotCheckin
2017-11-24 11:33hgbotNote Added: 0100700
2018-02-16 17:15hgbotCheckin
2018-02-16 17:15hgbotNote Added: 0102468

Notes
(0099854)
hgbot   
2017-10-10 15:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 00a4f6cd4b71bd35511b31359436ed19b234a288
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Mon Oct 09 13:38:31 2017 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/00a4f6cd4b71bd35511b31359436ed19b234a288 [^]

Fixed issue 36994: overpayment limit does not work when decimal separator is
comma "," instead of dot "."

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0100556)
hgbot   
2017-11-16 20:36   
Repository: tools/automation/pi-mobile
Changeset: 252b879ce446ec84e25f096fd33656ac6ecf1df3
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Tue Nov 14 15:34:50 2017 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/252b879ce446ec84e25f096fd33656ac6ecf1df3 [^]

Verifies issue 36994: overpayment limit does not work when decimal separator is
comma "," instead of dot "."

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36994_OverpaymentLimitWithDecimalSeparatorDoesNotWork.java
---
(0100700)
hgbot   
2017-11-24 11:33   
Repository: tools/automation/pi-mobile
Changeset: 69b9125ae95177624ef6f2381f40e75e9bace451
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Nov 24 11:33:20 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/69b9125ae95177624ef6f2381f40e75e9bace451 [^]

Related to issue 36994: overpayment limit does not work when decimal separator is
comma "," instead of dot "."

Backed out changeset 252b879ce446

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36994_OverpaymentLimitWithDecimalSeparatorDoesNotWork.java
---
(0102468)
hgbot   
2018-02-16 17:15   
Repository: tools/automation/pi-mobile
Changeset: 1c78cf3f0a3eb556777bc26001e116b326312dfd
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Feb 15 17:39:51 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1c78cf3f0a3eb556777bc26001e116b326312dfd [^]

Verifies issue 36994: Automated test "I36994_OverpaymentLimitWithDecimalSeparatorDoesNotWork"

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36994_OverpaymentLimitWithDecimalSeparatorDoesNotWork.java
---