Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036985Retail ModulesWeb POSpublic2017-10-02 16:592018-08-24 14:34
Reportermigueldejuana 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-02-06
Regression introduced in releaseRR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4729f5935750dd6a632b63033c2bd3ab21305d46 [^]
Triggers an Emergency PackNo
Summary0036985: We are triggering twice window:ready
DescriptionWe are triggering twice window:ready. We already have a listener which does 2 requests to the backend. We have 2 problems:

- We are doing duplicate requests in the login
- The code inside the window:ready listener could cause errors because it is executed twice(i.e.: Remove current order twice)

The issue which causes the regression has a note which comments the problem of the duplicate trigger but the commit just fixes the causing error, no the root problem.
Steps To ReproduceSee Desc.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035119 closed jorge-garcia OBPOS_NewReceipt hook is not opening popups on login 
depends on backport 0039177RR18Q3.1 closed ranjith_qualiantech_com We are triggering twice window:ready 
depends on backport 0039178RR18Q2.3 closed ranjith_qualiantech_com We are triggering twice window:ready 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-02 16:59migueldejuanaNew Issue
2017-10-02 16:59migueldejuanaAssigned To => Retail
2017-10-02 16:59migueldejuanaOBNetwork customer => No
2017-10-02 16:59migueldejuanaTriggers an Emergency Pack => No
2017-10-02 16:59migueldejuanaRelationship addedrelated to 0035119
2017-10-02 17:11migueldejuanaRegression level => Production - Confirmed Stable
2017-10-02 17:11migueldejuanaRegression date => 2017-02-06
2017-10-02 17:11migueldejuanaRegression introduced in release => RR17Q2
2017-10-02 17:11migueldejuanaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4729f5935750dd6a632b63033c2bd3ab21305d46 [^]
2017-10-02 17:17migueldejuanaDescription Updatedbug_revision_view_page.php?rev_id=16027#r16027
2018-08-08 14:06ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-08-08 14:07ranjith_qualiantech_comStatusnew => scheduled
2018-08-21 13:24hgbotCheckin
2018-08-21 13:24hgbotNote Added: 0106427
2018-08-21 13:24hgbotCheckin
2018-08-21 13:24hgbotNote Added: 0106428
2018-08-21 13:24hgbotStatusscheduled => resolved
2018-08-21 13:24hgbotResolutionopen => fixed
2018-08-21 13:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/37856256e643d7ff6ac87e6c955e4dcc0a38129a [^]
2018-08-23 12:13migueldejuanaStatusresolved => new
2018-08-23 12:13migueldejuanaResolutionfixed => open
2018-08-23 12:13migueldejuanaStatusnew => scheduled
2018-08-23 12:13migueldejuanaStatusscheduled => resolved
2018-08-23 12:13migueldejuanaResolutionopen => fixed
2018-08-24 14:34migueldejuanaReview Assigned To => migueldejuana
2018-08-24 14:34migueldejuanaNote Added: 0106477
2018-08-24 14:34migueldejuanaStatusresolved => closed

Notes
(0106427)
hgbot   
2018-08-21 13:24   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0b340099797456b1da874b85bfd810ca687c826c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Aug 21 16:52:30 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0b340099797456b1da874b85bfd810ca687c826c [^]

Related to issue 36985 : Container window should be rendered when window:ready event is triggered

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0106428)
hgbot   
2018-08-21 13:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 37856256e643d7ff6ac87e6c955e4dcc0a38129a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Aug 21 16:53:47 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/37856256e643d7ff6ac87e6c955e4dcc0a38129a [^]

Fixed issue 36985 : Removed model trigger window:ready when unpaid receipts are loaded

* 'window:ready' event added when loading unpaid receipts from database.
   Unpaid receipts will be added to UI when 'window:ready' is triggered

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0106477)
migueldejuana   
2018-08-24 14:34   
Reviewed