Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036974Retail ModulesWeb POSpublic2017-09-29 14:062017-10-16 12:24
Reporterxabiermerino 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036974: [SERQA 3316] It is possible to bypass the overpayments with Pay Open tickets
DescriptionIt is possible to bypass the overpayments with Pay Open tickets
Steps To Reproduce- Open Pay Open ticket window with one layaway
- Use 'Card' and introduce an amount higher than layaway's amount
- The application shows an Overpayment Error --> OK
- Refresh using F5
- Realize that the button 'done' is available and the error message has dissapeared
Proposed Solution
Additional Information
TagsSERQA
Relationships
causes defect 0038176 closed ranjith_qualiantech_com JS error when trying to pay a ticket with a payment method not in that terminal 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-29 14:06xabiermerinoNew Issue
2017-09-29 14:06xabiermerinoAssigned To => Retail
2017-09-29 14:06xabiermerinoOBNetwork customer => Yes
2017-09-29 14:06xabiermerinoResolution time => 1507932000
2017-09-29 14:06xabiermerinoTriggers an Emergency Pack => No
2017-09-29 14:06xabiermerinoTag Attached: SERQA
2017-10-06 11:33jorge-garciaStatusnew => scheduled
2017-10-06 11:33jorge-garciaAssigned ToRetail => jorge-garcia
2017-10-11 16:57hgbotCheckin
2017-10-11 16:57hgbotNote Added: 0099866
2017-10-11 16:57hgbotStatusscheduled => resolved
2017-10-11 16:57hgbotResolutionopen => fixed
2017-10-11 16:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c903c081a0a212acb8710040d56f53b66656b19 [^]
2017-10-13 13:37marvintmReview Assigned To => marvintm
2017-10-13 13:37marvintmStatusresolved => closed
2017-10-13 13:37marvintmFixed in Version => RR18Q1
2017-10-16 12:24hgbotCheckin
2017-10-16 12:24hgbotNote Added: 0099919
2018-03-21 18:50dmitry_mezentsevRelationship addedcauses 0038176

Notes
(0099866)
hgbot   
2017-10-11 16:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6c903c081a0a212acb8710040d56f53b66656b19
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 11 12:48:45 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c903c081a0a212acb8710040d56f53b66656b19 [^]

Fixed issue 36974: [SERQA 3316] It is possible to bypass the overpayments
with Pay Open tickets

The solution is to check first if the last payment has an overpayment and if
the payment method has defined a limit for it.

Since right now it’s not possible to add more payment once the user has pay it
completely, this is a valid solution.

This solution has forced to take the overpayment to a new function called
checkValidOverpayment and change the old function checkValidCashOverpayment
(now renamed to CheckValidCashChange).

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0099919)
hgbot   
2017-10-16 12:24   
Repository: tools/automation/pi-mobile
Changeset: e89bf7256b9ad24b79b7585f9fd9390a9d47e9f6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 16 10:11:18 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e89bf7256b9ad24b79b7585f9fd9390a9d47e9f6 [^]

Verifies issue 36974: [SERQA 3316] It is possible to bypass the overpayments
with Pay Open tickets

Added test I36974_VerifyOverpaymentByLimitAfterRefresh.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I36974_VerifyOverpaymentByLimitAfterRefresh.java
---