0036972: In a tree, moving an item that you don't have access produce null pointer error in the log and don't give feedback to the user

Openbravo Issue Tracking System - Openbravo ERP
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0036972	Openbravo ERP	A. Platform	public	2017-09-28 16:44	2018-01-03 12:39

Reporter	gorka_gil
Assigned To	caristu
Priority	low	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version	3.0PR18Q1
Merge Request Status
Review Assigned To	alostale
OBNetwork customer
Web browser	Google Chrome
Modules	Core
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0036972: In a tree, moving an item that you don't have access produce null pointer error in the log and don't give feedback to the user
Description	In a tree in which have access to some items and other no, If move an item that don't have access A) it gives these errors in openbravo.log: - ERROR org.openbravo.base.exception.OBSecurityException - Organization .... - ERROR org.openbravo.service.datasource.TreeDatasourceService - Error while moving tree node - ERROR org.openbravo.service.datasource.DataSourceServlet - java.lang.NullPointerException Complete error log: https://pastebin.com/raw/YA6d6NeJ [^] B) Also it shows like it can move it, and when fail there is no feedback of the error Note: if you put the tab as read only (UI Pattern), it don't give errors in the log, and the dots line that show where the item will be moved is not show. So gives a better user experience, maybe clone this behaviour?
Steps To Reproduce	A standard retail environment with the pack like in livebuilds: - https://livebuilds.openbravo.com/retail_pi_pgsql [^] Login in the backend as vallblanca. Go to the "Product Category" window Notice how you have access to some records and other not (icon of save in the grid) Click on the menu view Try to move the item "Backpacks & Travel" to any place. Notice the errors in the openbravo.log and that for the user don't give any information that has fail and why.
Proposed Solution	1) Fix the error in the log 2) when trying to move an item without access don't show the dots line, that shows where the item will be moved. Or other similar way that gives feedback to the user that this item can not be moved 2.b) Alternatively, other option when trying to move, show a warning/info in the ui to the user. Or any other way of feedback to the user.
Additional Information
Tags	No tags attached.
Relationships
Attached Files

Issue History
Date Modified	Username	Field	Change
2017-09-28 16:44	gorka_gil	New Issue
2017-09-28 16:44	gorka_gil	Assigned To	=> platform
2017-09-28 16:44	gorka_gil	Web browser	=> Google Chrome
2017-09-28 16:44	gorka_gil	Modules	=> Core
2017-09-28 16:44	gorka_gil	Triggers an Emergency Pack	=> No
2017-11-24 11:18	caristu	Assigned To	platform => caristu
2017-11-24 11:19	hgbot	Checkin
2017-11-24 11:19	hgbot	Note Added: 0100698
2017-11-24 11:19	hgbot	Status	new => resolved
2017-11-24 11:19	hgbot	Resolution	open => fixed
2017-11-24 11:19	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/10214c76633ec218343d42a34f303240d59030c7 [^]
2017-11-24 11:20	caristu	Review Assigned To	=> alostale
2017-11-24 11:20	caristu	Web browser	Google Chrome => Google Chrome
2017-11-27 10:10	alostale	Note Added: 0100726
2017-11-27 10:10	alostale	Status	resolved => closed
2017-11-27 10:10	alostale	Fixed in Version	=> 3.0PR18Q1
2018-01-03 12:39	hudsonbot	Checkin
2018-01-03 12:39	hudsonbot	Note Added: 0101455

Notes