Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036970Openbravo ERPA. Platformpublic2017-09-28 13:012018-01-03 12:38
Reportercaristu 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036970: Focus placed at wrong place when editing with errors and saving the parent record
DescriptionWhen editing a child record in grid view and leaving it with errors to do changes in the parent record, it leaves to an inconsistent state because the focus is placed at the parent record but still the active view still is child view.
Steps To ReproduceAs group admin role:
1) Create a Sales Order
2) Add a product with stock to it
3) Book it
   
4) Create a goods shipment
5) Select the previously created order line in the Create Lines From process
6) Open the header in form view
7) Move to the lines tab

8A)Increase the Movement Quantity in form view
   Without saving, click in the Description field at the header
   Check the following error message is shown
      Saving failed. Movement Quantity is greater than the Ordered Quantity
      Notice that the active view is the Lines tab. The focus is placed in the Lines tab form --> OK
   
8B) Increase the Movement Quantity in grid view
   Without saving, click in the Description field at the header
   Check the following error message is shown
      One or more rows could not be saved. Fix the problem or cancel all pending changes to return to the last saved state.
   Notice that the active view is the Lines tab. The focus is placed at the header --> ERROR
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035136 closed caristu Line seems to be saved with error when editing and saving the header 
Attached Filesdiff issue36970.diff (2,805) 2017-09-28 13:46
https://issues.openbravo.com/file_download.php?file_id=11117&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-09-28 13:01caristuNew Issue
2017-09-28 13:01caristuAssigned To => caristu
2017-09-28 13:01caristuOBNetwork customer => No
2017-09-28 13:01caristuModules => Core
2017-09-28 13:01caristuTriggers an Emergency Pack => No
2017-09-28 13:01caristuStatusnew => scheduled
2017-09-28 13:02caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16011#r16011
2017-09-28 13:02caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16012#r16012
2017-09-28 13:02caristuRelationship addedrelated to 0035136
2017-09-28 13:03caristuSummaryFocus placed at wrong place when editing with errors and saving the header => Focus placed at wrong place when editing with errors and saving the parent record
2017-09-28 13:43caristuFile Added: issue36970.diff
2017-09-28 13:45caristuFile Deleted: issue36970.diff
2017-09-28 13:45caristuFile Added: issue36970.diff
2017-09-28 13:46caristuFile Deleted: issue36970.diff
2017-09-28 13:46caristuFile Added: issue36970.diff
2017-10-03 17:10hgbotCheckin
2017-10-03 17:10hgbotNote Added: 0099732
2017-10-03 17:10hgbotStatusscheduled => resolved
2017-10-03 17:10hgbotResolutionopen => fixed
2017-10-03 17:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4fc9045d89dbb16a1f860c380b51f14e769f9f33 [^]
2017-10-03 17:10caristuReview Assigned To => alostale
2017-10-09 10:04alostaleNote Added: 0099820
2017-10-09 10:04alostaleStatusresolved => closed
2017-10-09 10:04alostaleFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101314

Notes
(0099732)
hgbot   
2017-10-03 17:10   
Repository: erp/devel/pi
Changeset: 4fc9045d89dbb16a1f860c380b51f14e769f9f33
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Sep 28 13:19:06 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4fc9045d89dbb16a1f860c380b51f14e769f9f33 [^]

fixes bug 36970: Return focus to the record if failed to be edited in grid view

  When a record failed to be edited in grid view right after moving to the form view of its parent record, the window ended in an inconsitent state:
    - The focus was placed at the header
    - The active view still was the child tab

  This was not happening when editing the child record in form view, because the focus was always returned to the form. To fix the problem now the same behavior has been implemented in grid view: in the described scenario the focus is returned to the edit form of the grid.

  Besides, the "editRow" and "editSession" variables were unused in the editFailed() function. Thus, both have been removed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0099820)
alostale   
2017-10-09 10:04   
reviewed + tested
(0101314)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test