Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0036968 | Retail Modules | Web POS | public | 2017-09-27 18:18 | 2017-11-14 17:55 |
|
| Reporter | xabiermerino | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR18Q1 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0036968: [SERQA 3297] Wrong till status after clean cache |
| Description | If the user closes the store and the till from backend and, after that, cleans the cache of WebPOS we achieve a register in till status window closed without cash up |
| Steps To Reproduce | * Open a terminal through WebPOS
* Pay a layaway
* Close the store and tills through Backoffice
* Clean cache
* Log into webPOS
* Realize that the next step is an Initial Count instead of a Cash up (wrong) |
| Proposed Solution | |
| Additional Information | |
| Tags | SERQA |
| Relationships | | related to | defect | 0037072 | | closed | ranjith_qualiantech_com | [TESTS] Test I36968_VerifyOpenTillAfterCloseStore is failing in quarantine |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-09-27 18:18 | xabiermerino | New Issue | |
| 2017-09-27 18:18 | xabiermerino | Assigned To | => Retail |
| 2017-09-27 18:18 | xabiermerino | Resolution time | => 1507759200 |
| 2017-09-27 18:18 | xabiermerino | Triggers an Emergency Pack | => No |
| 2017-09-27 18:18 | xabiermerino | Tag Attached: SERQA | |
| 2017-10-03 16:15 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2017-10-03 16:15 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-10-10 11:48 | hgbot | Checkin | |
| 2017-10-10 11:48 | hgbot | Note Added: 0099847 | |
| 2017-10-13 08:04 | hgbot | Checkin | |
| 2017-10-13 08:04 | hgbot | Note Added: 0099879 | |
| 2017-10-13 09:03 | ranjith_qualiantech_com | Status | scheduled => resolved |
| 2017-10-13 09:03 | ranjith_qualiantech_com | Resolution | open => fixed |
| 2017-10-13 13:44 | marvintm | Review Assigned To | => marvintm |
| 2017-10-13 13:44 | marvintm | Status | resolved => closed |
| 2017-10-13 13:44 | marvintm | Fixed in Version | => RR18Q1 |
| 2017-10-15 19:15 | migueldejuana | Note Added: 0099915 | |
| 2017-10-15 19:15 | migueldejuana | Status | closed => new |
| 2017-10-15 19:15 | migueldejuana | Resolution | fixed => open |
| 2017-10-15 19:15 | migueldejuana | Fixed in Version | RR18Q1 => |
| 2017-10-16 11:38 | jorge-garcia | Relationship added | related to 0037072 |
| 2017-10-16 11:39 | jorge-garcia | Status | new => scheduled |
| 2017-10-16 11:39 | jorge-garcia | Status | scheduled => resolved |
| 2017-10-16 11:39 | jorge-garcia | Resolution | open => fixed |
| 2017-10-16 11:40 | jorge-garcia | Note Added: 0099918 | |
| 2017-10-16 11:40 | jorge-garcia | Status | resolved => closed |
| 2017-10-24 15:35 | asiermartirena | Note Added: 0100030 | |
| 2017-10-24 15:35 | asiermartirena | Status | closed => new |
| 2017-10-24 15:35 | asiermartirena | Resolution | fixed => open |
| 2017-10-30 09:22 | hgbot | Checkin | |
| 2017-10-30 09:22 | hgbot | Note Added: 0100134 | |
| 2017-10-30 13:46 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-10-30 13:46 | ranjith_qualiantech_com | Status | scheduled => resolved |
| 2017-10-30 13:46 | ranjith_qualiantech_com | Resolution | open => fixed |
| 2017-10-31 17:56 | marvintm | Status | resolved => closed |
| 2017-10-31 17:56 | marvintm | Fixed in Version | => RR18Q1 |
| 2017-11-03 13:50 | xabiermerino | Note Added: 0100268 | |
| 2017-11-03 13:50 | xabiermerino | Status | closed => new |
| 2017-11-03 13:50 | xabiermerino | Resolution | fixed => open |
| 2017-11-03 13:50 | xabiermerino | Fixed in Version | RR18Q1 => |
| 2017-11-09 06:37 | hgbot | Checkin | |
| 2017-11-09 06:37 | hgbot | Note Added: 0100368 | |
| 2017-11-09 12:01 | hgbot | Checkin | |
| 2017-11-09 12:01 | hgbot | Note Added: 0100378 | |
| 2017-11-09 13:48 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-11-09 13:49 | ranjith_qualiantech_com | Status | scheduled => resolved |
| 2017-11-09 13:49 | ranjith_qualiantech_com | Resolution | open => fixed |
| 2017-11-10 09:11 | marvintm | Note Added: 0100413 | |
| 2017-11-10 09:11 | marvintm | Status | resolved => new |
| 2017-11-10 09:11 | marvintm | Resolution | fixed => open |
| 2017-11-13 13:10 | hgbot | Checkin | |
| 2017-11-13 13:10 | hgbot | Note Added: 0100482 | |
| 2017-11-13 13:11 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-11-14 12:43 | hgbot | Checkin | |
| 2017-11-14 12:43 | hgbot | Note Added: 0100513 | |
| 2017-11-14 16:45 | marvintm | Status | scheduled => resolved |
| 2017-11-14 16:45 | marvintm | Fixed in Version | => RR18Q1 |
| 2017-11-14 16:45 | marvintm | Resolution | open => fixed |
| 2017-11-14 17:55 | marvintm | Status | resolved => closed |
|
Notes |
|
|
(0099847)
|
|
hgbot
|
|
2017-10-10 11:48
|
|
|
|
|
(0099879)
|
|
hgbot
|
|
2017-10-13 08:04
|
|
Repository: tools/automation/pi-mobile
Changeset: 0dc1c2806689f75006e8b60389087cad56c5d188
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 13 11:20:08 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0dc1c2806689f75006e8b60389087cad56c5d188 [^]
Verifies issue 36968 : Added automated test 'I36968_VerifyOpenTillAfterCloseStore'
---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I36968_VerifyOpenTillAfterCloseStore.java
---
|
|
|
|
|
|
It's failing in quarantine |
|
|
|
(0099918)
|
|
jorge-garcia
|
|
2017-10-16 11:40
|
|
The fix for the issue seems to be correct.
A new related issue has been reported to solve the test problem. |
|
|
|
|
The issue is not correctly resolved. The new if condition is right, but must be introduced into the next if condition that checks if the terminal is a seller terminal (the condition is: "if (OB.MobileApp.model.get('hasPaymentsForCashup')) {"), because a seller terminal mustn't be able to open a store (set the business date).
Also would be nice to review why the TryToOpenStoreWithSeller.java test is not failing, because this test is specifically to test this condition. |
|
|
|
(0100134)
|
|
hgbot
|
|
2017-10-30 09:22
|
|
|
|
|
(0100268)
|
|
xabiermerino
|
|
2017-11-03 13:50
|
|
Steps:
* Open a terminal through WebPOS
* Pay a layaway
* Close the store and tills through Backoffice
* Clean cache
* Log into webPOS
* Realize that the next step is an Initial Count instead of a Cash up (wrong)
* Log into Backoffice
* Realize that the register at Till Status level appears without Cash Up |
|
|
|
(0100368)
|
|
hgbot
|
|
2017-11-09 06:37
|
|
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: af62324a720e87cfd1a8beb38aa5ccdb40f55725
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Nov 09 11:07:30 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/af62324a720e87cfd1a8beb38aa5ccdb40f55725 [^]
Related to issue 36968: Cashup should be done if store closed in backoffice
* If any sales occured in POS, till is closed in backoffice, when opening the POS cashup needs to be done
---
M src/org/openbravo/retail/sessions/CloseSessionActionHandler.java
M src/org/openbravo/retail/sessions/CloseSessionHook.java
M src/org/openbravo/retail/sessions/OpenSessionProcess.java
M src/org/openbravo/retail/sessions/SessionModel.java
M src/org/openbravo/retail/sessions/TerminalProperties.java
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
|
|
|
|
(0100378)
|
|
hgbot
|
|
2017-11-09 12:01
|
|
Repository: tools/automation/pi-mobile
Changeset: 5362ab0dd83cf963fd305b6afcd26953fd3fc6e8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Nov 09 16:30:40 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5362ab0dd83cf963fd305b6afcd26953fd3fc6e8 [^]
Verifies issue 36968 : Modified automated test 'I36968_VerifyOpenTillAfterCloseStore'
---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I36968_VerifyOpenTillAfterCloseStore.java
---
|
|
|
|
|
I still see some incorrect behaviour:
- Open store
- Log in web pos, and open till
- Do some orders
- Clear browser cache
- Go to backend, and close till manually in the backend
- Close store
- Log in web pos
In this case, Web POS should ask you to do the cashup, before anything else is done. However, it's prompting the user to open the store again, and then open a new till, so previous till remains closed in backend forever, and the cashup for it is never executed. |
|
|
|
(0100482)
|
|
hgbot
|
|
2017-11-13 13:10
|
|
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: c3fe040466e492457454fbad62db941346684704
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Nov 13 17:40:19 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/c3fe040466e492457454fbad62db941346684704 [^]
Related to issue 36968: Cashup should be done if store closed in backoffice
* If till is closed in backoffice, when opening the POS, its mandatory that cashup needs to be done
---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
|
|
|
|
(0100513)
|
|
hgbot
|
|
2017-11-14 12:43
|
|
Repository: tools/automation/pi-mobile
Changeset: bfeaea8f35a1720a7abe5092e51aad1487f603d3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Nov 14 17:12:58 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bfeaea8f35a1720a7abe5092e51aad1487f603d3 [^]
Verifies issue 36968 : Modified automated test 'I36968_VerifyOpenTillAfterCloseStore'
---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I34219_VerifyOpenTillOnCloseStore.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I36968_VerifyOpenTillAfterCloseStore.java
---
|
|