Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0036963 | Retail Modules | Web POS | public | 2017-09-27 17:33 | 2017-10-26 13:34 |
|
| Reporter | malsasua | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 30 | OS Version | Openbravo Appliance 14.04 |
| Product Version | | |
| Target Version | | Fixed in Version | RR18Q1 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | OBPS |
| Support ticket | 48361 |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0036963: Prevent a premature execution of runSyncProcess during the login process (returnToOnline) |
| Description | In poor connection enviroments, we could lost and recover the connection during the login. Recovering the connection forces runSynchProcess execution and in the postProcessFunction of Cashup model we require terminal model.
If that runSynchProccess launched in parallel with the login process, reaches the point where we require terminal before login process loads the terminal, we get an error. |
| Steps To Reproduce | n/a |
| Proposed Solution | Do not execute runSynchProcess till we finish logging in. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0037386 | | closed | migueldejuana | [Procurement] Prevent a premature execution of processPaidOrder during the login process (returnToOnline) |
|
| Attached Files |  returnToOnlinePosterminal.diff (1,075) 2017-09-27 17:34
https://issues.openbravo.com/file_download.php?file_id=11111&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-09-27 17:33 | malsasua | New Issue | |
| 2017-09-27 17:33 | malsasua | Assigned To | => Retail |
| 2017-09-27 17:33 | malsasua | OBNetwork customer | => Yes |
| 2017-09-27 17:33 | malsasua | Support ticket | => 48361 |
| 2017-09-27 17:33 | malsasua | Resolution time | => 1508018400 |
| 2017-09-27 17:33 | malsasua | Triggers an Emergency Pack | => No |
| 2017-09-27 17:34 | malsasua | File Added: returnToOnlinePosterminal.diff | |
| 2017-09-27 17:51 | migueldejuana | Summary | Prevent the execution in pararel of runSyncProcess during the login process => Prevent a premature execution of runSyncProcess during the login process (returnToOnline) |
| 2017-09-27 17:51 | migueldejuana | Description Updated | bug_revision_view_page.php?rev_id=16005#r16005 |
| 2017-09-27 17:51 | migueldejuana | Proposed Solution updated | |
| 2017-09-28 14:24 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2017-09-28 14:24 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-10-04 08:06 | hgbot | Checkin | |
| 2017-10-04 08:06 | hgbot | Note Added: 0099747 | |
| 2017-10-04 08:06 | hgbot | Status | scheduled => resolved |
| 2017-10-04 08:06 | hgbot | Resolution | open => fixed |
| 2017-10-04 08:06 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/53a20166c58ab8626a1e549bae681ca56dea8304 [^] |
| 2017-10-13 14:06 | marvintm | Note Added: 0099906 | |
| 2017-10-13 14:06 | marvintm | Status | resolved => new |
| 2017-10-13 14:06 | marvintm | Resolution | fixed => open |
| 2017-10-23 05:30 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-10-23 09:12 | hgbot | Checkin | |
| 2017-10-23 09:12 | hgbot | Note Added: 0099982 | |
| 2017-10-23 09:12 | hgbot | Status | scheduled => resolved |
| 2017-10-23 09:12 | hgbot | Resolution | open => fixed |
| 2017-10-23 09:12 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/53a20166c58ab8626a1e549bae681ca56dea8304 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/61c87e5f57f96cbefdc1104a419bbcf02d058159 [^] |
| 2017-10-26 13:34 | marvintm | Review Assigned To | => marvintm |
| 2017-10-26 13:34 | marvintm | Status | resolved => closed |
| 2017-10-26 13:34 | marvintm | Fixed in Version | => RR18Q1 |
| 2017-11-27 09:41 | migueldejuana | Relationship added | related to 0037386 |
|
Notes |
|
|
(0099747)
|
|
hgbot
|
|
2017-10-04 08:06
|
|
|
|
|
|
There are currently two problems with the fix:
- If connection is lost, and comes back, during login, runSyncProcess is not executed, and this is correct, because it's actually the goal of the fix. However, in this case, runSyncProcess should then be called at the end of the login process, and this never happens. The reason is this line:
if (OB.MobileApp.model.get('isLoggingIn')) {
When login is finished, isLoggingIn is changed to false, so the runSyncProcess is not triggered.
- The second problem is that the on event is supposed to be removed by the off statement, but this also never happens. The reason is that the callback passed as a parameter is not correct instead of the this.returnToOnline function it should be the function passed as callback to the "on" statement. |
|
|
|
(0099982)
|
|
hgbot
|
|
2017-10-23 09:12
|
|
|