Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0036943 | Retail Modules | Web POS | public | 2017-09-25 13:19 | 2017-10-06 13:47 |
|
| Reporter | aaroncalero | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR18Q1 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0036943: It is possible to void a layaway while it is being paid in a different terminal |
| Description | It is possible to open the same layaway in two different terminals, complete the payment of the layaway in one terminal, and without reloading the layaway on the second terminal, void it.
Since the layaway on the second terminal doesn't have any payment loaded, no return payments are created, and the status of the layaway in backend is inconsistent: all quantities are set to 0, the status is changed to closed, but there is a payment on the receipt. |
| Steps To Reproduce | Login in webpos in terminal VBS-1
Create a new layaway (Menu > Layaway this receipt).
Add an Avalanche Transceiver; the total of the layaway will be 150.5€
Click on the total amount button to navigate to the payment tab.
Click on Layaway to process the layaway.
Open the layaway again in webpos.
In a different browser, login in terminal VBS1001.
Open the same layaway.
In terminal VBS-1 click again on the total amount button and pay the layaway completely.
In terminal VBS1001 go to the Menu > Void this layaway; the payment tab will be shown with no payments. Click on Done to validate.
Login in backoffice, go to the Sales Order window and verify the newly created/paid/voided ticket. |
| Proposed Solution | Currently there is a check on the Orderloader to prevent concurrent modifications to a ticket (comparing the "loaded" attribute on the order json).
The void layaway process doesn't use the orderloader, instead it uses the ProcessVoidLayaway process, which doesn't have the check of the "loaded" attribute.
This check should also be present on ProcessVoidLayaway. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  issue 36943 source pos 6798.patch (5,592) 2017-09-28 16:00
https://issues.openbravo.com/file_download.php?file_id=11119&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-09-25 13:19 | aaroncalero | New Issue | |
| 2017-09-25 13:19 | aaroncalero | Assigned To | => Retail |
| 2017-09-25 13:19 | aaroncalero | Resolution time | => 1507500000 |
| 2017-09-25 13:19 | aaroncalero | Triggers an Emergency Pack | => No |
| 2017-09-27 09:03 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2017-09-27 09:03 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-09-28 16:00 | ranjith_qualiantech_com | File Added: issue 36943 source pos 6798.patch | |
| 2017-10-04 08:09 | hgbot | Checkin | |
| 2017-10-04 08:09 | hgbot | Note Added: 0099748 | |
| 2017-10-04 08:09 | hgbot | Status | scheduled => resolved |
| 2017-10-04 08:09 | hgbot | Resolution | open => fixed |
| 2017-10-04 08:09 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/486be89e7b0f0e2bdb81330dcd2a14555f548bd8 [^] |
| 2017-10-06 13:47 | marvintm | Review Assigned To | => marvintm |
| 2017-10-06 13:47 | marvintm | Status | resolved => closed |
| 2017-10-06 13:47 | marvintm | Fixed in Version | => RR18Q1 |