Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036937Openbravo ERPA. Platformpublic2017-09-25 10:542017-09-26 15:25
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036937: update.database source data queries current time to DB for each change
DescriptionWhen updating database, each change in source data queries DB for current time stamp.
Steps To Reproduce0. Enable logging all DB statements
1. run update.database ensuring there are changes in source data
  -> check there are as many queries to "select now() from dual" as changes detected in source data
Proposed SolutionAssuming db and sources server are in the same time zone, it's not necessary to query data to DB, being possible to calculate it in JVM preventing in this way round trips to DB.
Additional Information
TagsPerformance
Relationships
related to defect 0035653 closed alostale update.database can fail updating src tables with a check constraint where more than one column participates 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-25 10:54alostaleNew Issue
2017-09-25 10:54alostaleAssigned To => platform
2017-09-25 10:54alostaleOBNetwork customer => No
2017-09-25 10:54alostaleModules => Core
2017-09-25 10:54alostaleTriggers an Emergency Pack => No
2017-09-25 10:54alostaleAssigned Toplatform => alostale
2017-09-25 10:55alostaleReview Assigned To => AugustoMauch
2017-09-25 10:55alostaleRelationship addedrelated to 0035653
2017-09-25 10:55alostaleTag Attached: Performance
2017-09-25 11:23hgbotCheckin
2017-09-25 11:23hgbotNote Added: 0099525
2017-09-25 11:23hgbotStatusnew => resolved
2017-09-25 11:23hgbotResolutionopen => fixed
2017-09-25 11:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/ecd35e9def0f0f83e1b53bfb1af3098034ba37c8 [^]
2017-09-25 11:23hgbotCheckin
2017-09-25 11:23hgbotNote Added: 0099527
2017-09-25 11:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/ecd35e9def0f0f83e1b53bfb1af3098034ba37c8 [^] => http://code.openbravo.com/erp/devel/pi/rev/5778a1eb46718a99ff7479e483a108f24a529198 [^]
2017-09-25 15:20AugustoMauchNote Added: 0099562
2017-09-25 15:20AugustoMauchStatusresolved => closed
2017-09-26 15:25hudsonbotCheckin
2017-09-26 15:25hudsonbotNote Added: 0099588

Notes
(0099525)
hgbot   
2017-09-25 11:23   
Repository: erp/devel/dbsm-main
Changeset: ecd35e9def0f0f83e1b53bfb1af3098034ba37c8
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Sep 25 10:41:15 2017 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/ecd35e9def0f0f83e1b53bfb1af3098034ba37c8 [^]

fixed bug 36937: update.database source data queries time to DB for each change

  There is not need to query current time from DB. Now it is calculated in JVM
  instead.

---
M src/org/apache/ddlutils/platform/PlatformImplBase.java
---
(0099527)
hgbot   
2017-09-25 11:23   
Repository: erp/devel/pi
Changeset: 5778a1eb46718a99ff7479e483a108f24a529198
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Sep 25 11:04:14 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5778a1eb46718a99ff7479e483a108f24a529198 [^]

fixed bug 36937, fixed bug 35653: dbsm fixing those 2 issues

---
M src-db/database/lib/dbsourcemanager.jar
---
(0099562)
AugustoMauch   
2017-09-25 15:20   
Code reviewed and verified
(0099588)
hudsonbot   
2017-09-26 15:25   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8fa643b4437e [^]
Maturity status: Test