Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036923Openbravo ERPZ. Otherspublic2017-09-21 23:062017-09-22 10:26
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036923: api-changes related to unused code removal
DescriptionIn issues marked as related some unused code has been removed.

This issue lists all the api-changes related to this code-removal

1.) servlets:
- org.openbravo.erpCommon.ad_forms.HeartbeatConfirm
- org.openbravo.erpCommon.ad_forms.RegistrationConfirm
2.) RequestFilter: org.openbravo.utils.CacheFilter
3.) servlet: org.openbravo.erpCommon.businessUtility.TabFilter
- related entry in table ad_model_object (id: 800663)
- related entry in table ad_model_object_mapping (id: 800834)
4.) obsolete ant targets:
- ant import.sample.data.old
- ant export.sample.data.old
- java classes implementing those:
  - class org.openbravo.service.db.ExportReferenceDataTask
  - class org.openbravo.service.db.ImportReferenceDataTask
  - class org.openbravo.service.db.ReferenceDataTask
5.) obsolete ant target:
- ant check.window.compatibility
- class: org.openbravo.client.application.WindowsInClassicModeTask
Steps To Reproduce-
Proposed Solution
Additional Information
TagsApproved
Relationships
related to defect 0036502 closed shuehner ant check.window.compatibility task is no longer useful (as Wad shows error per window now for those) 
related to defect 0036501 closed shuehner Remove unused & old export.sample.data.old & import.sample.data.old 
related to feature request 0009533 closed shuehner Remove unused TabFilter files 
related to defect 0034500 closed shuehner Delete unused CacheFilter class 
related to defect 0036279 closed shuehner Unused manual servlets: HeartbeatConfirm & RegistrationConfirm 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-21 23:06shuehnerNew Issue
2017-09-21 23:06shuehnerAssigned To => shuehner
2017-09-21 23:06shuehnerModules => Core
2017-09-21 23:06shuehnerTriggers an Emergency Pack => No
2017-09-21 23:06shuehnerRelationship addedrelated to 0036502
2017-09-21 23:06shuehnerRelationship addedrelated to 0036501
2017-09-21 23:06shuehnerRelationship addedrelated to 0009533
2017-09-21 23:06shuehnerRelationship addedrelated to 0034500
2017-09-21 23:06shuehnerRelationship addedrelated to 0036279
2017-09-21 23:12hgbotCheckin
2017-09-21 23:12hgbotNote Added: 0099445
2017-09-21 23:12hgbotStatusnew => resolved
2017-09-21 23:12hgbotResolutionopen => fixed
2017-09-21 23:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/ecfcfdba79e26e1e896f6bef5d8157777e7b3f71 [^]
2017-09-21 23:14shuehnerReview Assigned To => alostale
2017-09-22 10:26alostaleTag Attached: Approved
2017-09-22 10:26alostaleStatusresolved => closed

Notes
(0099445)
hgbot   
2017-09-21 23:12   
Repository: erp/devel/api-checks
Changeset: ecfcfdba79e26e1e896f6bef5d8157777e7b3f71
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Sep 21 22:50:32 2017 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/ecfcfdba79e26e1e896f6bef5d8157777e7b3f71 [^]

Fixed 36923. Accept api-change related to unused code removal.

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---