Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036897Openbravo ERPA. Platformpublic2017-09-19 18:162018-01-03 12:39
ReporterJONHM 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket48224
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036897: Different types of date format when using the @#Date@ default value into a String reference
DescriptionWe obtain different types of date format when using the @#Date@ default value into a String reference. It is caused because referenceQry used in UIDefinitionController class is not been ordered
Steps To Reproduce1) Open "Physical Inventory" window and create a new record

Depends on the environment, the format of 'Name' field is different.
Proposed SolutionThis query does not have an 'order by' clause:
https://code.openbravo.com/erp/devel/pi/file/27a01d1d9bee/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinitionController.java#l125 [^]

But anyway it could be useful to decide one unique reference to use in this case or set a new preference to let the user to decide it.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00163993.0RC6 closed mtaal Price List Version is filled with wrong values if date format is not default 
Attached Filespng environmentA.png (82,526) 2017-09-19 18:29
https://issues.openbravo.com/file_download.php?file_id=11076&type=bug
png

png environmentB.png (81,831) 2017-09-19 18:29
https://issues.openbravo.com/file_download.php?file_id=11077&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-09-19 18:16JONHMNew Issue
2017-09-19 18:16JONHMAssigned To => platform
2017-09-19 18:16JONHMOBNetwork customer => Yes
2017-09-19 18:16JONHMModules => Core
2017-09-19 18:16JONHMSupport ticket => 48224
2017-09-19 18:16JONHMTriggers an Emergency Pack => No
2017-09-19 18:23JONHMSummaryDifferent types of date format when using the @#Date@ default value in a String reference => Different types of date format when using the @#Date@ default value into a String reference
2017-09-19 18:23JONHMDescription Updatedbug_revision_view_page.php?rev_id=15939#r15939
2017-09-19 18:23JONHMProposed Solution updated
2017-09-19 18:29JONHMFile Added: environmentA.png
2017-09-19 18:29JONHMFile Added: environmentB.png
2017-10-04 10:12PracticsIssue Monitored: Practics
2017-11-24 09:42caristuRelationship addedrelated to 0016399
2017-11-24 09:54caristuNote Added: 0100696
2017-11-24 09:54caristuStatusnew => acknowledged
2017-11-28 14:05caristuStatusacknowledged => scheduled
2017-11-28 14:05caristuAssigned Toplatform => caristu
2017-11-28 16:24caristuAssigned Tocaristu => platform
2017-11-28 16:24caristuStatusscheduled => acknowledged
2017-12-13 19:27caristuAssigned Toplatform => jarmendariz
2017-12-14 11:02caristuStatusacknowledged => scheduled
2017-12-15 13:50hgbotCheckin
2017-12-15 13:50hgbotNote Added: 0101061
2017-12-15 13:50hgbotStatusscheduled => resolved
2017-12-15 13:50hgbotResolutionopen => fixed
2017-12-15 13:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b0c64f2ef32ddf4a0a7a5967951fc55b329791f9 [^]
2017-12-15 13:51caristuReview Assigned To => caristu
2017-12-15 13:51caristuNote Added: 0101062
2017-12-15 13:51caristuStatusresolved => closed
2017-12-15 13:51caristuFixed in Version => 3.0PR18Q1
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101527

Notes
(0100696)
caristu   
2017-11-24 09:54   
Need to decide which is the best criteria to select the most suitable DateUIDefinition to parse the date in this case.
(0101061)
hgbot   
2017-12-15 13:50   
Repository: erp/devel/pi
Changeset: b0c64f2ef32ddf4a0a7a5967951fc55b329791f9
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Dec 15 09:16:47 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b0c64f2ef32ddf4a0a7a5967951fc55b329791f9 [^]

Fixes bug 36897: Inconsistent date format for default value in String reference

Depending on which UIDefinition is picked up first, different Date UIDefinitions could be used to format the @#Date@ expression as the default value of a String field. Now we use DateTimeUIDefinition to ensure we always apply the same date format.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
---
(0101062)
caristu   
2017-12-15 13:51   
Code reviewed + tested OK.
(0101527)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test