Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036891Retail ModulesWeb POSpublic2017-09-19 13:582017-10-26 13:09
Reporterguilleaer 
Assigned Toguilleaer 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q1Fixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036891: [SCO][Contribution] When a line is deleted, undo actions only should be done when undo property exists
DescriptionActions done in function finishDelete when a line is deleted are assuming that property undo exists, however (in strange cases) this property can not exists and cause and error.
Make sense to check the existence of the property before execute actions against it
Steps To ReproduceN/A
Proposed SolutionCheck that property exists before do actions with that property
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 36891.diff (6,113) 2017-09-19 13:59
https://issues.openbravo.com/file_download.php?file_id=11073&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-09-19 13:58guilleaerNew Issue
2017-09-19 13:58guilleaerAssigned To => guilleaer
2017-09-19 13:58guilleaerTriggers an Emergency Pack => No
2017-09-19 13:59guilleaerFile Added: 36891.diff
2017-09-19 15:49guilleaerDescription Updatedbug_revision_view_page.php?rev_id=15935#r15935
2017-09-21 08:44guilleaerTarget Version => RR18Q1
2017-09-21 08:44guilleaerSummary[SCO][Contribution][18Q1] When a line is deleted, undo actions only should be done when undo property exists => [SCO][Contribution] When a line is deleted, undo actions only should be done when undo property exists
2017-10-03 21:12hgbotCheckin
2017-10-03 21:12hgbotNote Added: 0099743
2017-10-03 21:12hgbotStatusnew => resolved
2017-10-03 21:12hgbotResolutionopen => fixed
2017-10-03 21:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/95deeb2eacc0d5a296ab59fe9e848e551d5096eb [^]
2017-10-17 16:27guilleaerReview Assigned To => marvintm
2017-10-26 13:09marvintmStatusresolved => closed
2017-10-26 13:09marvintmFixed in Version => RR18Q1

Notes
(0099743)
hgbot   
2017-10-03 21:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 95deeb2eacc0d5a296ab59fe9e848e551d5096eb
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Oct 03 09:05:11 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/95deeb2eacc0d5a296ab59fe9e848e551d5096eb [^]

Fixed issue 36891: undo actions are secured before execute them

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---