Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036882Openbravo ERPA. Platformpublic2017-09-18 18:222017-09-22 09:48
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036882: There exists some old callouts in core still not refactored to SimpleCallout
DescriptionWith the fix for issue 0036559 the Platform callouts were refactored to SimpleCallout.

But there are still two callouts not refactored to SimpleCallout:

 - FixedValueExpressionCallout: used to evaluate the JS fixed expressions defined in the OBUIAPP_Parameter table. (For example it can be tested in the Parameter tab of the Widget window)
 
 - DefaultExpressionCallout: used to evaluate the JS filter expression of a selector (OBUISEL_Selector) and the default expression that can be added to a selector field (OBUISEL_Selector_Field).

Both callouts extend JSExpressionCallout which currently extends HttpSecureAppServlet (old implementation)
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036834 closed caristu jre8: js defaults containing Dates fail 
depends on defect 0036599 closed alostale API change: platform callouts now implement SimpleCallout 
related to defect 0036559 closed alostale Old callouts should be refactored to implement SimpleCallout 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-18 18:22caristuNew Issue
2017-09-18 18:22caristuAssigned To => platform
2017-09-18 18:22caristuModules => Core
2017-09-18 18:22caristuTriggers an Emergency Pack => No
2017-09-18 18:23caristuRelationship addedrelated to 0036559
2017-09-18 18:23caristuAssigned Toplatform => caristu
2017-09-18 18:31caristuSummaryThere are exists some old callouts still not refactored to SimpleCallout => There exists some old callouts in core still not refactored to SimpleCallout
2017-09-18 18:38caristuRelationship addedrelated to 0036883
2017-09-20 16:15caristuRelationship addedhas duplicate 0036834
2017-09-20 16:15caristuRelationship deletedhas duplicate 0036834
2017-09-20 16:15caristuRelationship addedrelated to 0036834
2017-09-21 10:08caristuDescription Updatedbug_revision_view_page.php?rev_id=15955#r15955
2017-09-21 10:09caristuRelationship addeddepends on 0036599
2017-09-21 13:07caristuDescription Updatedbug_revision_view_page.php?rev_id=15958#r15958
2017-09-21 13:09hgbotCheckin
2017-09-21 13:09hgbotNote Added: 0099209
2017-09-21 13:09hgbotStatusnew => resolved
2017-09-21 13:09hgbotResolutionopen => fixed
2017-09-21 13:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/23baba607b96309d0ae08f88d4b0fa936131bb56 [^]
2017-09-21 13:10hgbotCheckin
2017-09-21 13:10hgbotNote Added: 0099210
2017-09-21 13:13caristuReview Assigned To => alostale
2017-09-22 03:19hudsonbotCheckin
2017-09-22 03:19hudsonbotNote Added: 0099449
2017-09-22 09:48alostaleNote Added: 0099460
2017-09-22 09:48alostaleStatusresolved => closed
2017-09-22 09:48alostaleFixed in Version => 3.0PR17Q4

Notes
(0099209)
hgbot   
2017-09-21 13:09   
Repository: erp/devel/pi
Changeset: 23baba607b96309d0ae08f88d4b0fa936131bb56
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Sep 21 12:49:13 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/23baba607b96309d0ae08f88d4b0fa936131bb56 [^]

fixes issue 36882: JSExpressionCallout extends SimpleCallout

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/FixedValueExpressionCallout.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/JSExpressionCallout.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/DefaultExpressionCallout.java
---
(0099210)
hgbot   
2017-09-21 13:10   
Repository: erp/devel/api-checks
Changeset: 50fd6b3533596957929f3c8e1959cc8203721742
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Sep 21 12:34:42 2017 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/50fd6b3533596957929f3c8e1959cc8203721742 [^]

related to issue 36882: JSExpressionCallout now extends SimpleCallout

---
M java/reference/java.japi.gz
---
(0099449)
hudsonbot   
2017-09-22 03:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/79f756868bba [^]
Maturity status: Test
(0099460)
alostale   
2017-09-22 09:48   
reviewed