Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036879Openbravo ERPA. Platformpublic2017-09-18 16:202017-09-21 16:50
caristu 
shuehner 
highminorN/A
closedfixed 
5
 
3.0PR17Q4 
caristu
Core
No
0036879: Clean-up unused Sqlc parameters related with the Login page
In the code involved in the Login page there exists some Sqlc parameters defined in XML which do not have a matching entry in the corresponding HTML file.

Therefore they are not being used and they can be cleaned-up.
In decription
No tags attached.
related to defect 0035763 closed caristu User name should be retrieved using admin mode in VerticalMenu 
related to feature request 0035386 closed caristu Login page needs some clean up 
related to defect 0036353 acknowledged Triage Platform Base VerticalMenu needs additional clean up 
diff login-cleanup.diff (4,638) 2017-09-18 16:20
https://issues.openbravo.com/file_download.php?file_id=11071&type=bug
Issue History
2017-09-18 16:20caristuNew Issue
2017-09-18 16:20caristuAssigned To => caristu
2017-09-18 16:20caristuModules => Core
2017-09-18 16:20caristuTriggers an Emergency Pack => No
2017-09-18 16:20caristuFile Added: login-cleanup.diff
2017-09-18 16:21caristuNote Added: 0099120
2017-09-18 16:21caristuRelationship addedrelated to 0035763
2017-09-18 16:21caristuRelationship addedrelated to 0035386
2017-09-18 16:22caristuRelationship addedrelated to 0036353
2017-09-18 19:30shuehnerIssue Monitored: shuehner
2017-09-21 09:28hgbotCheckin
2017-09-21 09:28hgbotNote Added: 0099198
2017-09-21 09:28hgbotStatusnew => resolved
2017-09-21 09:28hgbotResolutionopen => fixed
2017-09-21 09:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/86eeae5460117058254e8419d9a4fcb2a8ef99c7 [^]
2017-09-21 09:28caristuAssigned Tocaristu => shuehner
2017-09-21 09:33hgbotCheckin
2017-09-21 09:33hgbotNote Added: 0099199
2017-09-21 09:34caristuReview Assigned To => caristu
2017-09-21 09:34caristuNote Added: 0099200
2017-09-21 09:34caristuStatusresolved => closed
2017-09-21 09:34caristuFixed in Version => 3.0PR17Q4
2017-09-21 16:50hudsonbotCheckin
2017-09-21 16:50hudsonbotNote Added: 0099431
2017-09-21 16:50hudsonbotCheckin
2017-09-21 16:50hudsonbotNote Added: 0099432

Notes
(0099120)
caristu   
2017-09-18 16:21   
Attached a patch provided by Stefan
(0099198)
hgbot   
2017-09-21 09:28   
Repository: erp/devel/pi
Changeset: 86eeae5460117058254e8419d9a4fcb2a8ef99c7
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Sep 21 09:02:15 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/86eeae5460117058254e8419d9a4fcb2a8ef99c7 [^]

fixes issue 36879: Clean-up unused Sqlc parameters related with the Login page

---
M src/org/openbravo/erpCommon/security/Login.java
M src/org/openbravo/erpCommon/security/Login.xml
M src/org/openbravo/erpCommon/security/SessionLogin_data.xsql
M src/org/openbravo/erpCommon/utility/VerticalMenu.java
M src/org/openbravo/erpCommon/utility/VerticalMenu.xml
---
(0099199)
hgbot   
2017-09-21 09:33   
Repository: erp/devel/pi
Changeset: 382af6a5db44fb399cf340dd8b9900a6bd87230a
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Sep 21 09:13:51 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/382af6a5db44fb399cf340dd8b9900a6bd87230a [^]

related to issue 36879: updated copyright year

---
M src/org/openbravo/erpCommon/security/Login.xml
M src/org/openbravo/erpCommon/utility/VerticalMenu.xml
---
(0099200)
caristu   
2017-09-21 09:34   
Code reviewed + tested OK.
(0099431)
hudsonbot   
2017-09-21 16:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099432)
hudsonbot   
2017-09-21 16:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test