Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036871Openbravo ERPA. Platformpublic2017-09-15 17:362017-09-22 10:21
shuehner 
shuehner 
normalminorhave not tried
closedfixed 
5
 
3.0PR17Q4 
alostale
Core
No
0036871: Remove all unused and not useful junit tests in org.openbravo.test.ant package
That javapackage contains/-ed 4 test-classes which are not used in any test-suite. Apart they inherit from BaseAntTests which is broken as it has never been updated after src-test code-moving a long time ago (needs to search 8 levels up not 7).

- AntTaskTests: calling compile.complete, update.database, wad (in src), import.reference.data, create.database
Calling those targets only from inside eclipse is not useful really, as some don't exist anymore, others leave system in inconsisten state (create.database without compiling)
- CallWadTest
Has some path-mismatch so not even working
- RestartTomcatTest
In practice calls ReloadTomcat which is stopped to be used (in gui) for many years as not reliable
- CompressionTest (removed earlier in 36373) calling deprecated minimizeJSandCSS from wrong folder

Apart all those ant targets are testing differently in CI by calling them during normal operation (not as part of junit tests).

-
Remove the 4 test classes and its shared super-class BaseAntTests as dead, not useful code.
No tags attached.
blocks design defect 0032688 acknowledged platform remove unused resources 
Issue History
2017-09-15 17:36shuehnerNew Issue
2017-09-15 17:36shuehnerAssigned To => shuehner
2017-09-15 17:36shuehnerModules => Core
2017-09-15 17:36shuehnerTriggers an Emergency Pack => No
2017-09-15 17:37shuehnerRelationship addedblocks 0032688
2017-09-21 23:11hgbotCheckin
2017-09-21 23:11hgbotNote Added: 0099444
2017-09-21 23:11hgbotStatusnew => resolved
2017-09-21 23:11hgbotResolutionopen => fixed
2017-09-21 23:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b29ea74af729d3cb7c580d5dd8cb917acaf75b54 [^]
2017-09-21 23:12shuehnerReview Assigned To => alostale
2017-09-21 23:12shuehnerFixed in Version => 3.0PR17Q4
2017-09-22 10:21alostaleNote Added: 0099471
2017-09-22 10:21alostaleStatusresolved => closed

Notes
(0099444)
hgbot   
2017-09-21 23:11   
Repository: erp/devel/pi
Changeset: b29ea74af729d3cb7c580d5dd8cb917acaf75b54
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Sep 15 17:38:37 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b29ea74af729d3cb7c580d5dd8cb917acaf75b54 [^]

Fixed 36871. Remove broken,unused junit tests in org.openbravo.test.ant

All those test-classes are not working and also not useful as described in
the issue. Remove those them.

---
R src-test/src/org/openbravo/test/ant/AntTasksTest.java
R src-test/src/org/openbravo/test/ant/BaseAntTest.java
R src-test/src/org/openbravo/test/ant/CallWadTest.java
R src-test/src/org/openbravo/test/ant/RestartTomcatTest.java
---
(0099471)
alostale   
2017-09-22 10:21   
reviewed