Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036856Openbravo ERP07. Sales managementpublic2017-09-14 11:092017-09-21 16:50
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036856: No data found error when completing a invoice in organization without legal accounting in oracle instance
DescriptionNo data found error is shown when completing a invoice in organization without legal accounting in oracle instance

Query in C_Invoice_Post

SELECT C_CALENDAR_ID INTO v_calendarId FROM AD_ORG WHERE AD_ORG_ID = AD_ORG_GETCALENDAROWNER(v_Org_ID) ;

raises the no data error in oracle instance.
Steps To Reproduce- Login as F&B International Group Admin role.
- Use the Initial Org Setup process to create a Legal Without Accounting organization with F&B International Group as parent organization.
- Navigate to created organization and set it as ready.
- Create the required master data in F&B International Group organization:
  - Price Lists (one for sales and one for purchase)
  - Define a payment method, financial account, add payment method to
    financial account.
  - Business partners and locations (one customer and one vendor). Assign
    previously created price list. Set default Payment Terms, payment method.
  - Tax Category and Tax Rate.
  - Product. Add price to it in both price lists
  - Document Type: Sales Invoice and Purchase Invoice

- Create a Sales Invoice in newly created organization for created customer.
- Select Sales Invoice document type
- Add previously created product.
- Try to complete it.
- Realize that no data error is shown.

- Create a Purchase Invoice in newly created organization for created vendor.
- Select Purchase Invoice document type
- Add previously created product.
- Try to complete it.
- Realize that no data error is shown.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036846 closed AtulOpenbravo Modules Cannot complete an inter-company invoice if the target organization or one of their parents are not Legal With Accounting 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-14 11:09AtulOpenbravoNew Issue
2017-09-14 11:09AtulOpenbravoAssigned To => Triage Finance
2017-09-14 11:09AtulOpenbravoOBNetwork customer => No
2017-09-14 11:09AtulOpenbravoModules => Core
2017-09-14 11:09AtulOpenbravoTriggers an Emergency Pack => No
2017-09-14 11:15aferrazAssigned ToTriage Finance => AtulOpenbravo
2017-09-14 12:37AtulOpenbravoStatusnew => scheduled
2017-09-14 12:37AtulOpenbravoNote Added: 0099033
2017-09-14 12:39aferrazRelationship addedrelated to 0036846
2017-09-14 13:48hgbotCheckin
2017-09-14 13:48hgbotNote Added: 0099044
2017-09-14 13:48hgbotStatusscheduled => resolved
2017-09-14 13:48hgbotResolutionopen => fixed
2017-09-14 13:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b870a4109237b9b32ce55bf56782a7cdedd14ee8 [^]
2017-09-14 13:49hgbotCheckin
2017-09-14 13:49hgbotNote Added: 0099045
2017-09-14 13:50aferrazReview Assigned To => aferraz
2017-09-14 13:50aferrazNote Added: 0099046
2017-09-14 13:50aferrazStatusresolved => closed
2017-09-14 13:50aferrazFixed in Version => 3.0PR17Q4
2017-09-21 16:50hudsonbotCheckin
2017-09-21 16:50hudsonbotNote Added: 0099394
2017-09-21 16:50hudsonbotCheckin
2017-09-21 16:50hudsonbotNote Added: 0099395

Notes
(0099033)
AtulOpenbravo   
2017-09-14 12:37   
- Login as F&B International Group Admin role.
- Use the Initial Org Setup process to create a Legal Without Accounting organization with F&B International Group as parent organization.
- Navigate to created organization and set it as ready.
- Create the required master data in F&B International Group organization:
  - Price Lists (one for sales and one for purchase)
  - Define a payment method, financial account, add payment method to
    financial account.
  - Business partners and locations (one customer and one vendor). Assign
    previously created price list. Set default Payment Terms, payment method.
  - Tax Category and Tax Rate.
  - Product. Add price to it in both price lists
  - Document Type: Sales Invoice and Purchase Invoice

- Create a Sales Invoice in newly created organization for created customer.
- Select Sales Invoice document type
- Add previously created product.
- Try to complete it.
- Realize that invoice is completed successfully.

- Create a Purchase Invoice in newly created organization for created vendor.
- Select Purchase Invoice document type
- Add previously created product.
- Try to complete it.
- Realize that invoice is completed successfully.
(0099044)
hgbot   
2017-09-14 13:48   
Repository: erp/devel/pi
Changeset: b870a4109237b9b32ce55bf56782a7cdedd14ee8
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Sep 14 10:47:00 2017 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/b870a4109237b9b32ce55bf56782a7cdedd14ee8 [^]

Fixes issue 36856: No data found error when completing a invoice

No data found error when completing a invoice in
organization without legal accounting in oracle instance

Avoid no data exception in oracle using a null value check for value
returned by AD_ORG_GETCALENDAROWNER

---
M src-db/database/model/functions/C_INVOICE_POST.xml
---
(0099045)
hgbot   
2017-09-14 13:49   
Repository: erp/devel/pi
Changeset: 5883f31bb38c7d931d3e9566fbf1834991f046ae
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Sep 14 13:10:51 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5883f31bb38c7d931d3e9566fbf1834991f046ae [^]

Related to issue 36856: Code review improvements

---
M src-db/database/model/functions/C_INVOICE_POST.xml
---
(0099046)
aferraz   
2017-09-14 13:50   
Code review + Testing OK
(0099394)
hudsonbot   
2017-09-21 16:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099395)
hudsonbot   
2017-09-21 16:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test