Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036854Openbravo ERPA. Platformpublic2017-09-14 09:582017-09-21 16:50
ngarcia 
caristu 
highminoralways
closedfixed 
5
 
3.0PR17Q4 
AugustoMauch
Core
No
0036854: Cannot open Tree Views in Classic Mode if the role does not have access to AD_TAB and AD_TREE tables
Cannot open Tree Views in Classic Mode if the role does not have access to AD_TAB and AD_TREE tables
As group admin role:
   Set the 'Use Classic Popup Tree' preference to 'Y'
   Create a new manual role
   Add all organizations to it
   Add editable access to Account Tree window
   Assign it to Openbravo user

Log in with that role:
   Go to Account Tree - Element Value tab and click on Tree view toolbar button
   The following error is shown:
      org.openbravo.base.exception.OBSecurityException: Entity ADTab is not readable by the user 100

As group admin role:
   Go to Role Access window and add AD_TAB table to the previously created role (Exclude = 'N')

Log in with that role again:
   Go to Account Tree - Element Value tab and click on Tree view toolbar button
   The following error is shown:
      org.openbravo.base.exception.OBSecurityException: Entity ADTree is not directly readable, only id and identifier properties are readable, property ADTree.description is neither of these.
No tags attached.
related to feature request 00259063.0PR14Q2 closed AugustoMauch Tree Extension Project 
Issue History
2017-09-14 09:58ngarciaNew Issue
2017-09-14 09:58ngarciaAssigned To => platform
2017-09-14 09:58ngarciaModules => Core
2017-09-14 09:58ngarciaTriggers an Emergency Pack => No
2017-09-14 09:58ngarciaIssue Monitored: networkb
2017-09-14 13:10caristuRelationship addedrelated to 0025906
2017-09-15 08:57caristuAssigned Toplatform => caristu
2017-09-15 08:57caristuSummaryCannot open Tree Vies in Classic Mode if the role does not have access to AD_TAB and AD_TREE tables => Cannot open Tree Views in Classic Mode if the role does not have access to AD_TAB and AD_TREE tables
2017-09-15 08:57caristuDescription Updatedbug_revision_view_page.php?rev_id=15904#r15904
2017-09-15 09:07hgbotCheckin
2017-09-15 09:07hgbotNote Added: 0099056
2017-09-15 09:07hgbotCheckin
2017-09-15 09:07hgbotNote Added: 0099057
2017-09-15 09:07hgbotStatusnew => resolved
2017-09-15 09:07hgbotResolutionopen => fixed
2017-09-15 09:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ff7766b4dd3ff06a1f306d840bad415b2c884197 [^]
2017-09-15 09:08caristuReview Assigned To => AugustoMauch
2017-09-15 10:20hgbotCheckin
2017-09-15 10:20hgbotNote Added: 0099060
2017-09-15 10:22AugustoMauchNote Added: 0099061
2017-09-15 10:22AugustoMauchStatusresolved => closed
2017-09-15 10:22AugustoMauchFixed in Version => 3.0PR17Q4
2017-09-21 16:50hudsonbotCheckin
2017-09-21 16:50hudsonbotNote Added: 0099397
2017-09-21 16:50hudsonbotCheckin
2017-09-21 16:50hudsonbotNote Added: 0099398
2017-09-21 16:50hudsonbotCheckin
2017-09-21 16:50hudsonbotNote Added: 0099399

Notes
(0099056)
hgbot   
2017-09-15 09:07   
Repository: erp/devel/pi
Changeset: 8a41fb65ea2f691f035854fc0642d8a13b8a58db
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Sep 14 18:07:39 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8a41fb65ea2f691f035854fc0642d8a13b8a58db [^]

related to issue 36854: initial code clean-up
  - Use diamond operator
  - Can use StringBuilder instead of StringBuffer
  - Log error into the log instead of into the standard output
  - Fix typo

---
M src/org/openbravo/erpCommon/utility/WindowTree.java
---
(0099057)
hgbot   
2017-09-15 09:07   
Repository: erp/devel/pi
Changeset: ff7766b4dd3ff06a1f306d840bad415b2c884197
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Sep 15 09:05:09 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ff7766b4dd3ff06a1f306d840bad415b2c884197 [^]

fixes bug 36854: Can't see classic tree view without access to AD_TAB/AD_TREE
  - The AD_Tab and AD_Tree information is now retrieved using the admin mode
  - The code has been refactored to avoid duplication: now that information is retrieved once instead of doing it three times

---
M src/org/openbravo/erpCommon/utility/WindowTree.java
---
(0099060)
hgbot   
2017-09-15 10:20   
Repository: erp/devel/pi
Changeset: 91336238169fed7d9bd6bb1642b24978a23ad8ca
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Sep 15 10:19:40 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/91336238169fed7d9bd6bb1642b24978a23ad8ca [^]

related to issue 36854: code review improvements
- Do not use getters for the private inner class: use attributes directly
- Do not need to initialize treeId to null

---
M src/org/openbravo/erpCommon/utility/WindowTree.java
---
(0099061)
AugustoMauch   
2017-09-15 10:22   
Code reviewed and verified
(0099397)
hudsonbot   
2017-09-21 16:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099398)
hudsonbot   
2017-09-21 16:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099399)
hudsonbot   
2017-09-21 16:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test