Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036841Retail ModulesWeb POSpublic2017-09-12 17:232017-09-20 10:00
Reportermaite 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036841: Should not be necessary to have "Maturity Date 2" defined in Payment Terms defined as "Fixed Due date"
DescriptionTicket left in Errors While Importing when business partner payment terms are defined as "fixed due date" but payment term only has "maturity date 1" defined
Steps To Reproduce0. Define new payment term named "fixed payment term" with "offset days"=30, Fixed due date=Y and "Maturity Date 1"=30
1. Access Business Partner window and set previous payment terms to VBS Customer
2. Access POS Terminal and register Credit Sales for VBS Customer
3. Realize that order is left in Errors While Importing window due to:

java.lang.NullPointerException
    at org.openbravo.retail.posterminal.OrderLoader.getCalculatedDueDateBasedOnPaymentTerms(OrderLoader.java:1955)
    at org.openbravo.retail.posterminal.OrderLoader.handlePayments(OrderLoader.java:2194)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:516)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0036853RR17Q3 closed ranjith_qualiantech_com Should not be necessary to have "Maturity Date 2" defined in Payment Terms defined as "Fixed Due date" 
caused by design defect 0035571 closed ranjith_qualiantech_com wrong payment term in sales invoice created from WebPOS using credit 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-12 17:23maiteNew Issue
2017-09-12 17:23maiteAssigned To => Retail
2017-09-12 17:23maiteResolution time => 1506981600
2017-09-12 17:23maiteTriggers an Emergency Pack => No
2017-09-12 17:24maiteRelationship addedcaused by 0035571
2017-09-12 17:24maiteIssue Monitored: networkb
2017-09-12 17:39PracticsIssue Monitored: Practics
2017-09-13 07:54ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-09-13 07:55ranjith_qualiantech_comStatusnew => scheduled
2017-09-14 09:24hgbotCheckin
2017-09-14 09:24hgbotNote Added: 0099024
2017-09-14 09:24hgbotStatusscheduled => resolved
2017-09-14 09:24hgbotResolutionopen => fixed
2017-09-14 09:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6696cd1b0f1732abd0076a58defc7ead28f63666 [^]
2017-09-14 09:24hgbotCheckin
2017-09-14 09:24hgbotNote Added: 0099025
2017-09-14 09:32ranjith_qualiantech_comNote Added: 0099026
2017-09-14 09:32ranjith_qualiantech_comStatusresolved => new
2017-09-14 09:32ranjith_qualiantech_comResolutionfixed => open
2017-09-14 09:32ranjith_qualiantech_comStatusnew => scheduled
2017-09-14 09:32ranjith_qualiantech_comStatusscheduled => resolved
2017-09-14 09:32ranjith_qualiantech_comResolutionopen => fixed
2017-09-15 14:09marvintmReview Assigned To => marvintm
2017-09-15 14:09marvintmStatusresolved => closed
2017-09-15 14:09marvintmFixed in Version => RR17Q4
2017-09-18 16:31migueldejuanaNote Added: 0099123
2017-09-18 16:31migueldejuanaStatusclosed => new
2017-09-18 16:31migueldejuanaResolutionfixed => open
2017-09-18 16:31migueldejuanaFixed in VersionRR17Q4 =>
2017-09-19 10:18ranjith_qualiantech_comStatusnew => scheduled
2017-09-19 13:04hgbotCheckin
2017-09-19 13:04hgbotNote Added: 0099144
2017-09-20 08:06ranjith_qualiantech_comNote Added: 0099157
2017-09-20 08:06ranjith_qualiantech_comStatusscheduled => resolved
2017-09-20 08:06ranjith_qualiantech_comResolutionopen => fixed
2017-09-20 10:00marvintmStatusresolved => closed
2017-09-20 10:00marvintmFixed in Version => RR17Q4

Notes
(0099024)
hgbot   
2017-09-14 09:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6696cd1b0f1732abd0076a58defc7ead28f63666
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Sep 14 12:53:01 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6696cd1b0f1732abd0076a58defc7ead28f63666 [^]

Fixed issue 36841 : Changes in duedate calculation based on Payment terms

* Due date should be calculated based on MaturityDate1 if MaturityDate2 and MaturityDate3 are null

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0099025)
hgbot   
2017-09-14 09:24   
Repository: tools/automation/pi-mobile
Changeset: a5fb3cdee4afb6a56481effb6f4fae7d87dd7d9b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Sep 14 12:52:46 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a5fb3cdee4afb6a56481effb6f4fae7d87dd7d9b [^]

Verifies issue 36841 : Added automated test 'I36841_VerifyInvoiceDueDateByNewTerms'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I36841_VerifyInvoiceDueDateByNewTerms.java
---
(0099026)
ranjith_qualiantech_com   
2017-09-14 09:32   
Reopening to create backports
(0099123)
migueldejuana   
2017-09-18 16:31   
The test is failing in quarantine
(0099144)
hgbot   
2017-09-19 13:04   
Repository: tools/automation/pi-mobile
Changeset: 3b449d9f60b200e6ad1229eedac7ebc65a3c6b75
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Sep 19 16:34:02 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3b449d9f60b200e6ad1229eedac7ebc65a3c6b75 [^]

Verifies issue 36841 : Modified automated test 'I36841_VerifyInvoiceDueDateByNewTerms'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I36841_VerifyInvoiceDueDateByNewTerms.java
---
(0099157)
ranjith_qualiantech_com   
2017-09-20 08:06   
Test passed in quarantine