Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036838Openbravo ERPA. Platformpublic2017-09-12 11:462018-01-03 12:38
Reporteralostale 
Assigned Toinigosanchez 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036838: multiple requests to load product image when a refresh is done previously
DescriptionWhen a product has an image associated, multiple requests are performed when it is displayed in form view. (refresh should be done after open the record in form view)
Steps To Reproduce1. Open any product in form view and associate it an image and close the form view.
2. Reopen it again in form view (1 request is done: FIC) and refresh it by clicking in the refresh button (2 request are done: FETCH + FIC). Close the form view.
3. Reopen the previous product in form view (2 request are done: target_request_to_remove + FIC).
  -> Check requests:
    * 2 x ImagesActionHandler GETSIZE
    * 2 x ShowImage
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 00230543.0MP22 closed shankarb Impossible to add change client image 
related to defect 0037095 closed inigosanchez A request to load product image is performed when return from FormView to the GridView 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-12 11:46alostaleNew Issue
2017-09-12 11:46alostaleAssigned To => platform
2017-09-12 11:46alostaleOBNetwork customer => No
2017-09-12 11:46alostaleModules => Core
2017-09-12 11:46alostaleTriggers an Emergency Pack => No
2017-09-12 11:46alostaleTag Attached: Performance
2017-09-12 11:46alostalePrioritynormal => high
2017-09-12 11:46alostaleStatusnew => acknowledged
2017-10-16 17:06inigosanchezStatusacknowledged => scheduled
2017-10-16 17:06inigosanchezAssigned Toplatform => inigosanchez
2017-10-17 11:31inigosanchezSummarymultiple requests to load product image => multiple requests to load product image when a refresh is done previously
2017-10-17 11:31inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=16113#r16113
2017-10-17 11:31inigosanchezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16115#r16115
2017-10-18 10:02inigosanchezRelationship addedrelated to 0023054
2017-10-18 10:27inigosanchezRelationship addedrelated to 0037095
2017-10-18 16:11hgbotCheckin
2017-10-18 16:11hgbotNote Added: 0099939
2017-10-18 16:11hgbotStatusscheduled => resolved
2017-10-18 16:11hgbotResolutionopen => fixed
2017-10-18 16:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/94f7f53523045d4609d5c38bc412585ec1a3527b [^]
2017-10-18 16:12inigosanchezReview Assigned To => alostale
2017-10-24 13:08alostaleNote Added: 0100024
2017-10-24 13:08alostaleStatusresolved => new
2017-10-24 13:08alostaleResolutionfixed => open
2017-10-28 13:28hgbotCheckin
2017-10-28 13:28hgbotNote Added: 0100128
2017-10-28 13:28inigosanchezStatusnew => scheduled
2017-10-28 13:29inigosanchezStatusscheduled => resolved
2017-10-28 13:29inigosanchezFixed in Version => 3.0PR18Q1
2017-10-28 13:29inigosanchezResolutionopen => fixed
2017-10-29 02:45hgbotCheckin
2017-10-29 02:45hgbotNote Added: 0100129
2017-10-29 02:48hgbotCheckin
2017-10-29 02:48hgbotNote Added: 0100130
2017-11-03 09:11alostaleNote Added: 0100238
2017-11-03 09:11alostaleStatusresolved => closed
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101335
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101352

Notes
(0099939)
hgbot   
2017-10-18 16:11   
Repository: erp/devel/pi
Changeset: 94f7f53523045d4609d5c38bc412585ec1a3527b
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Oct 18 15:55:58 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/94f7f53523045d4609d5c38bc412585ec1a3527b [^]

Fixed issue 36838: multiple requests to load product image are performed

The problem was that multiple requests were performed when it shouldn't. When a product had an image, multiple
requests were being performed when the product was beeing displayed in form view and a refresh was being done.
Another problem discovered in the research of the issue was that a request was being performed when return from
FormView to the GridView. This request should not be performed because images are not showed in the grid view.

Both problems have been fixed by take into account when a request should be performed to retrieve an image. When
the image is loaded previously, the setValue of the ob-formitem-image avoids to performed an unnecessary request
to the server.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-image.js
---
(0100024)
alostale   
2017-10-24 13:08   
reopened: still duplicates to showImage
(0100128)
hgbot   
2017-10-28 13:28   
Repository: erp/devel/pi
Changeset: 82a3e88a20e8998b5bdb476a81b066f6121bb1b1
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Sat Oct 28 13:27:49 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/82a3e88a20e8998b5bdb476a81b066f6121bb1b1 [^]

Related with issue 36838: multiple requests to load product image are performed

The problem was that multiple ShowImage requests were performed when it shouldn't.

Now, the problem is fixed by take into account when the image has been loaded previously. In this case,
the setValue of the ob-formitem-image avoids to performed an unnecessary request to the server.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-image.js
---
(0100129)
hgbot   
2017-10-29 02:45   
Repository: erp/devel/pi
Changeset: 82a3e88a20e8998b5bdb476a81b066f6121bb1b1
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Sat Oct 28 13:27:49 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/82a3e88a20e8998b5bdb476a81b066f6121bb1b1 [^]

Related with issue 36838: multiple requests to load product image are performed

The problem was that multiple ShowImage requests were performed when it shouldn't.

Now, the problem is fixed by take into account when the image has been loaded previously. In this case,
the setValue of the ob-formitem-image avoids to performed an unnecessary request to the server.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-image.js
---
(0100130)
hgbot   
2017-10-29 02:48   
Repository: erp/devel/pi
Changeset: 82a3e88a20e8998b5bdb476a81b066f6121bb1b1
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Sat Oct 28 13:27:49 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/82a3e88a20e8998b5bdb476a81b066f6121bb1b1 [^]

Related with issue 36838: multiple requests to load product image are performed

The problem was that multiple ShowImage requests were performed when it shouldn't.

Now, the problem is fixed by take into account when the image has been loaded previously. In this case,
the setValue of the ob-formitem-image avoids to performed an unnecessary request to the server.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-image.js
---
(0100238)
alostale   
2017-11-03 09:11   
reviewed + tested
(0101335)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101352)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test