0036831: Wrong average cost after negative stock correction: Total Stock Valuation of Costing tab is not updated - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

ID

Project

Category

View Status

Date Submitted

Last Update

0036831

Openbravo ERP

04. Warehouse management

public

2017-09-11 18:36

2017-09-21 16:50

Reporter

ngarcia

Assigned To

AtulOpenbravo

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

5

OS Version

Product Version

Target Version

Fixed in Version

3.0PR17Q4

Merge Request Status

Review Assigned To

aferraz

OBNetwork customer

OBPS

Web browser

Modules

Core

Support ticket

47904

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0036831: Wrong average cost after negative stock correction: Total Stock Valuation of Costing tab is not updated

Description

Wrong average cost after negative stock correction: Total Stock Valuation of Costing tab is not updated

Steps To Reproduce

As group admin role:

   Set the Enable Negative Stock Correction preference to Y
   Log out and log in

   Check the costing rule for F&B US, Inc. is validated without Warehouse Dimension
   Create a new stocked product in F&B US, Inc.
   Add a price of 6USD in Be Soft Dinker Price List
   Create a Goods Receipt for F&B US East Coast, add 2 units of it and complete it
   Create a Physical Inventory for F&B US West Coast, add 1 unit of it a cost of 12 and process it
   Create a Goods Shipment for F&B US East Coast, add 2 units of it and complete it
   Launch the Costing Background Process and check a current average cost of 8 is obtained

   Create a new Costing Rule for F&B US, Inc. with Warehouse Dimension
   Validate it

   Create a Goods Receipt for F&B US East Coast, add 1 unit of it and complete it
   Create another Goods Receipt for F&B US East Coast, add 1 unit of it and complete it

   Launch the Costing Background Process again and check although the first average cost for US East Coast is 6USD and a negative stock correction of 4USD has been made against the related transaction (I+) the Total Stock Valuation is 2 (-4 + 6). Thus, the current stock valuation is 8 and the current average cost is 4USD (it should be 6USD)

Proposed Solution

Attached a possible fix that should be properly reviewed and tested.

Additional Information

Tags

No tags attached.

Relationships

related to	design defect	0036642		new	Triage Omni WMS	[Costing Migration Process] Stock valuation should be updated to 0 when the stock of the product is 0
related to	defect	0033968	3.0PR17Q1	closed	dmiguelez	Wrong costs calculated with Backdated Transactions
related to	backport	0029891	3.0PR15Q2.1	closed	umartirena	Wrong Total Movement quantity in the costing tab with backdated transactions

Attached Files

diff

36831.diff (2,731) 2017-09-12 17:47
https://issues.openbravo.com/file_download.php?file_id=11057&type=bug

Issue History

Date Modified

Username

Field

Change

2017-09-11 18:36

New Issue

2017-09-11 18:36

Assigned To

=> Triage Finance

2017-09-11 18:36

OBNetwork customer

=> Yes

2017-09-11 18:36

Modules

=> Core

2017-09-11 18:36

Support ticket

=> 47904

2017-09-11 18:36

Resolution time

=> 1506895200

2017-09-11 18:36

Triggers an Emergency Pack

=> No

2017-09-11 18:37

Issue Monitored: networkb

2017-09-11 18:40

Relationship added

related to 0036642

2017-09-12 14:37

Assigned To

Triage Finance => markmm82

2017-09-12 14:50

Relationship added

related to 0033968

2017-09-12 14:50

Relationship added

related to 0029891

2017-09-12 17:47

File Added: 36831.diff

2017-09-12 17:50

Proposed Solution updated

2017-09-15 13:28

Assigned To

markmm82 => AtulOpenbravo

2017-09-18 14:35

Status

new => scheduled

2017-09-18 14:38

Note Added: 0099117

2017-09-18 16:13

Note Added: 0099119

2017-09-18 18:20

Checkin

2017-09-18 18:20

Note Added: 0099130

2017-09-18 18:20

Status

scheduled => resolved

2017-09-18 18:20

Resolution

open => fixed

2017-09-18 18:20

Fixed in SCM revision

=> http://code.openbravo.com/erp/devel/pi/rev/ff6e0aa17abcc50e6c3389ac6eff9514a1055c62 [^]

2017-09-18 18:56

Review Assigned To

=> aferraz

2017-09-18 18:56

Note Added: 0099131

2017-09-18 18:56

Status

resolved => closed

2017-09-18 18:56

Fixed in Version

=> 3.0PR17Q4

2017-09-21 16:50

Checkin

2017-09-21 16:50

Note Added: 0099413

Notes

Test Plan 29891
- Login as F&B International Group Admin role
- Go to product window, create new record
  - Organization: F&B US Inc
  - Search Key: 29891
  - Name: test 29891
  - In Price Tab, add record for Be Soft Drinker price list
     Set Unit Price: 2, List Price: 2

- Go to Purchase order, create a new one for Be Soft Drinker
- In Lines tab, add test 29891 product, set Qty: 200, process order

- Go to Goods Receipt window, create record for Be Soft Drinker set movement date: two weeks ago
- select the order line created before and process it.

- Go to Purchase order, create a new one for Be Soft Drinker
- In Lines tab, add test 29891 product, set Qty: 380, process order

- Go to Goods Receipt window, create record for Be Soft Drinker, set movement date: today
- select the order line created before and process it

- Go to Purchase order, create a new one for Be Soft Drinker
- In Lines tab, add test 29891 product, set Qty: 100, process order

Go to Goods Receipt window, create record for Be Soft Drinker, set movement date: three weeks ago
- select the order line created before and process it

- Go to Costing rule window, for record with F&B US Inc Organization, Process Fix Backdated Transactions: date: 1 month ago

- Go to Process request and launch the costing background process
- Go to the Costing tab of the product: test 29891 product, sort records order by ending date
- Realise that the first line is: qty:100, second line qty:200, third line qty:380 and the total movement qty is empty for all three lines as there exists a adjustment entry of type backdated transaction.

- For costing line, check below tab Average Cost Transactions.
  - For three weeks ago goods receipt line Cumulative Qty = 100
  - For two weeks ago goods receipt line Cumulative Qty = 300
  - For three weeks ago goods receipt line Cumulative Qty = 680

- Add goods receipt for above product with Qty = 250 and process it.
- Launch costing background process.
- Check that costing line for fourth goods receipt has information as below

  Qty: 250
  Total Movement Qty: 930 (680 previous + 250 current)
  Total Stock Valuation: 1860

  This is correct.