Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036830Retail ModulesWeb POSpublic2017-09-11 18:362017-09-20 12:22
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036830: The deletedLines array is copied from to the ticket when creating an order from a quotation
DescriptionWhen the Web POS Save Removed Tickets preference is configured, all deleted lines are stored in a deletedLines array.
When a quotation is loaded from backend into web pos and it is reactivated, it is possible to add or remove lines.
If a line is removed, then the quotation is confirmed (by clicking on the Total Amount button) and then (without removing it) it is converted into a sales order (Menu entry "Create sales order"), the array of deletedLines remains on the ticket.
If the ticket is synchronized to the server, the process will fail because the deletedLines already exist in the database.
Steps To ReproduceLogin in backend and configure the "Web POS Save Removed Tickets" preference.
Login in web pos.
Load a quotation.
Reactivate the quotation.
Remove a line.
Complete the quotation.
Convert the sales order in a quotation.
Try to pay the ticket.
Verify that the ticket won't be synchronized and the record will appear on the "Errors while importing POS data" window.

Proposed SolutionWhen the sales order is created from a quotation, the array of deleted lines should be reset/removed.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-11 18:36aaroncaleroNew Issue
2017-09-11 18:36aaroncaleroAssigned To => Retail
2017-09-11 18:36aaroncaleroResolution time => 1506290400
2017-09-11 18:36aaroncaleroTriggers an Emergency Pack => No
2017-09-12 09:43ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-09-12 09:44ranjith_qualiantech_comStatusnew => scheduled
2017-09-12 13:58hgbotCheckin
2017-09-12 13:58hgbotNote Added: 0098984
2017-09-12 13:58hgbotStatusscheduled => resolved
2017-09-12 13:58hgbotResolutionopen => fixed
2017-09-12 13:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e639e379539df30a7e318d906dbcd5ac194b488 [^]
2017-09-13 11:13ranjith_qualiantech_comNote Added: 0099010
2017-09-13 11:13ranjith_qualiantech_comStatusresolved => new
2017-09-13 11:13ranjith_qualiantech_comResolutionfixed => open
2017-09-13 11:13ranjith_qualiantech_comStatusnew => scheduled
2017-09-14 09:22hgbotCheckin
2017-09-14 09:22hgbotNote Added: 0099023
2017-09-14 09:22ranjith_qualiantech_comStatusscheduled => resolved
2017-09-14 09:22ranjith_qualiantech_comResolutionopen => fixed
2017-09-14 14:43migueldejuanaNote Added: 0099048
2017-09-14 14:43migueldejuanaStatusresolved => new
2017-09-14 14:43migueldejuanaResolutionfixed => open
2017-09-19 08:33ranjith_qualiantech_comStatusnew => scheduled
2017-09-19 08:34ranjith_qualiantech_comNote Added: 0099134
2017-09-19 08:34ranjith_qualiantech_comStatusscheduled => resolved
2017-09-19 08:34ranjith_qualiantech_comResolutionopen => fixed
2017-09-20 12:21marvintmReview Assigned To => marvintm
2017-09-20 12:21marvintmStatusresolved => closed
2017-09-20 12:22marvintmFixed in Version => RR17Q4

Notes
(0098984)
hgbot   
2017-09-12 13:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1e639e379539df30a7e318d906dbcd5ac194b488
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Sep 12 17:27:27 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e639e379539df30a7e318d906dbcd5ac194b488 [^]

Fixed issue 36830 : Reset deletedLines when order is created from quotations

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0099010)
ranjith_qualiantech_com   
2017-09-13 11:13   
Test must be added
(0099023)
hgbot   
2017-09-14 09:22   
Repository: tools/automation/pi-mobile
Changeset: 58788a3d5a65f5188f031a8427ff539b81aa6697
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Sep 14 12:51:57 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/58788a3d5a65f5188f031a8427ff539b81aa6697 [^]

Verifies issue 36830 : Added automated test 'I36830_VerifyOrderFromQuotations'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36830_VerifyOrderFromQuotations.java
---
(0099048)
migueldejuana   
2017-09-14 14:43   
Failing in Quarantine:

https://ci.openbravo.com/view/retail-qa/job/ret-qa-modules-pgsql-suite2/637/ [^]
(0099134)
ranjith_qualiantech_com   
2017-09-19 08:34   
Test failed in quarantine is due to another issue https://issues.openbravo.com/view.php?id=36801. [^] So issue changed to resolved