Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036818Openbravo ERPA. Platformpublic2017-09-09 11:072017-09-12 11:01
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036818: Big code-cleanup in src-wad related to "2.50 code removal" done earlier in 17Q2
DescriptionIssue 34214 done for 17Q2 release removed support for compiling 2.50 style windows and lots of support code inside the WAD code-generator.

However a lot more code in src-wad is effectively dead and unused since that earlier change but not yet removed.

Also the various subclasses implementing WADControl (implementation for the various possible GUI elements) still carry quite some code which is also no longer useful (only related to 2.50).

That is also cleanup up in this issue
Steps To Reproduce-
Proposed SolutionCleanup src-wad code generator to remove all the unused code.
Cleanup all implementation of WADControl + sub-classes to also remove lots of no longer required generation code
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036819 closed shuehner api-change related to src-wad 2.50 unused code-removal 
related to feature request 00342143.0PR17Q2 closed alostale remove 2.50 support 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-09 11:07shuehnerNew Issue
2017-09-09 11:07shuehnerAssigned To => shuehner
2017-09-09 11:07shuehnerModules => Core
2017-09-09 11:07shuehnerTriggers an Emergency Pack => No
2017-09-09 11:07shuehnerRelationship addedrelated to 0034214
2017-09-09 11:37shuehnerRelationship addedrelated to 0036819
2017-09-09 11:38shuehnerReview Assigned To => alostale
2017-09-09 16:14hgbotCheckin
2017-09-09 16:14hgbotNote Added: 0098923
2017-09-09 16:14hgbotStatusnew => resolved
2017-09-09 16:14hgbotResolutionopen => fixed
2017-09-09 16:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/788d0f44f3ffc96da2516c11a69966361aec7083 [^]
2017-09-12 11:01alostaleNote Added: 0098976
2017-09-12 11:01alostaleStatusresolved => closed
2017-09-12 11:01alostaleFixed in Version => 3.0PR17Q4

Notes
(0098923)
hgbot   
2017-09-09 16:14   
Repository: erp/devel/pi
Changeset: 788d0f44f3ffc96da2516c11a69966361aec7083
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Sep 09 11:09:06 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/788d0f44f3ffc96da2516c11a69966361aec7083 [^]

Fixed 36818. Merge back project doing a lot more src-wad unused code removal.

This merges back the pi-wad-cleanup2 branch doing follow up cleanup for 17q2
change which removed support to compile old style 2.50 windows.

---
M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.xml
M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorData.xsql
M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorPrimitive.java
M src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.xml
M src-wad/src/org/openbravo/wad/ActionButton_Responser.xml
M src-wad/src/org/openbravo/wad/ComboReloadsProcess.xml
M src-wad/src/org/openbravo/wad/ComboReloadsProcessHelper.xml
M src-wad/src/org/openbravo/wad/Fields_data.xsql
M src-wad/src/org/openbravo/wad/Tabs_data.xsql
M src-wad/src/org/openbravo/wad/Template_ActionButton.xml
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/WadActionButton.java
M src-wad/src/org/openbravo/wad/WadUtility.java
M src-wad/src/org/openbravo/wad/controls/WADButton.java
M src-wad/src/org/openbravo/wad/controls/WADControl.java
M src-wad/src/org/openbravo/wad/controls/WADDate.java
M src-wad/src/org/openbravo/wad/controls/WADDateTime.java
M src-wad/src/org/openbravo/wad/controls/WADDateXML.xml
M src-wad/src/org/openbravo/wad/controls/WADID.java
M src-wad/src/org/openbravo/wad/controls/WADImage.java
M src-wad/src/org/openbravo/wad/controls/WADImageBLOB.java
M src-wad/src/org/openbravo/wad/controls/WADInteger.java
M src-wad/src/org/openbravo/wad/controls/WADLink.java
M src-wad/src/org/openbravo/wad/controls/WADList.java
M src-wad/src/org/openbravo/wad/controls/WADMemo.java
M src-wad/src/org/openbravo/wad/controls/WADNumber.java
M src-wad/src/org/openbravo/wad/controls/WADSearch.java
M src-wad/src/org/openbravo/wad/controls/WADSearch_data.xsql
M src-wad/src/org/openbravo/wad/controls/WADString.java
M src-wad/src/org/openbravo/wad/controls/WADTable.java
M src-wad/src/org/openbravo/wad/controls/WADTableDir.java
M src-wad/src/org/openbravo/wad/controls/WADText.java
M src-wad/src/org/openbravo/wad/controls/WADTime.java
M src-wad/src/org/openbravo/wad/controls/WADYesNo.java
M src-wad/src/org/openbravo/wad/javasource.xml
M src-wad/src/org/openbravo/wad/webConf.xml
M src-wad/src/org/openbravo/wad/webParams.xml
M src/org/openbravo/erpCommon/businessUtility/AuditTrailPopup_data.xsql
R src-wad/src/org/openbravo/wad/EditionFields_data.xsql
R src-wad/src/org/openbravo/wad/TableRelation_data.xsql
R src-wad/src/org/openbravo/wad/controls/WADTable_data.xsql
---
(0098976)
alostale   
2017-09-12 11:01   
reviewed

tested there is no change in WAD generated code