Openbravo Issue Tracking System - Retail Modules
View Issue Details
0036817Retail ModulesWeb POSpublic2017-09-08 19:382017-09-27 16:52
dbaz 
ranjith_qualiantech_com 
normalminoralways
closedfixed 
5
 
RR17Q4 
marvintm
No
0036817: [UX] Approval popup is hidden when an error happens
There could be several situations where an error can happen while trying to introduce the approval credentials:
* Bad password
* Empty password
* Not allowed user

In all of these cases, the approval popup gets closed once the error message it is shown.

It is a pain, since the user should again do all the required actions to invoke this popup to introduce proper credentials.

Also, the error message, instead of be shown as a warning or error in the top-right corner, it should be shown within the same popup in order to improve its usability. NOTE: If there is any kind of these errors, both inputs (username and password) must be erased, and the focus should be set in the 'username' input.
Create an approval (for example 'WebPOS Cash up window') and once it be shown, try to enter:
* Bad password
* Empty password
* Not allowed user
The popup should remain visible to allow the user enter new credentials.

I attach some mockups of the styling that the errors should have.
No tags attached.
related to design defect 0036816 closed Retail [UX] In case of error in Approval, it should display a Popup instead of the top-right error message 
png ApprovalError_01.png (74,734) 2017-09-13 20:15
https://issues.openbravo.com/file_download.php?file_id=11060&type=bug
png

png ApprovalError_02.png (71,771) 2017-09-13 20:16
https://issues.openbravo.com/file_download.php?file_id=11061&type=bug
png

png ApprovalError_03.png (73,223) 2017-09-13 20:16
https://issues.openbravo.com/file_download.php?file_id=11062&type=bug
png
Issue History
2017-09-08 19:38dbazNew Issue
2017-09-08 19:38dbazAssigned To => Retail
2017-09-08 19:38dbazTriggers an Emergency Pack => No
2017-09-08 19:38dbazRelationship addedrelated to 0036816
2017-09-13 20:15dbazDescription Updatedbug_revision_view_page.php?rev_id=15894#r15894
2017-09-13 20:15dbazProposed Solution updated
2017-09-13 20:16dbazFile Added: ApprovalError_01.png
2017-09-13 20:16dbazFile Added: ApprovalError_02.png
2017-09-13 20:16dbazFile Added: ApprovalError_03.png
2017-09-14 12:53ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-09-14 12:53ranjith_qualiantech_comStatusnew => scheduled
2017-09-20 08:05hgbotCheckin
2017-09-20 08:05hgbotNote Added: 0099156
2017-09-20 08:06hgbotCheckin
2017-09-20 08:06hgbotNote Added: 0099158
2017-09-20 08:06hgbotStatusscheduled => resolved
2017-09-20 08:06hgbotResolutionopen => fixed
2017-09-20 08:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8def4fd328e0cfbce04417bc3e6a21ce7f3ef2ea [^]
2017-09-27 16:51hgbotCheckin
2017-09-27 16:51hgbotNote Added: 0099635
2017-09-27 16:52hgbotCheckin
2017-09-27 16:52hgbotNote Added: 0099636
2017-09-27 16:52marvintmReview Assigned To => marvintm
2017-09-27 16:52marvintmStatusresolved => closed
2017-09-27 16:52marvintmFixed in Version => RR17Q4

Notes
(0099156)
hgbot   
2017-09-20 08:05   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 57ba410945404d14852eb358e0b47042833e58b6
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Sep 20 11:16:07 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/57ba410945404d14852eb358e0b47042833e58b6 [^]

Related to issue 36817 : Changes in Approval Credential Validations

* If the approval is failed, error should be shown in approval popup itself instead of closing it

---
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
---
(0099158)
hgbot   
2017-09-20 08:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8def4fd328e0cfbce04417bc3e6a21ce7f3ef2ea
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Sep 20 11:16:05 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8def4fd328e0cfbce04417bc3e6a21ce7f3ef2ea [^]

Fixed issue 36817 : Changes in CheckApproval Validations

* If the approval is failed, error should be shown in approval popup itself

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/utility/CheckApproval.java
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0099635)
hgbot   
2017-09-27 16:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 88b6c1b37855106774563df54d3e62ed5a7ca476
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 27 16:33:41 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88b6c1b37855106774563df54d3e62ed5a7ca476 [^]

Related to issue 36817. Removed wrong commented lines.

---
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0099636)
hgbot   
2017-09-27 16:52   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2aa966d2876cb5b58846390fcb0389ae1815c4cd
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 27 16:34:30 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2aa966d2876cb5b58846390fcb0389ae1815c4cd [^]

Related to issue 36817. Removed wrong commented lines.

---
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
---