Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036794Openbravo ERP07. Sales managementpublic2017-09-04 11:492017-09-05 18:16
Reporterngarcia 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q2.3Fixed in Version3.0PR17Q2.3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket48145
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036794: Amounts in Invoice lines and taxes are rounded to price precision instead of standard precision in Create Lines From process
DescriptionAmounts in Invoice lines and taxes are rounded to price precision instead of standard precision in Create Lines From process

In CreateFrom class, the price precision is used for rounding amounts instead of standard precision
Steps To ReproduceChange the Format.xml to accept 3 decimals in prices

As System Admin role:
   Set Price Precision of EUR currency to 3

   Create a new sales price list, do not set it as Price Includes Tax
   Add 4 products to it with the following prices:
      101.15
      176.715
      8.33
      35.105

   Create a Sales Order
   Set the previously created price list
   Add the previously created 5 products (one unit of each, 2 units of the one with 101.15 price)
   Complete it
   Set its Invoice Terms as Immediate

   Create a Sales Invoice header
   Set the previously created price list
   Click on Create Lines From
   Add the 4 lines of the sales order with a price different from 0

   Check the total net amount (422.45) does not match with the sum of the Line Net Amount values in invoice lines (202.30 + 176.72 + 8.33 + 35.11 = 422.46)
      
   Check through database that the linenetamt is not rounded to standard precision but to priceprecision
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0036776 closed markmm82 Amounts in Invoice lines and taxes are rounded to price precision instead of standard precision in Create Lines From process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-05 16:41aferrazTypedefect => backport
2017-09-05 16:41aferrazTarget Version => 3.0PR17Q2.3
2017-09-05 18:15hgbotCheckin
2017-09-05 18:15hgbotNote Added: 0098846
2017-09-05 18:15hgbotStatusscheduled => resolved
2017-09-05 18:15hgbotResolutionopen => fixed
2017-09-05 18:15hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ef2a84e698c4c76bef4f8ef984d4055c64b6d862 [^] => http://code.openbravo.com/erp/backports/3.0PR17Q2.3/rev/6b3122e0ae4fbb7f9e11f038db9b821cc85199f2 [^]
2017-09-05 18:15hgbotCheckin
2017-09-05 18:15hgbotNote Added: 0098847
2017-09-05 18:16aferrazReview Assigned To => aferraz
2017-09-05 18:16aferrazNote Added: 0098849
2017-09-05 18:16aferrazStatusresolved => closed
2017-09-05 18:16aferrazFixed in Version => 3.0PR17Q2.3

Notes
(0098846)
hgbot   
2017-09-05 18:15   
Repository: erp/backports/3.0PR17Q2.3
Changeset: 6b3122e0ae4fbb7f9e11f038db9b821cc85199f2
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Sep 04 12:44:00 2017 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR17Q2.3/rev/6b3122e0ae4fbb7f9e11f038db9b821cc85199f2 [^]

Fixes issue 36794: Amounts in invoice lines and taxes rounded to price precision
instead of standard precision in Create Lines From process.

In CreateFrom class, the price precision was used for rounding amounts instead of
standard precision and it was causing differences with totals when invoices were
created from orders or shipments.

Now all prices are rounded with the price precision of it currency and amounts
with standard precision.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0098847)
hgbot   
2017-09-05 18:15   
Repository: erp/backports/3.0PR17Q2.3
Changeset: 7c9f843207d83c6adecaff966ead8bb8d88fb4b1
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 05 12:37:04 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q2.3/rev/7c9f843207d83c6adecaff966ead8bb8d88fb4b1 [^]

Related to issue 36794: Code review improvements

Retrieve currency standard precision instead of price precision in selectFromPO, selectFromPOUpdate, selectFromPOUpdateSOTrx and selectPriceList methods.
Do not round price actual with price precision when calculating line net amount.
Remove unused priceprecision variable.
Use data variable to retrieve currency standard precision when creating invoice from order and dataAux variable when creating invoice from receipt/shipment.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0098849)
aferraz   
2017-09-05 18:16   
Code review + Testing OK