Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036778Openbravo ERP02. Master data managementpublic2017-09-04 12:372018-01-03 12:39
ReporterJONHM 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket48267
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036778: Wrong message shown in 'Update Characteristics' process when it has +200 lines
DescriptionWhen having +200 values defined for any product characteristic and the TreeDatasourceFetchLimit[1] preference with its default value (200), the selector of 'Update Characteristics' process of "Product" window does not show a correct message.

[1] http://wiki.openbravo.com/wiki/How_to_Create_a_Custom_Tree#fetchNodeChildren [^]
Steps To Reproduce- Login as 'F&B International Group Admin'
1) Open 'Product Characteristics' window and create a new record
  name: 'TEST'
  variant: NO
2) Switch to [Value] tab and create a new record
3) Run the attached script in database. It will create 200 more lines
4) Open 'Product' window and select some record having column 'Is Generic' set as NO
5) Switch to [Characteristics] tab and create a new record for the previously created characteristic
6) Press button "Update Characteristics" and open the picklist.

--> The following message is returned: "No items to show". A more informative message should be displayed instead, in order to inform user that the maximum number of tree nodes has been reached.
Proposed SolutionThe server is already responding with an error message[1] when the maximum node limit is reached. This response should be handled properly and display the correct message in that case.

[1] https://code.openbravo.com/erp/devel/pi/file/2873be0d1b66/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java#l293 [^]
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037398 closed jarmendariz No warning message shown in 'Update Characteristics' process when 'TreeDatasourceFetchLimit' preference is not defined 
Attached Files? ch_createlines.sql (747) 2017-09-04 12:37
https://issues.openbravo.com/file_download.php?file_id=11033&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-09-04 12:37JONHMNew Issue
2017-09-04 12:37JONHMAssigned To => platform
2017-09-04 12:37JONHMFile Added: ch_createlines.sql
2017-09-04 12:37JONHMOBNetwork customer => Yes
2017-09-04 12:37JONHMModules => Core
2017-09-04 12:37JONHMSupport ticket => 48267
2017-09-04 12:37JONHMResolution time => 1506290400
2017-09-04 12:37JONHMTriggers an Emergency Pack => No
2017-09-04 18:56caristuAssigned Toplatform => Triage Finance
2017-09-04 18:56caristuCategoryA. Platform => 02. Master data management
2017-09-04 18:56caristuSummaryCharacteristic values are not shown in 'Update Characteristics' process when it has +200 lines => Wrong message shown in 'Update Characteristics' process when it has +200 lines
2017-09-04 18:56caristuDescription Updatedbug_revision_view_page.php?rev_id=15798#r15798
2017-09-04 18:56caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15800#r15800
2017-09-04 18:56caristuDescription Updatedbug_revision_view_page.php?rev_id=15801#r15801
2017-09-04 19:00caristuDescription Updatedbug_revision_view_page.php?rev_id=15802#r15802
2017-09-05 08:26caristuProposed Solution updated
2017-09-05 09:39caristuProposed Solution updated
2017-09-05 09:53JONHMResolution time1506290400 =>
2017-09-05 09:53JONHMPriorityhigh => normal
2017-09-05 09:53JONHMSeveritymajor => minor
2017-09-05 09:54aferrazAssigned ToTriage Finance => AtulOpenbravo
2017-10-12 15:21AtulOpenbravoStatusnew => scheduled
2017-11-14 16:54dmiguelezAssigned ToAtulOpenbravo => platform
2017-11-17 13:29caristuAssigned Toplatform => caristu
2017-11-20 13:35hgbotCheckin
2017-11-20 13:35hgbotNote Added: 0100622
2017-11-21 16:38hgbotCheckin
2017-11-21 16:38hgbotNote Added: 0100655
2017-11-21 16:38hgbotCheckin
2017-11-21 16:38hgbotNote Added: 0100656
2017-11-21 16:38hgbotStatusscheduled => resolved
2017-11-21 16:38hgbotResolutionopen => fixed
2017-11-21 16:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2a22d8f5a9dbf30a653853165dff3e94329086c5 [^]
2017-11-21 16:40caristuReview Assigned To => alostale
2017-11-27 10:58alostaleNote Added: 0100731
2017-11-27 10:58alostaleStatusresolved => closed
2017-11-27 10:58alostaleFixed in Version => 3.0PR18Q1
2017-11-27 17:21JONHMRelationship addedrelated to 0037398
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101440
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101448
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101449

Notes
(0100622)
hgbot   
2017-11-20 13:35   
Repository: erp/devel/pi
Changeset: e9a105538e891e431405a1baad518cc680e4833a
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Nov 20 13:35:24 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e9a105538e891e431405a1baad518cc680e4833a [^]

related to issue 36778: fix jslint error by adding missing semicolon

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0100655)
hgbot   
2017-11-21 16:38   
Repository: erp/devel/pi
Changeset: c066615ff473c62ad9ec33ef9aa6c5539c9dce8b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Nov 21 16:21:53 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c066615ff473c62ad9ec33ef9aa6c5539c9dce8b [^]

related to issue 36778: Clean up unused variables

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0100656)
hgbot   
2017-11-21 16:38   
Repository: erp/devel/pi
Changeset: 2a22d8f5a9dbf30a653853165dff3e94329086c5
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Nov 21 13:43:40 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2a22d8f5a9dbf30a653853165dff3e94329086c5 [^]

fixes bug 36778: Wrong message shown in tree selector when reaching fetch limit

  Added the ability to show an error message in the drop-down of an tree form item when the request fetches a number of nodes higher than the established limit.

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-grid-styles.css
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-grid-styles.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-tree-grid-styles.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0100731)
alostale   
2017-11-27 10:58   
reviewed + tested
(0101440)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101448)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101449)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test