Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036765Openbravo ERPA. Platformpublic2017-09-01 12:482017-09-13 08:12
Reporterngarcia 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q3Fixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-04-18
Regression introduced in release3.0PR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
Triggers an Emergency PackNo
Summary0036765: Update information of attachments is not changed after replacing an already attached file
DescriptionUpdate information of attachments is not changed after replacing an already attached file.

It seems the updated column of the c_file table is not updated when a file is replaced
Steps To ReproduceAs group admin role:
   Go to Sales Invoice window
   Add an attachment to it
   Wait at least a minute in order to see its update information as '1 minutes ago by ...'
   Modify the file
   Add it again to the same invoice
   The applications shows:
   "The file you are trying to upload already exists, so it will be replaced by the new one. Are you sure you want to continue?"
   Select OK

   Check the update information remains the same. It should be updated to '0 minutes ago by ...'
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0036763 closed caristu Update information of attachments is not changed after replacing an already attached file 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-01 14:49caristuTypedefect => backport
2017-09-01 14:49caristuTarget Version => 3.0PR17Q3
2017-09-04 10:23hgbotCheckin
2017-09-04 10:23hgbotNote Added: 0098796
2017-09-04 10:23hgbotStatusscheduled => resolved
2017-09-04 10:23hgbotResolutionopen => fixed
2017-09-04 10:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q3/rev/fbbdcccd32726e3e543f49fbd499add64d325b62 [^]
2017-09-04 10:24caristuReview Assigned To => alostale
2017-09-11 12:09hgbotCheckin
2017-09-11 12:09hgbotNote Added: 0098936
2017-09-12 15:51hgbotCheckin
2017-09-12 15:51hgbotNote Added: 0098986
2017-09-13 08:12alostaleNote Added: 0099000
2017-09-13 08:12alostaleStatusresolved => closed
2017-09-13 08:12alostaleFixed in Version => 3.0PR17Q3

Notes
(0098796)
hgbot   
2017-09-04 10:23   
Repository: erp/backports/3.0PR17Q3
Changeset: fbbdcccd32726e3e543f49fbd499add64d325b62
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Sep 04 09:23:10 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q3/rev/fbbdcccd32726e3e543f49fbd499add64d325b62 [^]

fixes bug 36765: Audit info not updated when replacing an already attached file

  The audit information (updated, updated by fields) of the attachments was not being updated after replacing an already attached file. In this case the OBInterceptor was not being invoked because the information of the attachment (BaseOBObject) was indeed not changing.

  To fix this problem we explicitly change the 'updated' date of the attachment and the OBInterceptor will take care of update the rest of the audit information (updated by).

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
---
(0098936)
hgbot   
2017-09-11 12:09   
Repository: erp/backports/3.0PR17Q3
Changeset: fd71055b3e971fc99e25640d15738c3c6d439d6a
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Sep 11 12:05:17 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q3/rev/fd71055b3e971fc99e25640d15738c3c6d439d6a [^]

related to bug 36765: Update attachment last update when metadata also changes

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java
---
(0098986)
hgbot   
2017-09-12 15:51   
Repository: erp/backports/3.0PR17Q3
Changeset: 5a80fe33e7c125e71235fb0f255ca989ba2c8dd9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Sep 12 15:50:45 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q3/rev/5a80fe33e7c125e71235fb0f255ca989ba2c8dd9 [^]

related to bug 36765: last update not updated when removing description

  The last updated information is now updated when the description of an existing attachment is cleared. This was not happening before, because the record in the OBUIAPP_Parameter_Value table was removed when the value to be assigned is null

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
---
(0099000)
alostale   
2017-09-13 08:12   
reviewed

tested cases:

1. replaced file with same name
2. edited description
3. having a description, it gets removed
4. adding modifications in an extra parameter in attachment method