Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036737Openbravo ERPA. Platformpublic2017-08-28 14:552017-08-30 10:35
ReporterJONHM 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q3Fixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-06-21
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/bdca94625dbf67b7e9dbf54f7535f6f22b499b14 [^]
Triggers an Emergency PackNo
Summary0036737: Error displaying in selector picklist a field based in a non-primitive derived property
DescriptionAn error is thrown when using a selector that is configured to display a field in the picklist which is based in a non-primitive derived property, i.e., a property resolved through property navigation which points to a reference.
Steps To Reproduce- As System Administrator
1) Open window "Reference" and select 'Product (by Price and Warehouse)'
2) Switch to [Defined Selector] tab and then to [Defined Selector Field] subtab
3) Create a new record:
  Name: Product2
  Property: productPrice.product
  Show in picklist: YES

- As F&B International Group Admin
4) Open "Sales Order" window and create a new record from 'Alimentos y Supermercados, S.A' bussiness partner
5) Create a new line and open the 'Product' selector picklist

--> It shows the following error in the log:
ERROR org.openbravo.service.json.DefaultJsonDataService - java.lang.NullPointerException
    at org.openbravo.service.json.DataToJsonConverter.toJsonObject(DataToJsonConverter.java:219)
    at org.openbravo.service.json.DataToJsonConverter.toJsonObjects(DataToJsonConverter.java:144)
    at org.openbravo.service.json.DefaultJsonDataService.fetch(DefaultJsonDataService.java:301)
    at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:85)
    at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:78)
    at org.openbravo.service.datasource.DataSourceServlet.doFetch(DataSourceServlet.java:285)
    at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:843)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:650)
        ...

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0036728 closed caristu Error displaying in selector picklist a field based in a non-primitive derived property 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-08-29 12:38caristuTypedefect => backport
2017-08-29 12:38caristuTarget Version => 3.0PR17Q3
2017-08-29 13:31hgbotCheckin
2017-08-29 13:31hgbotNote Added: 0098699
2017-08-29 13:31hgbotStatusscheduled => resolved
2017-08-29 13:31hgbotResolutionopen => fixed
2017-08-29 13:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q3/rev/06c655f757ead59678a6742916542c7145233045 [^]
2017-08-29 13:32caristuSummaryError displaying in selector picklist a field based a non-primitive derived property => Error displaying in selector picklist a field based on a non-primitive derived property
2017-08-29 13:32caristuSummaryError displaying in selector picklist a field based on a non-primitive derived property => Error displaying in selector picklist a field based in a non-primitive derived property
2017-08-29 13:32caristuReview Assigned To => alostale
2017-08-29 13:51caristuRegression level => Production - Confirmed Stable
2017-08-29 14:36caristuDescription Updatedbug_revision_view_page.php?rev_id=15741#r15741
2017-08-29 14:36caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15743#r15743
2017-08-30 10:35alostaleNote Added: 0098725
2017-08-30 10:35alostaleStatusresolved => closed
2017-08-30 10:35alostaleFixed in Version => 3.0PR17Q3

Notes
(0098699)
hgbot   
2017-08-29 13:31   
Repository: erp/backports/3.0PR17Q3
Changeset: 06c655f757ead59678a6742916542c7145233045
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Aug 29 13:25:09 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q3/rev/06c655f757ead59678a6742916542c7145233045 [^]

fixes bug 36737: Can't use fields based on some properties in selector picklist

With the fix for issue 0036268 the selector fields based on derived properties that are shown in the picklist are sent as 'extra properties' in order to calculate them properly.

The problem is that the fix was not complete when the derived properties were not primitive. In that case the DataToJsonConverter class was not calculating properly the referenced property.

Now that kind of properties are calculated properly.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
---
(0098725)
alostale   
2017-08-30 10:35   
reviewed + tested