Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036735Openbravo ERPA. Platformpublic2017-08-29 09:002017-08-29 09:05
shuehner 
shuehner 
normalminorhave not tried
closedfixed 
5
 
3.0PR17Q4 
alostale
Core
No
0036735: Remove non-working and no longer used modules/org.openbravo.client.kernel/build.xml (related to jslint)
That small ant build file was created a long time ago to check the application-js.ftl freemarker template which is used at runtime to generate the main application js file.

However:
- the build-file was never update after that ftl file was renamed in 2010
- the ftl file itself is no valid javascript so will not pass jslint
- the generated javascript output will be validated by jslint if the module is indevelopment covering the application-js.ftl content also

As result that build.xml file is no longer useful and should be removed
-
No tags attached.
Issue History
2017-08-29 09:00shuehnerNew Issue
2017-08-29 09:00shuehnerAssigned To => shuehner
2017-08-29 09:00shuehnerModules => Core
2017-08-29 09:00shuehnerTriggers an Emergency Pack => No
2017-08-29 09:03hgbotCheckin
2017-08-29 09:03hgbotNote Added: 0098682
2017-08-29 09:03hgbotStatusnew => resolved
2017-08-29 09:03hgbotResolutionopen => fixed
2017-08-29 09:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7d3ebe1b52c6aca979c774c3c42dcc3d6bae7966 [^]
2017-08-29 09:03shuehnerReview Assigned To => alostale
2017-08-29 09:05alostaleNote Added: 0098683
2017-08-29 09:05alostaleStatusresolved => closed
2017-08-29 09:05alostaleFixed in Version => 3.0PR17Q4

Notes
(0098682)
hgbot   
2017-08-29 09:03   
Repository: erp/devel/pi
Changeset: 7d3ebe1b52c6aca979c774c3c42dcc3d6bae7966
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Aug 29 09:02:20 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7d3ebe1b52c6aca979c774c3c42dcc3d6bae7966 [^]

Fixed 36735. Remove obsolete jslint related build.xml file.

That file only checks a now non-existent ftl template.
The content of that template will be indirectly checked anyway by the jslint
run done on generated js when modules are in development.

---
R modules/org.openbravo.client.kernel/build.xml
---
(0098683)
alostale   
2017-08-29 09:05   
reviewed