Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036720Retail ModulesWeb POSpublic2017-08-25 11:042017-10-02 14:06
Reporterguilleaer 
Assigned Toguilleaer 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q4Fixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036720: Queries used by profile Popup in (profileUtils.java [mobileCore]) have a behavior which is specific for webPOS
DescriptionQueries used by profile Popup in (profileUtils.java [mobileCore]) have a behavior which is specific for webPOS

in general values retrieved should be the same retrieved by ERP profile widget

getRoles: It is filtering for roles defined in the same organization. This is not a standard behavior but make sense for web POS.

getWarehouses: It is filtering for the warehouses defined as orgWarehouses. This is not a standard behavior but make sense for web POS.
Steps To ReproduceN/A
Proposed SolutionA new class should be defined in web POS to implement these customizations. In the terminal definition, this class should be specified (like we do with loginUtils)

Queries in mobile core should be changed to match with ERP behavior
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036715RR17Q4 closed guilleaer Profile PopUp does not load orgs and warehouses values (if they are shown) when popup is opened. Just works when role is changed 
Attached Filesdiff diffIssue36720_pt.diff (15,575) 2017-09-27 13:43
https://issues.openbravo.com/file_download.php?file_id=11108&type=bug
diff diffIssue36720_mc.diff (4,295) 2017-09-27 13:43
https://issues.openbravo.com/file_download.php?file_id=11109&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-08-25 11:04guilleaerNew Issue
2017-08-25 11:04guilleaerAssigned To => Retail
2017-08-25 11:04guilleaerOBNetwork customer => No
2017-08-25 11:04guilleaerTriggers an Emergency Pack => No
2017-08-25 11:04guilleaerFile Added: 36720.diff
2017-08-25 11:05guilleaerRelationship addedrelated to 0036715
2017-09-27 13:43guilleaerFile Added: diffIssue36720_pt.diff
2017-09-27 13:43guilleaerFile Added: diffIssue36720_mc.diff
2017-09-27 13:43guilleaerFile Deleted: 36720.diff
2017-09-27 13:43guilleaerDescription Updatedbug_revision_view_page.php?rev_id=16003#r16003
2017-09-27 13:43guilleaerAssigned ToRetail => guilleaer
2017-09-27 13:43guilleaerStatusnew => scheduled
2017-09-28 14:35hgbotCheckin
2017-09-28 14:35hgbotNote Added: 0099654
2017-09-28 14:35hgbotStatusscheduled => resolved
2017-09-28 14:35hgbotResolutionopen => fixed
2017-09-28 14:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1b679e3457a99867a40496ec4f034b17c9e8ccfa [^]
2017-09-28 14:35hgbotCheckin
2017-09-28 14:35hgbotNote Added: 0099655
2017-09-28 14:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1b679e3457a99867a40496ec4f034b17c9e8ccfa [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e73374b406ed5efbf5bec928d72afd9bcafcc16 [^]
2017-09-28 18:12marvintmReview Assigned To => marvintm
2017-09-28 18:12marvintmStatusresolved => closed
2017-09-28 18:12marvintmFixed in Version => RR17Q4
2017-10-02 14:06hgbotCheckin
2017-10-02 14:06hgbotNote Added: 0099693

Notes
(0099654)
hgbot   
2017-09-28 14:35   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1b679e3457a99867a40496ec4f034b17c9e8ccfa
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Sep 28 14:17:20 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1b679e3457a99867a40496ec4f034b17c9e8ccfa [^]

Fixed issue 36720: Queries implemented in mobile core profile servlets are equals to ERP

---
M src/org/openbravo/mobile/core/login/ProfileUtils.java
---
(0099655)
hgbot   
2017-09-28 14:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3e73374b406ed5efbf5bec928d72afd9bcafcc16
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Sep 28 14:15:39 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e73374b406ed5efbf5bec928d72afd9bcafcc16 [^]

Fixed issue 36720: Web POS will use his own profile handler. Mobile core will work like ERP

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/posterminal/ProfileUtilsServlet.java
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0099693)
hgbot   
2017-10-02 14:06   
Repository: retail/api-checks-retail
Changeset: 59a53e797f4b641617cf73e9d80ce757df5bb4fa
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Oct 02 13:49:08 2017 +0200
URL: http://code.openbravo.com/retail/api-checks-retail/rev/59a53e797f4b641617cf73e9d80ce757df5bb4fa [^]

Fixed issue 36983, Related to issue 36720. ProfileUtilsServlet API changed. Now it is not a servlet

ProfileUtilsServlet will no longer be a servlet. Now it extends ProfileUtils.java which is implemented in mobile core. This class now will overwrite those methods which are specific of web POS but will reuse the rest of the logic implemente in the parent class.

---
M java/reference/java.japi.gz
M model/modules/org.openbravo.retail.posterminal/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/modules/org.openbravo.retail.posterminal/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---