Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036708Openbravo ERPA. Platformpublic2017-08-23 18:522017-09-21 16:49
Reporterdbaz 
Assigned Todbaz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036708: CSSMinimizer does not work well with "transform-origin" property
DescriptionCSSMinimizer does not work well with "transform-origin" property

This property can have up three arguments (one per axis)
https://www.w3schools.com/cssref/css3_pr_transform-origin.asp [^]

The default value is "50% 50% 0". CSSMinimizer has a feature to remove duplicated parameters if exist. This works ok with most of the properties, e.g. "margin", where "100% 100%" or "100% 100% 100% 100%" can be simplified to just "100%", but in the case of "transform-origin", having only one parameter does not assume that the remaining ones have the same value, so this simplification cannot be performed, and all the parameters should be declared in a explicit way (otherwise, the missing one will adopt the default value).

This issue has been reported to the owner of the CSSMin library: https://github.com/barryvan/CSSMin/issues/21 [^]
Steps To ReproduceInclude in any CSS loaded within the application.
transform-origin: 100% 100%;

With the modules NOT in development, notice that the compressed CSS has only "transform-origin: 100%;". (As explained before, this simplification is equivalent to "transform-origin: 100% 50% 0")
Proposed SolutionAvoid the function "simplifyParameters" of CSSMinimizer be executed if the property is "transform-origin"
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036683 closed caristu Openbravo ERP CSS minifier breaks @font-face directives 
related to defect 0036710 closed dbaz Openbravo ERP CSSMinimizer does not work well with "background-size" property 
related to feature request 0036014 new jorge-garcia Retail Modules Include source maps for our javascript files 
related to defect 0036724 closed dbaz Openbravo ERP CSSMinimizer does not work well with "quotes" property 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-08-23 18:52dbazNew Issue
2017-08-23 18:52dbazAssigned To => dbaz
2017-08-23 18:52dbazOBNetwork customer => No
2017-08-23 18:52dbazModules => Core
2017-08-23 18:52dbazTriggers an Emergency Pack => No
2017-08-23 18:52dbazReview Assigned To => caristu
2017-08-23 18:56hgbotCheckin
2017-08-23 18:56hgbotNote Added: 0098620
2017-08-23 18:56hgbotStatusnew => resolved
2017-08-23 18:56hgbotResolutionopen => fixed
2017-08-23 18:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cc4fe6664e1b584b212307032a5d7096dda5842a [^]
2017-08-24 08:31caristuRelationship addedrelated to 0036683
2017-08-24 09:09caristuNote Added: 0098624
2017-08-24 09:09caristuStatusresolved => closed
2017-08-24 09:09caristuFixed in Version => 3.0PR17Q4
2017-08-24 11:13dbazIssue cloned0036710
2017-08-24 11:27dbazRelationship addedrelated to 0036710
2017-08-24 12:30caristuDescription Updatedbug_revision_view_page.php?rev_id=15699#r15699
2017-08-24 12:31caristuDescription Updatedbug_revision_view_page.php?rev_id=15700#r15700
2017-08-25 18:05dbazIssue cloned0036724
2017-08-25 18:05dbazRelationship addedrelated to 0036724
2017-08-28 09:56alostaleRelationship addedrelated to 0036014
2017-09-04 16:06caristuNote Added: 0098816
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099321

Notes
(0098620)
hgbot   
2017-08-23 18:56   
Repository: erp/devel/pi
Changeset: cc4fe6664e1b584b212307032a5d7096dda5842a
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Aug 23 18:56:08 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cc4fe6664e1b584b212307032a5d7096dda5842a [^]

Fixed issue 36708: 'transform-origin' css property now is properly minimized

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/CSSMinimizer.java
---
(0098624)
caristu   
2017-08-24 09:09   
Code reviewed + tested OK.
(0098816)
caristu   
2017-09-04 16:06   
Created a pull request[1] in owner's library.

[1] https://github.com/barryvan/CSSMin/pull/22 [^]
(0099321)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test