Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036696Retail ModulesWeb POSpublic2017-08-22 18:082018-06-26 11:43
Reporterdbaz 
Assigned Toguilleaer 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036696: [UX] OS Virtual Keyboard should not be shown while the focus is in the focus keeper (hidden) input
DescriptionThere are some hardware that when 'Use External Input' is enabled in the POS Terminal, the OS Virtual Keyboard is shown all the time, even if a barcode scanner is plugged.

This happens is Android, iOS and Windows10 in tablet mode.
Steps To ReproduceIn Android, iOS or Windows10 with no external hardware plugged, in the backoffice go to POS Terminal Type, mark the 'Use External Input'

Go to the WebPOS

Notice the virtual keyboard is shown
Proposed SolutionThis code seems that solves the problem: https://jsfiddle.net/o68fn3rp/6/ [^]

Some tests:
Android: https://www.youtube.com/watch?v=ay-dT1w52F4 [^]
iOS: https://youtu.be/bpZRYSimAkE [^]
Windows 10: https://youtu.be/TlBFzShpDWY [^]

By default, the behavior with no SO Virtual Keyboard shown should be set. Anyway, a preference to switch back to the bad (current) behavior is needed just in case there be a corner case wanting to have this strange behavior.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff diffIssue36696.diff (970) 2017-10-26 10:56
https://issues.openbravo.com/file_download.php?file_id=11238&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-08-22 18:08dbazNew Issue
2017-08-22 18:08dbazAssigned To => Retail
2017-08-22 18:08dbazTriggers an Emergency Pack => No
2017-10-26 10:56guilleaerFile Added: diffIssue36696.diff
2017-10-26 10:58guilleaerNote Added: 0100077
2017-11-13 09:43hgbotCheckin
2017-11-13 09:43hgbotNote Added: 0100473
2017-11-13 09:43hgbotStatusnew => resolved
2017-11-13 09:43hgbotResolutionopen => fixed
2017-11-13 09:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7695aebfa1230e6f69f3b74387fd3f81d49b4929 [^]
2017-11-13 09:43hgbotCheckin
2017-11-13 09:43hgbotNote Added: 0100474
2017-11-14 12:09hgbotCheckin
2017-11-14 12:09hgbotNote Added: 0100511
2017-11-14 13:34marvintmAssigned ToRetail => guilleaer
2017-11-17 12:25hgbotCheckin
2017-11-17 12:25hgbotNote Added: 0100577
2017-11-22 20:31hgbotCheckin
2017-11-22 20:31hgbotNote Added: 0100672
2017-11-22 20:31hgbotCheckin
2017-11-22 20:31hgbotNote Added: 0100673
2017-11-22 20:32hgbotCheckin
2017-11-22 20:32hgbotNote Added: 0100675
2017-11-23 11:16hgbotCheckin
2017-11-23 11:16hgbotNote Added: 0100680
2017-12-07 14:00marvintmReview Assigned To => marvintm
2017-12-07 14:00marvintmStatusresolved => closed
2017-12-07 14:00marvintmFixed in Version => RR18Q1
2018-06-26 11:30hgbotCheckin
2018-06-26 11:30hgbotNote Added: 0105388
2018-06-26 11:30hgbotCheckin
2018-06-26 11:30hgbotNote Added: 0105389
2018-06-26 11:43hgbotCheckin
2018-06-26 11:43hgbotNote Added: 0105431
2018-06-26 11:43hgbotCheckin
2018-06-26 11:43hgbotNote Added: 0105432
2018-06-26 13:49gorka_gilNote Deleted: 0105388
2018-06-26 13:49gorka_gilNote Deleted: 0105389
2018-06-26 13:49gorka_gilNote Deleted: 0105431
2018-06-26 13:49gorka_gilNote Deleted: 0105432

Notes
(0100077)
guilleaer   
2017-10-26 10:58   
I have tested the patch (attached) and it seems that it works fine in Android.

Pending to be tested in IOS.

If it not works fine in IOS I think that make sense to include it in mobilecore under a preference or flag because this fix is very usefull for devices which have an integrated barcode scanner (like Zebra)
(0100473)
hgbot   
2017-11-13 09:43   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7695aebfa1230e6f69f3b74387fd3f81d49b4929
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Nov 10 11:48:21 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7695aebfa1230e6f69f3b74387fd3f81d49b4929 [^]

Fixed issue 36696: Screen keyboard will not be shown when focus keeper gets the focus if new flag "useEmbededBarcode" is enabled.

- Added new field (column and element) "Use embeded barcode" to "pos terminal type" window. This field will only be shown when the flag "Use External Input" is enabled.
- When web POS is loaded the value of this new field is readed and will overwrite the core value of the property useEmbededBarcode
- Fields shown in grid view in POS terminal type window have been organized

---
M src-db/database/model/tables/OBPOS_TERMINALTYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0100474)
hgbot   
2017-11-13 09:43   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 08aa06952be03d43e3bdef1d584eefb28806368b
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Nov 10 11:40:50 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/08aa06952be03d43e3bdef1d584eefb28806368b [^]

Related to issue 36696: Screen keyboard will not be shown if terminal property useEmbededBarcode is true

---
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0100511)
hgbot   
2017-11-14 12:09   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 144ef57f6a3c111bd18c89fea1e1a6e8378bb738
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Nov 10 18:12:18 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/144ef57f6a3c111bd18c89fea1e1a6e8378bb738 [^]

Related to issue 36696: Add new field USEEMBEDEDBARCODESCANNER to terminal type sample data

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_TERMINALTYPE.xml
---
(0100577)
hgbot   
2017-11-17 12:25   
Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: c324dc61a5f6a39d67fc4e832ab433241299af4d
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Nov 17 12:25:02 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/c324dc61a5f6a39d67fc4e832ab433241299af4d [^]

Related to issue 36696: Adapt junit test sample data to include new field

---
M referencedata/sampledata/Retail_Test/OBPOS_TERMINALTYPE.xml
---
(0100672)
hgbot   
2017-11-22 20:31   
Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: 5025df86b409142614e0fbcb26b129ccb762c1e1
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Nov 22 17:33:38 2017 +0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/5025df86b409142614e0fbcb26b129ccb762c1e1 [^]

Related to issue 36696: Change default value to Y in sampledata

---
M referencedata/sampledata/Retail_Test/OBPOS_TERMINALTYPE.xml
---
(0100673)
hgbot   
2017-11-22 20:31   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 1ae2f4b4fe0d610cfdba69f63f9341cc3665f03b
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Nov 22 17:30:51 2017 +0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/1ae2f4b4fe0d610cfdba69f63f9341cc3665f03b [^]

Related to issue 36696: Change default value to Y in sampledata

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_TERMINALTYPE.xml
---
(0100675)
hgbot   
2017-11-22 20:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5e920873d166ebc8e7c941457c0b4e0fade11b15
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Nov 22 17:27:39 2017 +0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5e920873d166ebc8e7c941457c0b4e0fade11b15 [^]

Related to issue 36696: Change field name and make Y default value

---
M src-db/database/model/tables/OBPOS_TERMINALTYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0100680)
hgbot   
2017-11-23 11:16   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b69c086d07e8bd23e3b2d2ebe5fc902eff768854
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Nov 23 14:15:54 2017 +0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b69c086d07e8bd23e3b2d2ebe5fc902eff768854 [^]

Related to issue 36696: By default screen keyboard is hidden

---
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---