Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036651Openbravo ERP09. Financial managementpublic2017-08-14 21:572018-06-12 14:08
markmm82 
markmm82 
normalmajorhave not tried
closedfixed 
5
 
3.0PR18Q3 
dmiguelez
Core
No
0036651: Clean up of repeated logs found in try-addpayment jobs for Payment's workflows
Executing this job:
https://ci.openbravo.com//job/try-addpayment-oracle/190/artifact/SANDBOX/tomcat-logs/ci10.140.log/*view*/ [^]

The same message is logged 3 times in total without the stacktrace, and once more with stacktrace. It is needed to make a cleanup of this logs to avoid repeat it if it is not needed.
Execute this job:
https://ci.openbravo.com//job/try-addpayment-oracle/190/artifact/SANDBOX/tomcat-logs/ci10.140.log/*view*/ [^]
No tags attached.
Issue History
2017-08-14 21:57markmm82New Issue
2017-08-14 21:57markmm82Assigned To => Triage Finance
2017-08-14 21:57markmm82Modules => Core
2017-08-14 21:57markmm82Triggers an Emergency Pack => No
2017-08-14 22:01markmm82Assigned ToTriage Finance => markmm82
2017-10-03 18:09markmm82Statusnew => scheduled
2018-06-12 10:06hgbotCheckin
2018-06-12 10:06hgbotNote Added: 0105080
2018-06-12 10:06hgbotStatusscheduled => resolved
2018-06-12 10:06hgbotResolutionopen => fixed
2018-06-12 10:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e048d67b76d350384ef912deb0d8f8d2b6905f3c [^]
2018-06-12 10:06hgbotCheckin
2018-06-12 10:06hgbotNote Added: 0105082
2018-06-12 10:08dmiguelezReview Assigned To => dmiguelez
2018-06-12 10:08dmiguelezNote Added: 0105084
2018-06-12 10:08dmiguelezStatusresolved => closed
2018-06-12 10:08dmiguelezFixed in Version => 3.0PR18Q3
2018-06-12 14:08hudsonbotCheckin
2018-06-12 14:08hudsonbotNote Added: 0105096
2018-06-12 14:08hudsonbotCheckin
2018-06-12 14:08hudsonbotNote Added: 0105098

Notes
(0105080)
hgbot   
2018-06-12 10:06   
Repository: erp/devel/pi
Changeset: e048d67b76d350384ef912deb0d8f8d2b6905f3c
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jun 08 14:03:19 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e048d67b76d350384ef912deb0d8f8d2b6905f3c [^]

Fixes issue 36651: Clean up of repeated logs found in try-addpayment jobs
for Payment's workflows

Functional validations are not logged any more, only not specific exceptions are now
logged. Also this fix to avoid to log the same error more than once, log4j.error() is
executed only in the processPayment function.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0105082)
hgbot   
2018-06-12 10:06   
Repository: erp/devel/pi
Changeset: 30563bebf57c1183daeffd70813822491d91ff6f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Jun 12 10:00:05 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/30563bebf57c1183daeffd70813822491d91ff6f [^]

Related to Issue 36651. Code Review changes. Renamed exception
variable names

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0105084)
dmiguelez   
2018-06-12 10:08   
Code Review + Testing Ok
(0105096)
hudsonbot   
2018-06-12 14:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e050974318af [^]
Maturity status: Test
(0105098)
hudsonbot   
2018-06-12 14:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e050974318af [^]
Maturity status: Test