Openbravo Issue Tracking System - Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0036646 | Modules | Remittance | public | 2017-08-14 10:37 | 2017-08-31 12:58 |
|
| Reporter | ngarcia | |
| Assigned To | markmm82 | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Regression date | |
| Regression introduced by commit | |
| Regression level | |
| Review Assigned To | aferraz |
| Support ticket | |
| OBNetwork customer | |
| Regression introduced in release | |
|
| Summary | 0036646: Expected date of a Remittance should not be changed to a date before the due date of orders and invoices included on it |
| Description | Expected date of a Remittance should not be changed to a date before the due date of orders and invoices included on it
When selecting orders or invoices to be included in a remittance, you can only select the ones with a due date previous to the remittances due date. Once selected, you could modify the remittances due date and assign a date previous to the invoices' due date |
| Steps To Reproduce | As group admin role:
Create two invoices, one with Immediate payment terms and the other with 30 days payment terms
Create a remittance
Add today as transaction date
Add a date between invoices' due date as expected date
Launch the Select Orders or Invoices Process and check only one of the invoices is shown
Change the remittances expected date with a date after invoices' due date
Launch the Select Orders or Invoices Process and check two invoices are shown
Change the remittances due date to a date previous to invoices' due date
Launch the Select Orders or Invoices Process and check two invoices are shown (as they were selected)
Remove its selection
Launch the Select Orders or Invoices Process and check two invoices are not shown
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-08-14 10:37 | ngarcia | New Issue | |
| 2017-08-14 10:37 | ngarcia | Assigned To | => Triage Finance |
| 2017-08-14 10:38 | ngarcia | Issue Monitored: networkb | |
| 2017-08-14 10:38 | ngarcia | Resolution time | => 1504476000 |
| 2017-08-28 10:56 | aferraz | Assigned To | Triage Finance => markmm82 |
| 2017-08-28 15:56 | markmm82 | Status | new => scheduled |
| 2017-08-28 19:34 | markmm82 | Note Added: 0098668 | |
| 2017-08-31 11:06 | hgbot | Checkin | |
| 2017-08-31 11:06 | hgbot | Note Added: 0098747 | |
| 2017-08-31 11:06 | hgbot | Status | scheduled => resolved |
| 2017-08-31 11:06 | hgbot | Resolution | open => fixed |
| 2017-08-31 11:06 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/0128d25eb5b69d972c35006d321a869f9824de71 [^] |
| 2017-08-31 11:06 | hgbot | Checkin | |
| 2017-08-31 11:06 | hgbot | Note Added: 0098748 | |
| 2017-08-31 12:52 | hgbot | Checkin | |
| 2017-08-31 12:52 | hgbot | Note Added: 0098753 | |
| 2017-08-31 12:52 | hgbot | Checkin | |
| 2017-08-31 12:52 | hgbot | Note Added: 0098754 | |
| 2017-08-31 12:58 | aferraz | Review Assigned To | => aferraz |
| 2017-08-31 12:58 | aferraz | Note Added: 0098755 | |
| 2017-08-31 12:58 | aferraz | Status | resolved => closed |
|
Notes |
|
|
|
Test plan:
As group admin role:
1. Create a sales invoice
Payment terms = Immediate
Invoice Date = 2017-08-28
Add a line to it and complete the document.
Notice in Payment Plan Expected Date is the same at header = 2017-08-28.
2. Create another sales invoice
Payment terms = 30 days
Invoice Date = 2017-08-28
Add a line to it and complete the document.
Notice in Payment Plan Expected Date is onem month later than header's date = 2017-09-27.
3. Create a remittance
4. Add today as transaction date (2017-08-28)
5. Add a date between invoices' due date as expected date, for instance = 2017-08-30. Save record.
Notice you can do it successfully.
6. Launch the Select Orders or Invoices Process and check only first invoice with due date previous than expected date is shown (2017-08-28)
7. Change the remittances expected date with a date after invoices' due date, for instance = 2017-09-30. Save record.
8. Launch the Select Orders or Invoices Process and check two invoices are shown. Select both lines and PROCESS.
Notice two new remittance lines has been created.
9. Change the remittances due date to a date previous to invoices' due date, for instance 2017-09-15.
Notice an error messge is shown after saving changes:
"Error
Saving failed. Expected date of a Remittance can't be changed to a date before the due date of orders and invoices included on it."
10. Cancel the change and remove the last invoice included in remittance with due date later than 2017-09-15.
11. Change again the remittances due date to a date previous to invoices' due date, for instance 2017-09-15.
Notice this time it is possible save change and no error is shown.
12. Launch the Select Orders or Invoices Process and check just invoice previously selected is shown
13. Remove its selection. Notice process is successfully. |
|
|
|
(0098747)
|
|
hgbot
|
|
2017-08-31 11:06
|
|
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 0128d25eb5b69d972c35006d321a869f9824de71
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Aug 28 17:05:46 2017 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/0128d25eb5b69d972c35006d321a869f9824de71 [^]
Fixes issue 36646: Expected date of a Remittance should not be changed
When selecting orders or invoices to be included in a remittance, it is only possible
select the ones with a due date previous to the remittances due date. Once selected,
is possible modify the remittances due date and assign a date previous to the
invoices' due date, and it is not consistent with process of selecting orders and
invoices.
To avoid this issue, every time the expected date of the remittance is changed it
is validated that doesn't exists any line with a due date before than the new remittance's
expected date, if exists an error message is shown and remittance can't be saved.
---
M src-db/database/model/triggers/REM_REMITTANCE_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
|
|
|
|
(0098748)
|
|
hgbot
|
|
2017-08-31 11:06
|
|
|
|
|
(0098753)
|
|
hgbot
|
|
2017-08-31 12:52
|
|
|
|
|
(0098754)
|
|
hgbot
|
|
2017-08-31 12:52
|
|
|
|
|
|
|