Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036643ModulesAlerts for APRMpublic2017-08-11 14:252017-09-01 12:22
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customer
Regression introduced in release
Summary0036643: Error (false positive) in "NOT BALANCED SALES INVOICE" alert
Description"NOT BALANCED XXXXX" alerts are not correctly considering "orgnization" accounting dimension

Alerts are located in following module:
http://centralrepository.openbravo.com/openbravo/org.openbravo.forge.ui/ForgeProjectDetail/accountingalerts30 [^]
Steps To Reproduce1. Install version 3.0.14 of http://centralrepository.openbravo.com/openbravo/org.openbravo.forge.ui/ForgeProjectDetail/accountingalerts30 [^]
2. Access to Enterprise Module Management and apply dataset to * organization
3. Access Client window, set "Organization" dimension as "Show in lines"
4. Access to Client | Dimensions tab. Filter by AR Invoice and set "Organization" as "show in lines"
5. Logout/login
6. Access Sales Invoice window. Create record for España organization and set any BP
7. Add Line for any product and set Organization "España Norte" as line dimension
8. Complete invoice and post it. Realize that accounting entry is balanced
9. Access Process Request and schedule "Alerts" process to be Run immediately
10. Realize that alert has been created

NOTE: it is necessary to also review other "NOT BALANCED XXXXX" alerts that could have same problem
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-08-11 14:25maiteNew Issue
2017-08-11 14:25maiteAssigned To => Triage Finance
2017-08-11 14:25maiteIssue Monitored: networkb
2017-08-21 12:37maiteResolution time => 1504216800
2017-08-28 10:54aferrazAssigned ToTriage Finance => markmm82
2017-08-28 14:28aferrazAssigned Tomarkmm82 => AtulOpenbravo
2017-08-29 08:16AtulOpenbravoStatusnew => scheduled
2017-08-31 16:44AtulOpenbravoNote Added: 0098761
2017-09-01 12:02hgbotCheckin
2017-09-01 12:02hgbotNote Added: 0098770
2017-09-01 12:02hgbotStatusscheduled => resolved
2017-09-01 12:02hgbotResolutionopen => fixed
2017-09-01 12:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.alerts.accounting30/rev/4dcaeeb49514c567f1f830fd88f106edbb138df0 [^]
2017-09-01 12:02hgbotCheckin
2017-09-01 12:02hgbotNote Added: 0098771
2017-09-01 12:22aferrazReview Assigned To => aferraz
2017-09-01 12:22aferrazNote Added: 0098772
2017-09-01 12:22aferrazStatusresolved => closed

Notes
(0098761)
AtulOpenbravo   
2017-08-31 16:44   
- Install version 3.0.14 of http://centralrepository.openbravo.com/openbravo/org.openbravo.forge.ui/ForgeProjectDetail/accountingalerts30 [^] [^]
- Login as F&B International Group Admin
- Access to Enterprise Module Management and apply dataset to * organization
- Access Client window, set "Organization" dimension as "Show in lines"
- Access to Client | Dimensions tab. Filter by AR Invoice, AP Invoice, GL Journal and set "Organization" as "show in lines"
- Navigate to Alerts "NOT BALANCED SALES INVOICE, NOT BALANCED PURCHASE, NOT BALANCED GL JOURNAL", add recipient as
  Role "F&B International Group Admin"
- Logout and Login
- Create a Sales Invoice in F&B España, S.A org for any business partner.
- Add line for any product, invoiced qty = 100, set Organization dimension as F&B España - Región Norte
- Complete and post invoice
- Create a Purchase Invoice in F&B España, S.A org for any business partner.
- Add line for any product, invoiced qty = 100, set Organization dimension as F&B España - Región Sur
- Complete and post invoice
- Create a G/L Journal entry for F&B España, Name = Test 36643, Document Date = Accounting Date = Today's Date
- Create a Header, Add lines as below
- Line 10, Organization: F&B España - Región Norte, Account: 10000 - Capital social, Debit = 100
- Line 20, Organization: F&B España - Región Sur, Account: 10100 - Fondo social, Credit = 100
- Complete GL Journal and post it.
- Nagivate to Process Request and schedule a Alert Process with Timing, Run Immediately.
- Refresh browser and realize that no alerts are generated for above purchase invoice, sales invoice and gl journal record.
(0098770)
hgbot   
2017-09-01 12:02   
Repository: erp/mods/org.openbravo.alerts.accounting30
Changeset: 4dcaeeb49514c567f1f830fd88f106edbb138df0
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Aug 31 20:22:20 2017 +0530
URL: http://code.openbravo.com/erp/mods/org.openbravo.alerts.accounting30/rev/4dcaeeb49514c567f1f830fd88f106edbb138df0 [^]

Fixes issue 36643: Error (false positive) in several NOT BALANCED xxx alert

When using organization dimensions in lines, group by clause should not
use ad_org_id to meet balancing fact acct record for following alerts
** NOT BALANCED SALES INVOICE
** NOT BALANCED PURCHASE INVOICE
** NOT BALANCED G/L JOURNAL
To keep ad_org_id in the select clause default value '0' (* Org) is used

---
M referencedata/standard/Accounting_Alerts.xml
---
(0098771)
hgbot   
2017-09-01 12:02   
Repository: erp/mods/org.openbravo.alerts.accounting30
Changeset: 408f3d5b694884a1e145963a96626a327eef1431
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 01 12:01:59 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.alerts.accounting30/rev/408f3d5b694884a1e145963a96626a327eef1431 [^]

Related to issue 36643: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0098772)
aferraz   
2017-09-01 12:22   
Code review + Testing OK