Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036625Retail ModulesWeb POSpublic2017-08-08 11:462017-09-12 11:35
Reportermaite 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036625: amountToKeep calculated to more than 2 decimals under some circumstances (due to javascript calculations)
Descriptiondepending on the amounts, javascript is calculating "amountToKeep":"586.8199999999999" which is causing CashUp not imported
Steps To Reproduce1. Access to the terminal and ensure that starting amount is 0.00 (in case it is needed do an initial cash up)
2. Create new ticket adding any product and setting price=389.82. Pay it using CASH
3. Create new ticket adding any product and setting price=25. Set option "layaway this receipt" and LAYAWAY it using CASH
4. Create new ticket adding any product and setting price=17. Set option "layaway this receipt" and LAYAWAY it using CASH
5. Create new ticket adding any product and setting price=25. Set option "layaway this receipt" and LAYAWAY it using CASH
6. Create new ticket adding any product and setting price=50. Set option "layaway this receipt" and LAYAWAY it using CASH
7. Run CashUp process selecting option "Total Amount=389.82" to KEEP for CASH
8. Create new ticket and pay 4 previous layaways using CASH
9. Create new ticket adding any product and setting price=52. Pay it using CASH
10.Create new ticket adding any product and setting price=28. Pay it using CASH
11. Run CashUp process selecting option "Total Amount=586.82" to KEEP for CASH

Access to backoffice to "Errors while importing POS data" and realize that this last cashup is there. If you review the JSON you can see that "amountToKeep" has been calculated to "586.8199999999999"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch issue 36625 test 6721.patch (8,626) 2017-08-16 10:22
https://issues.openbravo.com/file_download.php?file_id=10979&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-08-08 11:46maiteNew Issue
2017-08-08 11:46maiteAssigned To => Retail
2017-08-08 11:46maiteResolution time => 1503957600
2017-08-08 11:46maiteTriggers an Emergency Pack => No
2017-08-08 11:46maiteIssue Monitored: networkb
2017-08-08 11:52PracticsIssue Monitored: Practics
2017-08-16 09:37ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-08-16 09:37ranjith_qualiantech_comStatusnew => scheduled
2017-08-16 10:22ranjith_qualiantech_comFile Added: issue 36625 test 6721.patch
2017-09-06 14:45hgbotCheckin
2017-09-06 14:45hgbotNote Added: 0098863
2017-09-06 14:45hgbotStatusscheduled => resolved
2017-09-06 14:45hgbotResolutionopen => fixed
2017-09-06 14:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3d8591f9140f7393dc9daa84fbb34f27e85b06af [^]
2017-09-06 14:45hgbotCheckin
2017-09-06 14:45hgbotNote Added: 0098864
2017-09-07 07:38hgbotCheckin
2017-09-07 07:38hgbotNote Added: 0098877
2017-09-07 07:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3d8591f9140f7393dc9daa84fbb34f27e85b06af [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a4bdb68cf987df6e25d47baf1cce7ad0c4102d2d [^]
2017-09-08 15:11marvintmReview Assigned To => marvintm
2017-09-08 15:11marvintmStatusresolved => closed
2017-09-08 15:11marvintmFixed in Version => RR17Q4
2017-09-12 11:34ranjith_qualiantech_comNote Edited: 0098877bug_revision_view_page.php?bugnote_id=0098877#r15869
2017-09-12 11:35ranjith_qualiantech_comNote Added: 0098980

Notes
(0098863)
hgbot   
2017-09-06 14:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3d8591f9140f7393dc9daa84fbb34f27e85b06af
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Sep 06 18:15:04 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3d8591f9140f7393dc9daa84fbb34f27e85b06af [^]

Fixed issue 36625 : Validating countcash in cashup

* Used OB.DEC.add for adding Counted Cash

---
M web/org.openbravo.retail.posterminal/js/closecash/view/tabcashpayments.js
M web/org.openbravo.retail.posterminal/js/closecash/view/tabcountcash.js
---
(0098864)
hgbot   
2017-09-06 14:45   
Repository: tools/automation/pi-mobile
Changeset: 10f152548e36fff8fb18ca1e0b83cb1b3f121c55
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Sep 06 18:15:16 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/10f152548e36fff8fb18ca1e0b83cb1b3f121c55 [^]

Verifies issue 36625 : Added automated test 'I36625_VerifyCashupAmountToKeep'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I36625_VerifyCashupAmountToKeep.java
---
(0098877)
hgbot   
2017-09-07 07:38   
(edited on: 2017-09-12 11:34)
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a4bdb68cf987df6e25d47baf1cce7ad0c4102d2d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Sep 07 11:06:55 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a4bdb68cf987df6e25d47baf1cce7ad0c4102d2d [^]

Fixed issue 36800 : Reset keyboard status when discount is applied

* In Scan tab, Discount should be deselected like quantity after discount is applied

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0098980)
ranjith_qualiantech_com   
2017-09-12 11:35   
Changeset: a4bdb68cf987df6e25d47baf1cce7ad0c4102d2d is related to issue https://issues.openbravo.com/view.php?id=36800 [^]