0036622: Add a not needed payment can generate wrong data

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036622

Retail Modules

Web POS

public

2017-08-08 07:22

2017-10-11 13:22

Reporter

guillermogil

Assigned To

ranjith_qualiantech_com

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR17Q4

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0036622: Add a not needed payment can generate wrong data

Description

If you add a not needed payment (e.g.- add a payment when the total has been paid) if that payment is check as cash it can generate wrong data due to cash change.
It should not be possible to allow that.

Steps To Reproduce

- Add this hook to your code:
OB.UTIL.HookManager.registerHook('OBPOS_preAddPayment', function (args, callbacks) {
  if (args.paymentToAdd.get('amount') < 0) {
    args.paymentToAdd.set('paid', args.paymentToAdd.get('amount'));
    args.paymentToAdd.set('origAmount', args.paymentToAdd.get('amount'))
    args.paymentToAdd.set('paymentData', {
      change: 'change payment'
    });
  }
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
});

- Load WebPOS
- Add an Avalanche transceiver
- Pay totally with card
- Add 5€ as cash

Look the backend, you will see that total payment is wrong,

Proposed Solution

It should have 2 different solutions:
- It should not be possible to add a payment (first lines of addPayment function) if amount is positive (to grant change) and pending is <= 0
- There should be an additionnal check to ensure that if something has happend with the payments, to not allow it (e.g.- Add a product that cost 10, pay it, then on the same ticket return a product that cost 20) Those cases are not taken into account properly

Update: another case should also be taken into account: if a payment was added to a positive receipt, and then the receipt total changes to a negative amount (because negative lines are added, or a positive line is changed into a negative line), then the payment should also be considered invalid, and the user should also not be able to complete the ticket.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0037264	closed	ranjith_qualiantech_com	Returning change in a payment method with payment data generates a wrong payment plan
causes	defect	0037224	closed	ranjith_qualiantech_com	It is not possible to finish a refund with multiple means of payment
causes	defect	0037809	closed	ranjith_qualiantech_com	[RR18q1] "Unneeded Payments" Error message is not taking conversion rate into account