Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036608Openbravo ERPA. Platformpublic2017-08-04 13:252017-09-21 16:49
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036608: 2 flush of 16ms each in MyOpenbravoActionHandler called during ERP login
Description2 flushes with high entity count of 277 and taking 30ms of 500ms total time
action is probably RELOAD_WIDGETS preparing full list of all available widget-classes

56282 [http-bio-8080-exec-10] INFO org.openbravo.dal.service.OBDal - Flush of 277 entities and 1403 collections took: 16
56297 [http-bio-8080-exec-10] INFO org.openbravo.dal.service.OBDal - Content of session: {ADLanguage=1, ADModule=6, ADReference=10, ADTab=13, ADTable=11, ModuleDBPrefix=24, OBCLKER_Template=1, OBCQL_QueryColumn=68, OBCQL_WidgetQuery=10, OBKMO_WidgetClass=33, OBKMO_WidgetClassMenu=2, OBKMO_WidgetInstance=8, OBKMO_WidgetURL=13, OBSERDS_Datasource=1, OBUIAPP_Parameter=75, Organization=1}
56297 [http-bio-8080-exec-10] INFO org.openbravo.dal.service.OBDal - Flush of 277 entities and 1403 collections took: 15
56303 [http-bio-8080-exec-10] INFO org.openbravo.dal.core.DalRequestFilter - request= /openbravo/org.openbravo.client.kernel?_action=org.openbravo.client.myob.MyOpenbravoActionHandler flushCount: 2 requestTime: 499
Steps To Reproduce-
Proposed Solution
Additional Information
TagsPerformance
Relationships
blocks design defect 0036606 new Triage Platform Base Clean up extra not requires flush() calls 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-08-04 13:25shuehnerNew Issue
2017-08-04 13:25shuehnerAssigned To => platform
2017-08-04 13:25shuehnerModules => Core
2017-08-04 13:25shuehnerTriggers an Emergency Pack => No
2017-08-04 13:25shuehnerRelationship addedblocks 0036606
2017-08-04 13:31shuehnerNote Added: 0098394
2017-08-10 11:29alostaleTag Attached: Performance
2017-08-10 11:29alostaleAssigned Toplatform => alostale
2017-08-10 11:29alostaleReview Assigned To => caristu
2017-08-10 11:32hgbotCheckin
2017-08-10 11:32hgbotNote Added: 0098469
2017-08-10 11:32hgbotStatusnew => resolved
2017-08-10 11:32hgbotResolutionopen => fixed
2017-08-10 11:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3823a47da98cd13a44d383c09788bc8c300aed7f [^]
2017-08-11 11:07caristuNote Added: 0098485
2017-08-11 11:07caristuStatusresolved => closed
2017-08-11 11:07caristuFixed in Version => 3.0PR17Q4
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099307

Notes
(0098394)
shuehner   
2017-08-04 13:31   
Both bad usage of new DalConnectionProvider()

Note instead of fixing OBMEssageUtils has copy of functions not taking conn argument and handling that inside
(0098469)
hgbot   
2017-08-10 11:32   
Repository: erp/devel/pi
Changeset: 3823a47da98cd13a44d383c09788bc8c300aed7f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Aug 10 11:29:45 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3823a47da98cd13a44d383c09788bc8c300aed7f [^]

fixed issue 36608: unneded flushes in MyOpenbravoActionHandler

---
M modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoActionHandler.java
---
(0098485)
caristu   
2017-08-11 11:07   
Code reviewed + tested OK.
(0099307)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test