Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036605Openbravo ERPA. Platformpublic2017-08-04 12:322018-01-03 12:38
Reporteralostale 
Assigned Toinigosanchez 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036605: unneeded datasource requests opening alert management window
DescriptionWhen Alert Management window is opened, 10 requests to datasource are performed:

* 4 to define them
* 6 to get actual alerts in different statuses
  - New: 1
  - Acknowledged: 1
  - Suppressed: 2
  - Solved: 2
Steps To Reproduce-Open Alert Management window from top bar
  -> check requests (see attached image)
  
Proposed SolutionMust have:
  * Remove duplicates for Suppressed and Solved

Nice to have:
  * Are the 4 definition requests required? All of them are for the same datasource; so, at most, 1 could be done and share the result
  * Is any definition request needed at all? Couldn't we just define statically in JavaScript?
  * By default only New and Pending are sections are displayed, could we request the collapsed sections lazily only when opened? Note that Alert count is displayed even if collapsed
Additional Information
TagsPerformance
Relationships
related to defect 0037161 acknowledged Triage Platform Base Extra DS calls in Alert Management window when refreshing after expand/collapse a section 
related to defect 0035838 closed inigosanchez Bad performance in alert window when having +20000 records in ad_alert and many of them are solved 
Attached Filespng Selection_207.png (38,187) 2017-08-04 12:32
https://issues.openbravo.com/file_download.php?file_id=10968&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-08-04 12:32alostaleNew Issue
2017-08-04 12:32alostaleAssigned To => platform
2017-08-04 12:32alostaleModules => Core
2017-08-04 12:32alostaleTriggers an Emergency Pack => No
2017-08-04 12:32alostaleStatusnew => acknowledged
2017-08-04 12:32alostaleFile Added: Selection_207.png
2017-08-04 12:33alostaleSummaryunneeded datasource requests opening alert window => unneeded datasource requests opening alert management window
2017-08-04 12:33alostaleDescription Updatedbug_revision_view_page.php?rev_id=15594#r15594
2017-08-04 12:33alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15596#r15596
2017-08-04 12:33alostaleTag Attached: Performance
2017-08-04 12:34alostaleRelationship addedrelated to 0035838
2017-08-04 14:32shuehnerIssue Monitored: shuehner
2017-10-02 17:45inigosanchezStatusacknowledged => scheduled
2017-10-02 17:45inigosanchezAssigned Toplatform => inigosanchez
2017-10-24 10:39hgbotCheckin
2017-10-24 10:39hgbotNote Added: 0100015
2017-10-24 10:39hgbotStatusscheduled => resolved
2017-10-24 10:39hgbotResolutionopen => fixed
2017-10-24 10:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d51b35c667bc73dd1be71dcb8c3427766a617157 [^]
2017-10-24 10:40inigosanchezReview Assigned To => alostale
2017-10-24 13:31alostaleNote Added: 0100025
2017-10-24 13:31alostaleStatusresolved => new
2017-10-24 13:31alostaleResolutionfixed => open
2017-10-25 12:22hgbotCheckin
2017-10-25 12:22hgbotNote Added: 0100053
2017-10-25 12:45inigosanchezNote Added: 0100060
2017-10-25 12:45inigosanchezRelationship addedrelated to 0037161
2017-10-25 12:46inigosanchezStatusnew => scheduled
2017-10-25 12:47inigosanchezStatusscheduled => resolved
2017-10-25 12:47inigosanchezFixed in Version => pi
2017-10-25 12:47inigosanchezResolutionopen => fixed
2017-10-25 12:47inigosanchezFixed in Versionpi =>
2017-10-27 08:25hgbotCheckin
2017-10-27 08:25hgbotNote Added: 0100087
2017-10-27 08:31alostaleNote Added: 0100088
2017-10-27 08:31alostaleStatusresolved => closed
2017-10-27 08:31alostaleFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101343
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101347
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101348

Notes
(0100015)
hgbot   
2017-10-24 10:39   
Repository: erp/devel/pi
Changeset: d51b35c667bc73dd1be71dcb8c3427766a617157
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Oct 24 10:25:47 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d51b35c667bc73dd1be71dcb8c3427766a617157 [^]

Fixed issue 36605: unneeded datasource requests opening alert management window

The problem was when Alert Management window was opened, 10 requests to datasource were performed.
In order to improve this situation, several actions have been done. Firts, the 4 calls of the datasource
definition are removed. Now, the datasource is defined statically. Thisthat Alert Management window is
not working good. Also, two of the duplicate request are removed.

Besides, when the Alert Management window is closed and the four grids are removed, now the datasources
are destroyed too in order to avoid having several instances for the same datasources every time that
Alerts windowd is reopened. Now, every grid removes their own datasource.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-management-view.js
---
(0100025)
alostale   
2017-10-24 13:31   
reopening, refresh is not working as expected:
-4 requests expected (one for each status), only 2 performed
-some caught exception while requesting at REFRESH_BUTTON_PROPERTIES callbackEnableButton
(0100053)
hgbot   
2017-10-25 12:22   
Repository: erp/devel/pi
Changeset: 0c21b43d56ad66d88a7a839a47e66f690b2c1967
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Oct 25 12:10:15 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0c21b43d56ad66d88a7a839a47e66f690b2c1967 [^]

Related with the issue 36605: Refresh is not working as expected

Refresh is not working as expected in Alert Management window. The problem was that a
partial solution of the issue was pushed by mistake. Now the problem of the refresh is
fixed. When a refresh is launched, 4 request are performed (one for each status).

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-management-view.js
---
(0100060)
inigosanchez   
2017-10-25 12:45   
A minor issue has been found 0037161 while testing the current issue.
(0100087)
hgbot   
2017-10-27 08:25   
Repository: erp/devel/pi
Changeset: 59eb88d7928951fa84dfbb144b66a879574a802e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Oct 27 08:24:25 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/59eb88d7928951fa84dfbb144b66a879574a802e [^]

related to bug 36605: unneeded datasource requests in alert management window

  Removed unneeded parameter in getSectionHeader.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-management-view.js
---
(0100088)
alostale   
2017-10-27 08:31   
reviewed + tested
(0101343)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101347)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101348)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test