0000366: Update process trims the body of functions and triggers when comparing

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0000366

Openbravo ERP

Y. DBSourceManager

public

2008-05-19 17:14

2009-03-18 11:02

Reporter

marvintm

Assigned To

marvintm

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0000366: Update process trims the body of functions and triggers when comparing

Description

When performing and update.database, DBSourceManager loads the database model from the database, and compares it with the model in the XML files.

When comparing functions and triggers, the bodies are compared. However, instead of comparing them directly, they are first trimmed and then compared.

This is wrong, as functions and triggers that are different (for example, functions that have additional blank spaces at the begining or the end of their body) would instead appear to be equal, and therefore the update.database process would not update them in the database.

Steps To Reproduce

Do a create.database. Then modify the XML file of a function or trigger, adding blank spaces to the end of the body. Then do update.database. The update process should detect the modification you've done and update the function or trigger, but instead, it will do nothing.

Proposed Solution

Additional Information