0036598: Process Definition for multirecord sets only one organization in filter parameters

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036598

Openbravo ERP

A. Platform

public

2017-08-04 09:35

2017-09-21 16:49

Reporter

vmromanos

Assigned To

inigosanchez

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR17Q4

Fixed in Version

3.0PR17Q4

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0036598: Process Definition for multirecord sets only one organization in filter parameters

Description

A Process Definition is defined to work with multirecords. In this case you can select records belonging to different organizations.
However, when the records are submitted to the server, a unique parameter "_org=" is sent as filter. Then the server detects it and tries to get the natural tree for this organization.
When you have selected records belonging to different trees, the records belonging to a different natural tree of the "_org" parameter are filtered out.

Steps To Reproduce

Create a Process Definition for multirecord and standard ui.
Add a grid that shows Sales Invoices
Create a button in Sales Invoice window and link it to the process definition

In the onload function for the Process Definition add a similar code, replacing the necessary lines (mainly function name and grid name):

OB.OBAWO.onLoad = function (view) {
  var selection, paramGrid, parentGrid, criteria, gridCriteria;

  parentGrid = view.parentWindow.view.viewGrid;
  selection = parentGrid.getSelectedRecords();
  paramGrid = view.theForm.getItem('stock').canvas.viewGrid;

  criteria = [];
  selection.forEach(function (r) {
    criteria.push({
      fieldName: 'id',
      operator: 'equals',
      value: r.id
    });
  });
  gridCriteria = {
          operator: 'or',
    _constructor: 'AdvancedCriteria',
    criteria: criteria
  };

  paramGrid.dataSource.requestProperties.params.criteria = gridCriteria;

};

The idea is to select some records in Sales Invoice window, press the Process Definition button, and display only those records in the new popup grid.

In Sales Invoice window select 2 records, one for Norte and the other for Sur. Press the Process Definition button.
Verify just one record is shown.
Close the popup.

Repeat the selection, but this time selecting several records from the same org.
Verify all the records are now shown in the new grid.

Set a break point in AdvancedQueryBuilder.java, addWhereOrgParameters method.
And repeat the process.
Verify filterparameters contains a parameter _org with any of the organizations, that is used to add the natural tree filter. Example (in my case I work with storage details):

{@MaterialMgmtStorageDetail.storageBin@=4B413455BCE541C0AB80E18BFD7247B5, @MaterialMgmtStorageDetail.client@=A64C68776B544B0DB59C16456C43E608, @MaterialMgmtStorageDetail.product@=110D54D3A4214D3095008EC8F35D88B5, @MaterialMgmtStorageDetail.id@=DBB2E952074E47A5B4377B4115F03F02, whereAndFilterClause=e.qtyPutAway>0, @MaterialMgmtStorageDetail.organization@=3FF21930C89F4A8FAC60E7264BF96568, @MaterialMgmtStorageDetail.uOM@=100, _org=3FF21930C89F4A8FAC60E7264BF96568, @MaterialMgmtStorageDetail.attributeSetValue@=0}

Proposed Solution

When selecting multiple records, it would be better to set the JsonConstants.CALCULATE_ORGS parameter instead so we enter by the second if:

    if (filterParameters.containsKey(JsonConstants.ORG_PARAMETER)) {
      final String value = filterParameters.get(JsonConstants.ORG_PARAMETER);
      if (entity.isOrganizationEnabled() && value != null && value.length() > 0) {
        orgs = OBContext.getOBContext().getOrganizationStructureProvider().getNaturalTree(value);
        orgPart = buildOrgPartWhereClause(orgs);
      }
      localWhereClause = buildLocalWhereClause(localWhereClause, orgPart);
    } else if (filterParameters.containsKey(JsonConstants.CALCULATE_ORGS)) {
      // add natural tree of writable organizations
      final Set<String> orgsWritables = OBContext.getOBContext().getWritableOrganizations();
      for (final String o : orgsWritables) {
        orgs.addAll(OBContext.getOBContext().getOrganizationStructureProvider().getNaturalTree(o));
      }
      orgPart = buildOrgPartWhereClause(orgs);
      localWhereClause = buildLocalWhereClause(localWhereClause, orgPart);
    }

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0036151		closed	caristu	organization selector in process definition don't filter by role's org access
related to	defect	0035124		closed	inigosanchez	Selectors in Process Definition invoked from menu show only records of organizations in the context organization's natural tree