Openbravo Issue Tracking System - Retail Modules
View Issue Details
0036523Retail ModulesCash uppublic2017-07-21 10:022017-11-22 13:57
aaroncalero 
ranjith_qualiantech_com 
urgentmajoralways
closedfixed 
5
 
RR17Q4 
marvintm
Pre packaging ( pi )
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8 [^]
No
0036523: The financial account configuration for a payment method is not taken into account to create reconciliations in the cashup
When a cashup is closed, transactions created during that cashup are reconciled adn the money is moved to the financial account defined on the Close events for each payment method.
The "automatic deposit" flag of the payment method defines if these reconciliations should be created or not.
This flag can be found on the generic Payment Method configuration, and also on the Financial Account Payment method configuration (which should override the generic configuration).

The problem is that in order to decide if reconciliations should be created or not, the generic configuration is being taken into account, instead of the configuration on the financial account.
Using White Valley sampledata:
Log in in backend, go to the Payment Method window, locate the "Wire Transfer" record (this is the Card payment method in webpos) and verify that the Automatic Deposit flag is checked.
Go to the Financial account window, locate the "Credit Card - Vall Blanca Store" record and on the Payment Method tab, verify that the Wire Transfer record is also configured as Automatic Deposit.
Go to the Organization window, Vall Blanca Store record, and on the Cash Management Events tab locate the "Credit Card - Close - Vall Blanca Store" record.


Log in in webpos, terminal VBS-1 and do a cashup to clear all values
Create a new ticket, add a product and complete the ticket paying with Card
Do another cashup.
Go to backend, POS Terminal window; select the VBS-1 record, go to the Payment Type tab, select Card and open the Reconciliation subtab. Verify that a new reconciliation has been created. Navigate to the reconciliation and verify that on the Cleared Items subtab there are two transactions (the payment and the movement to the Close Financial Account).

Go back to the Payment Method window, Wire Transfer record and uncheck the Automatic Deposit flag.
Go back to webpos, create a new ticket, pay it with card, and do another cashup.
Verify that this time, there is no new reconciliation created for the Card payment method, even if the configuration on the Financial Account window still flags the payment method as Automatic Deposit.
The following line on the commit that causes the issue:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8#l1.14 [^]
reads the automatic deposit flag directly from the payment method, which is wrong.

At this point we have the information of the financial account and the payment method, so it should be easy to refactor that code to get the Automatic Deposit flag from the financial account configuration.
No tags attached.
depends on backport 0037362RR17Q3.2 closed ranjith_qualiantech_com The financial account configuration for a payment method is not taken into account to create reconciliations in the cashup 
causes defect 0037359 closed marvintm Modulescript required to fix data caused by issue 36523 
Issue History
2017-07-21 10:02aaroncaleroNew Issue
2017-07-21 10:02aaroncaleroAssigned To => Retail
2017-07-21 10:02aaroncaleroResolution time => 1501797600
2017-07-21 10:02aaroncaleroRegression level => Pre packaging ( pi )
2017-07-21 10:02aaroncaleroRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8 [^]
2017-07-21 10:02aaroncaleroTriggers an Emergency Pack => No
2017-07-27 08:47ranjith_qualiantech_comStatusnew => scheduled
2017-07-28 09:26hgbotCheckin
2017-07-28 09:26hgbotNote Added: 0098257
2017-07-28 09:26hgbotStatusscheduled => resolved
2017-07-28 09:26hgbotResolutionopen => fixed
2017-07-28 09:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/11dde8dc94db70347d947817cb9b94b82abc67f9 [^]
2017-08-01 17:02marvintmAssigned ToRetail => ranjith_qualiantech_com
2017-08-08 16:03marvintmReview Assigned To => marvintm
2017-08-08 16:03marvintmStatusresolved => closed
2017-08-08 16:03marvintmFixed in Version => RR17Q4
2017-11-22 13:14maiteRelationship addedcauses 0037359
2017-11-22 13:56marvintmStatusclosed => new
2017-11-22 13:56marvintmResolutionfixed => open
2017-11-22 13:56marvintmFixed in VersionRR17Q4 =>
2017-11-22 13:57marvintmStatusnew => scheduled
2017-11-22 13:57marvintmStatusscheduled => resolved
2017-11-22 13:57marvintmFixed in Version => RR17Q4
2017-11-22 13:57marvintmResolutionopen => fixed
2017-11-22 13:57marvintmStatusresolved => closed

Notes
(0098257)
hgbot   
2017-07-28 09:26   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 11dde8dc94db70347d947817cb9b94b82abc67f9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jul 28 12:55:59 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/11dde8dc94db70347d947817cb9b94b82abc67f9 [^]

Fixed issue 36523 : Validate Payment method Automatic deposit with Financial account Payment method

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---