Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036518Openbravo ERPA. Platformpublic2017-07-20 10:172017-09-21 16:49
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036518: useless ping to butler on every login
DescriptionWhen logging in Openbravo, community branding url is calculated, one of its parameters is internetConnection which defines whether server has access to butler. To compute it, a ping to butler is done.

This ping can take some hundreds of milliseconds, which make every single login slower.
Steps To Reproduce* case 1: Login ERP and check StaticResources request takes ~400ms
* case 2: Login POS and check ApplicationFormat request takes ~350ms (in this case is even worse as this info is not used)
Proposed SolutionHaving this statics in butler does not worth the penalty in every login: so this info should just go away.

After removing this parameter times goes down:
* ERP: from ~400ms to ~80ms
* POS: from ~350ms to ~20ms
Additional Information
TagsPerformance
Relationships
related to feature request 0035553 closed caristu Improve scalability of the login process 
related to defect 0036504 closed alostale remove references to Basic Edition and Trial Subscription 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-20 10:17alostaleNew Issue
2017-07-20 10:17alostaleAssigned To => platform
2017-07-20 10:17alostaleModules => Core
2017-07-20 10:17alostaleTriggers an Emergency Pack => No
2017-07-20 10:18alostaleRelationship addedrelated to 0035553
2017-07-20 10:18alostaleRelationship addedrelated to 0036504
2017-07-20 10:18alostaleAssigned Toplatform => alostale
2017-07-20 10:18alostaleTag Attached: Performance
2017-07-20 10:18alostaleReview Assigned To => caristu
2017-07-20 10:19alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15531#r15531
2017-07-20 10:19alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15532#r15532
2017-07-20 10:26alostaleProposed Solution updated
2017-07-20 10:27alostaleProposed Solution updated
2017-07-20 10:33hgbotCheckin
2017-07-20 10:33hgbotNote Added: 0098144
2017-07-20 10:33hgbotStatusnew => resolved
2017-07-20 10:33hgbotResolutionopen => fixed
2017-07-20 10:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9933d754a9b9304fb6d1aef55fdb8130ce1fe2a2 [^]
2017-07-20 10:45alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15533#r15533
2017-07-21 08:54caristuNote Added: 0098172
2017-07-21 08:54caristuStatusresolved => closed
2017-07-21 08:54caristuFixed in Version => 3.0PR17Q4
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099281

Notes
(0098144)
hgbot   
2017-07-20 10:33   
Repository: erp/devel/pi
Changeset: 9933d754a9b9304fb6d1aef55fdb8130ce1fe2a2
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jul 20 10:33:14 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9933d754a9b9304fb6d1aef55fdb8130ce1fe2a2 [^]

fixed bug 36518: useless ping to butler on every login

  Removed this ping and the parameter in the community branding url that flags
  whether there is connectivity from server to butler.

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0098172)
caristu   
2017-07-21 08:54   
Reviewed
(0099281)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test