Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036512Retail ModulesDiscounts Combopublic2017-07-19 16:432019-02-06 15:35
Reporterguillermogil 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036512: Combo Fix Price is not taking into account discount priority
DescriptionCombo Fix Price is not taking into account discount priority is does nothing about it and applies only the first one.
Steps To ReproduceConfigure Avalanche transceiver product as non-grouped

Create a combo fix price discount with priority 2
Create family with QTY 2
Add avalanche transceiver product

Create another combo fix price discount with priority 1
Create family with QTY 3
Add avalanche transceiver product

Login on WebPOS
Add 2 avalanche transceiver
Combo 1 gets applied
Add another avalanche transceiver
Combo 2 is not getting applied
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036513 closed rqueralta Best Deal case is groping products even if they are not grouped 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-19 16:43guillermogilNew Issue
2017-07-19 16:43guillermogilAssigned To => Retail
2017-07-19 16:43guillermogilOBNetwork customer => Yes
2017-07-19 16:43guillermogilResolution time => 1502229600
2017-07-19 16:43guillermogilTriggers an Emergency Pack => No
2017-07-27 08:41guillermogilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15549#r15549
2017-07-27 08:42guillermogilRelationship addedrelated to 0036513
2017-07-27 15:55rqueraltaAssigned ToRetail => rqueralta
2017-07-27 15:56rqueraltaStatusnew => scheduled
2017-07-29 02:38hgbotCheckin
2017-07-29 02:38hgbotNote Added: 0098264
2017-07-29 02:38hgbotStatusscheduled => resolved
2017-07-29 02:38hgbotResolutionopen => fixed
2017-07-29 02:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/88809fce30a63cdcbdeb948167b13e0574f5c197 [^]
2017-08-02 20:36hgbotCheckin
2017-08-02 20:36hgbotNote Added: 0098353
2017-08-09 10:06marvintmReview Assigned To => jorge-garcia
2017-08-09 12:28jorge-garciaNote Added: 0098449
2017-08-09 12:28jorge-garciaStatusresolved => new
2017-08-09 12:28jorge-garciaResolutionfixed => open
2017-08-09 12:28jorge-garciaStatusnew => scheduled
2017-08-14 18:31hgbotCheckin
2017-08-14 18:31hgbotNote Added: 0098507
2017-09-11 12:50jorge-garciaStatusscheduled => resolved
2017-09-11 12:50jorge-garciaResolutionopen => fixed
2017-09-11 13:06jorge-garciaNote Added: 0098940
2017-09-11 13:06jorge-garciaStatusresolved => closed
2017-09-11 13:06jorge-garciaFixed in Version => RR17Q4
2017-09-14 14:33migueldejuanaNote Added: 0099047
2017-09-14 14:33migueldejuanaStatusclosed => new
2017-09-14 14:33migueldejuanaResolutionfixed => open
2017-09-14 14:33migueldejuanaFixed in VersionRR17Q4 =>
2017-09-15 08:27marvintmStatusnew => scheduled
2017-09-15 08:27marvintmStatusscheduled => resolved
2017-09-15 08:27marvintmFixed in Version => RR17Q4
2017-09-15 08:27marvintmResolutionopen => fixed
2017-09-15 08:27marvintmStatusresolved => closed
2017-09-15 09:22hgbotCheckin
2017-09-15 09:22hgbotNote Added: 0099058
2017-09-15 15:38hgbotCheckin
2017-09-15 15:38hgbotNote Added: 0099086
2017-09-15 15:38hgbotCheckin
2017-09-15 15:38hgbotNote Added: 0099087
2019-02-06 15:35hgbotCheckin
2019-02-06 15:35hgbotNote Added: 0109645

Notes
(0098264)
hgbot   
2017-07-29 02:38   
Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 88809fce30a63cdcbdeb948167b13e0574f5c197
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Fri Jul 28 15:26:43 2017 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/88809fce30a63cdcbdeb948167b13e0574f5c197 [^]

Fixed issue 36512: Combo Fix Price is not taking into account discount priority

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0098353)
hgbot   
2017-08-02 20:36   
Repository: tools/automation/pi-mobile
Changeset: b4e6c234bc72e4e0e14ade055b92c175642897fd
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Mon Jul 31 13:22:45 2017 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b4e6c234bc72e4e0e14ade055b92c175642897fd [^]

Verifies issue 36512: Combo Fix Price is not taking into account discount
priority

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesSplitLineHelper.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I36512_VerifyComboFixPriceWithNonGroupedProduct.java
---
(0098449)
jorge-garcia   
2017-08-09 12:28   
Test is failing in retail quarantine

http://ci.openbravo.com/view/retail-qa/job/ret-qa-modules-pgsql-suite2/lastCompletedBuild/testReport/org.openbravo.test.mobile.retail.extmodules.selenium.tests.discounts_combo/I36512_VerifyComboFixPriceWithNonGroupedProduct/test/ [^]
(0098507)
hgbot   
2017-08-14 18:31   
Repository: tools/automation/pi-mobile
Changeset: bbbb61e6ea2aeb22106bd0db50d2ed8fa049bebf
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Tue Aug 08 11:52:52 2017 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bbbb61e6ea2aeb22106bd0db50d2ed8fa049bebf [^]

Related to issue 36512: Combo Fix Price is not taking into account discount
priority

- Realocated some functions into the test class

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesSplitLineHelper.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I36512_VerifyComboFixPriceWithNonGroupedProduct.java
---
(0098940)
jorge-garcia   
2017-09-11 13:06   
Reviewed and tested
(0099047)
migueldejuana   
2017-09-14 14:33   
Failing in quarantine:

https://ci.openbravo.com/view/retail-qa/job/ret-qa-modules-oracle-suite1/ [^]
(0099058)
hgbot   
2017-09-15 09:22   
Repository: tools/automation/pi-mobile
Changeset: 2ca4b861fc87c5dc34d91f5dedb99ddfd4ed06da
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Sep 15 09:22:18 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2ca4b861fc87c5dc34d91f5dedb99ddfd4ed06da [^]

Related to issue 36512: The test is failing, do not execute it until it is fixed.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I36512_VerifyComboFixPriceWithNonGroupedProduct.java
---
(0099086)
hgbot   
2017-09-15 15:38   
Repository: tools/automation/pi-mobile
Changeset: 07e07fd7e4d5bf039838f150f4f3534c4f6d8872
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Fri Sep 15 09:33:36 2017 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/07e07fd7e4d5bf039838f150f4f3534c4f6d8872 [^]

Related to issue 36512: The test is failing, do not execute it until it is fixed

- Backed out changeset: 2ca4b861fc87

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I36512_VerifyComboFixPriceWithNonGroupedProduct.java
---
(0099087)
hgbot   
2017-09-15 15:38   
Repository: tools/automation/pi-mobile
Changeset: 801bcb2432a614fd932a349582674a8b2d490eef
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Thu Sep 14 22:47:31 2017 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/801bcb2432a614fd932a349582674a8b2d490eef [^]

Related to issue 36512: Combo Fix Price is not taking into account discount
priority

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I36512_VerifyComboFixPriceWithNonGroupedProduct.java
---
(0109645)
hgbot   
2019-02-06 15:35   
Repository: tools/automation/pi-mobile
Changeset: 6cf1602a93e202272f75df003c0ab30bc02b9968
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Feb 04 11:02:39 2019 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6cf1602a93e202272f75df003c0ab30bc02b9968 [^]

Related to issue 36512: test has been refactored due to it no longer creates its
own sampledata

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I36512_VerifyComboFixPriceWithNonGroupedProduct.java
---