Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036501Openbravo ERPA. Platformpublic2017-07-15 18:172017-09-22 10:20
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036501: Remove unused & old export.sample.data.old & import.sample.data.old
DescriptionMid 2013 the sampledata import & export was rewritten completely to no longer be bases on 'Export Client & 'Import Client' which do not have good performance for bigger datasets.
Instead sampledata export & import is since then based on dbsourcemanager code.

In that rewrite the old code to export & import sampledata using the single xml old code was kept as
ant export.sample.data.old
ant import.sample.data.old

Just for safety in case bigger trouble with the new system come up.

As now >= 4 years have passed it is time to remove that old unused code.

Note:
This is just about sampledata export & import: The process for 'Export Client' & 'Import Client' from the GUI is kept.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036923 closed shuehner api-changes related to unused code removal 
depends on design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Not all the children of this issue are yet resolved or closed.
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-15 18:17shuehnerNew Issue
2017-07-15 18:17shuehnerAssigned To => shuehner
2017-07-15 18:17shuehnerModules => Core
2017-07-15 18:17shuehnerTriggers an Emergency Pack => No
2017-07-15 18:29shuehnerRelationship addeddepends on 0032688
2017-09-21 23:06shuehnerRelationship addedrelated to 0036923
2017-09-21 23:11hgbotCheckin
2017-09-21 23:11hgbotNote Added: 0099442
2017-09-21 23:11hgbotStatusnew => resolved
2017-09-21 23:11hgbotResolutionopen => fixed
2017-09-21 23:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/272b6763698c217f3476b27ed87a98ca13bd4903 [^]
2017-09-21 23:13shuehnerReview Assigned To => alostale
2017-09-21 23:13shuehnerFixed in Version => 3.0PR17Q4
2017-09-22 10:20alostaleNote Added: 0099470
2017-09-22 10:20alostaleStatusresolved => closed

Notes
(0099442)
hgbot   
2017-09-21 23:11   
Repository: erp/devel/pi
Changeset: 272b6763698c217f3476b27ed87a98ca13bd4903
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Sep 15 17:15:38 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/272b6763698c217f3476b27ed87a98ca13bd4903 [^]

Fixed 36501. Remove unused export.sample.data.old and import.sample.data.old

Thsoe targets were kept when rewriting sampledata in 2013 completely. As 4
years have passed since then it is time to remove that old unused code.

This removes:
- ant export.sample.data.old
- ant import.sample.data.old
  - allowing to remove the disableCheckReferencedOrganizations property which is
    now unused.
- Remove both java classes implementing those tasks and one shared super-class
  ReferenceDataTask as it is not used anywhere else.

Note: This ReferenceDataTask class had one text-reference for a single constant
in some commented out testing code. -> Replace that usage with direct string as
no need to keep the java class around just for that.

---
M build.xml
M src-test/src/org/openbravo/test/xml/ClientExportImportTest.java
M src/build.xml
R src/org/openbravo/service/db/ExportReferenceDataTask.java
R src/org/openbravo/service/db/ImportReferenceDataTask.java
R src/org/openbravo/service/db/ReferenceDataTask.java
---
(0099470)
alostale   
2017-09-22 10:20   
reviewed