Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036491Retail ModulesStoreServerpublic2017-07-13 16:562017-10-24 15:06
ReporterAugustoMauch 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036491: In ServerStateBackground, if a store server is not pinged by central server, its status is not set to OFFLINE
DescriptionThe ServerStateBackground.pingShouldBeDoneToServer(server) determines if a store server should be pinged to check/update its status. It checks the PingServerChecker, and if any returns false, the store server is not pinged and its status is not updated in the central server.

Currently the only implementation of PingServerChecker that we have is RegisteredServerPingChecker, that returns false if the store server has not been deployed (it checks that is has been registered in the central server's SymmetricDS engine). In this case it would make sense to set the server status to OFFLINE to all those servers that are not registered, instead of just leaving its status as it is.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-13 16:56AugustoMauchNew Issue
2017-07-13 16:56AugustoMauchAssigned To => StoreServer
2017-07-13 16:56AugustoMauchOBNetwork customer => No
2017-07-13 16:56AugustoMauchTriggers an Emergency Pack => No
2017-08-30 09:25mtaalAssigned ToStoreServer => mtaal
2017-09-20 09:48mtaalReview Assigned To => AugustoMauch
2017-09-20 09:49hgbotCheckin
2017-09-20 09:49hgbotNote Added: 0099167
2017-09-20 09:49hgbotStatusnew => resolved
2017-09-20 09:49hgbotResolutionopen => fixed
2017-09-20 09:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3b09106d0238d59be5effb111f31082a856a0a06 [^]
2017-09-25 13:13AugustoMauchNote Added: 0099542
2017-09-25 13:13AugustoMauchStatusresolved => closed
2017-10-24 15:06hgbotCheckin
2017-10-24 15:06hgbotNote Added: 0100028

Notes
(0099167)
hgbot   
2017-09-20 09:49   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3b09106d0238d59be5effb111f31082a856a0a06
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 20 09:29:31 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3b09106d0238d59be5effb111f31082a856a0a06 [^]

Fixes issue 36491: In ServerStateBackground, if a store server is not pinged by central server, its status is not set to OFFLINE
Set state to offline if the server does not need to be pinged.

---
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
(0099542)
AugustoMauch   
2017-09-25 13:13   
Code reviewed and verified
(0100028)
hgbot   
2017-10-24 15:06   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f5e4b085b6d0371b7187c69d2619a5a341e51b50
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Sep 25 16:35:41 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f5e4b085b6d0371b7187c69d2619a5a341e51b50 [^]

Related with issue 36491: Enum value is passed instead of its name

updateServerStatus expects ON, OFF, etc, not ONLINE or OFFLINE.

---
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---