Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036467Retail ModulesStoreServerpublic2017-06-26 12:142017-09-15 13:26
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q3Fixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036467: Incremental load does not call ready with loading in case of remote models in specific case
DescriptionThe normal logic of incremental load calls triggerRead [1] after each locally stored model is reloaded.
However in case of remote model [2] or other cases [3] triggerReady is not called.

The consequence of this is that if the last model in the queue is a remote model the loading popup remains visible and does not go away. See attached screenshot.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1606 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1619 [^]

[3]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1624 [^]
Steps To ReproduceSet remote product model
Install gift card module
Set incremental load to 2 minutes or so
Login, wait for incremental load to happen
Proposed SolutionCall triggerReady here [1] and remove it here [2]

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1564 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1606 [^]

Additional Information
TagsNo tags attached.
Relationships
blocks defect 0036332 closed mtaal Incremental load does not call ready with loading in case of remote models in specific case 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-11 17:31mtaalTypedefect => backport
2017-07-11 17:31mtaalTarget Version => RR17Q3
2017-07-11 17:39mtaalNote Added: 0098022
2017-07-11 18:07mtaalReview Assigned Tomarvintm => migueldejuana
2017-07-11 18:07mtaalSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15491#r15491
2017-07-11 18:10hgbotCheckin
2017-07-11 18:10hgbotNote Added: 0098026
2017-07-11 18:10hgbotStatusscheduled => resolved
2017-07-11 18:10hgbotResolutionopen => fixed
2017-07-11 18:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/46a1e1d2d9498bc4ea719de1d1d6cf3f89704f80 [^] => http://code.openbravo.com/retail/backports/3.0RR17Q3/org.openbravo.mobile.core/rev/578ccab4bc6c1830296909643985e909d57fedb0 [^]
2017-09-15 13:26marvintmReview Assigned Tomigueldejuana => marvintm
2017-09-15 13:26marvintmStatusresolved => closed
2017-09-15 13:26marvintmFixed in Version => RR17Q3

Notes
(0098022)
mtaal   
2017-07-11 17:39   
To test this:
- enable remote product data preference
- set incremental load to happen every 2 minutes
- check that incremental load (after login) indeed reloads and shows the webpos screen again
(0098026)
hgbot   
2017-07-11 18:10   
Repository: retail/backports/3.0RR17Q3/org.openbravo.mobile.core
Changeset: 578ccab4bc6c1830296909643985e909d57fedb0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jul 11 18:09:58 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3/org.openbravo.mobile.core/rev/578ccab4bc6c1830296909643985e909d57fedb0 [^]

Fixes issue 36467: Incremental load does not call ready with loading in case of remote models in specific case
Call triggerready once at the end of the list of models, prevent async issues in this way

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---