Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036465Retail ModulesStoreServerpublic2017-07-11 17:072017-11-08 12:26
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q4Fixed in VersionRR18Q1 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036465: Do not trigger or wait for synchronization/replication to happen in some case before returning to webpos
DescriptionIn Synchronized mode and multi-server environment we wait until the data is replicated from the central to the store server before returning to the store server.

In case the json has an error we don't need to do or wait for replication.

We don't need to wait on the store server for the replication either in this case. But as the logic is about to change anyway (see related issue). There is no need to make any further changes.
Steps To ReproduceInstall multi-server
Enable synchronized mode
Run webpos on the store server
Submit tickets
Check the wait time
Proposed SolutionDon't trigger replication in case of errors.

Changes to be done here [1]

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/51faaff177c0/src/org/openbravo/retail/storeserver/synchronization/MultiServerJSONSymmetricDSStarter.java#l52 [^]
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-11 17:07mtaalNew Issue
2017-07-11 17:07mtaalAssigned To => mtaal
2017-07-11 17:07mtaalTriggers an Emergency Pack => No
2017-07-11 17:09hgbotCheckin
2017-07-11 17:09hgbotNote Added: 0098018
2017-07-12 09:44hgbotCheckin
2017-07-12 09:44hgbotNote Added: 0098036
2017-10-02 10:36mtaalSummaryDo not wait for synchronization/replication to happen in some case before returning to webpos => Do not trigger or wait for synchronization/replication to happen in some case before returning to webpos
2017-10-02 10:36mtaalDescription Updatedbug_revision_view_page.php?rev_id=16019#r16019
2017-10-02 10:36mtaalProposed Solution updated
2017-10-02 10:38mtaalReview Assigned To => AugustoMauch
2017-11-07 15:14mtaalStatusnew => scheduled
2017-11-07 15:14mtaalNote Added: 0100309
2017-11-07 15:14mtaalStatusscheduled => resolved
2017-11-07 15:14mtaalResolutionopen => fixed
2017-11-08 12:25hgbotCheckin
2017-11-08 12:25hgbotNote Added: 0100344
2017-11-08 12:26AugustoMauchNote Added: 0100345
2017-11-08 12:26AugustoMauchStatusresolved => closed
2017-11-08 12:26AugustoMauchFixed in Version => RR18Q1

Notes
(0098018)
hgbot   
2017-07-11 17:09   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: b3de88bd8f098d85ec4968b200b9bc39683d744d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jul 11 17:08:37 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/b3de88bd8f098d85ec4968b200b9bc39683d744d [^]

Related to issue 36465: Do not wait for synchronization/replication to happen in some case before returning to webpos
Do not trigger sym-ds replication in case of errors

---
M src/org/openbravo/retail/storeserver/synchronization/MultiServerJSONSymmetricDSStarter.java
---
(0098036)
hgbot   
2017-07-12 09:44   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 88cd56c1f373828bfcee09bb35c813bab67e62ea
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jul 12 09:43:48 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/88cd56c1f373828bfcee09bb35c813bab67e62ea [^]

Related to issue 36465: Do not wait for synchronization/replication to happen in some case before returning to webpos
Solve failing store server build

---
M src/org/openbravo/retail/storeserver/synchronization/MultiServerJSONSymmetricDSStarter.java
---
(0100309)
mtaal   
2017-11-07 15:14   
Changes were done a long time ago. Since then have worked fine, setting the issue to resolved.
(0100344)
hgbot   
2017-11-08 12:25   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 7b7f373039517cc770230bf6f61d251a5eabe211
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Nov 08 12:22:36 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/7b7f373039517cc770230bf6f61d251a5eabe211 [^]

Related with issue 36465: Extracts if statement to method

---
M src/org/openbravo/retail/storeserver/synchronization/MultiServerJSONSymmetricDSStarter.java
---
(0100345)
AugustoMauch   
2017-11-08 12:26   
Code reviewed and verified