Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036462Openbravo ERPA. Platformpublic2017-07-10 18:112017-07-19 11:45
ngarcia 
alostale 
immediatemajoralways
closedfixed 
5
 
3.0PR17Q1.33.0PR17Q1.3 
caristu
Core
No
0036462: editing in grid record can be saved before callouts are applied
It is possible to save a record while editing it in grid before changes produced by callouts are applied to it, the result can be incorrect data being saved. This is easier to reproduce in case of slow network or slow callouts.
* Alternative 1

Using chrome, open Developer Tools - Network and set Network conditions to GPRS (500ms, 50kb/s, 20bk/s)

As group admin role:
   1.1. Create a Sales Quotation header
   1.2. Insert Row in grid mode
   1.3. Select a product, click on save button in grid and while loading click on Cancel changes toolbar button
     -> Check the line is saved but the prices and amounts remain on 0, the default tax has not been modified...


* Alternative 2
  2.1. Add artificial delay in SL_Order_Product callout code: Thread.sleep(5_000L);
  2.2. Create a Sales Quotation header
  2.2. Insert Row in grid mode
  2.3. Select a product, click on save button in grid
    -> Check the line is saved but the prices and amounts remain on 0, the default tax has not been modified...


Note if the same is performed in form view, save request is not performed until FIC response is received so that data is correct.
No tags attached.
blocks defect 0036454 closed alostale editing in grid record can be saved before callouts are applied 
Issue History
2017-07-11 15:07alostaleTypedefect => backport
2017-07-11 15:07alostaleTarget Version => 3.0PR17Q1.3
2017-07-14 08:38hgbotCheckin
2017-07-14 08:38hgbotNote Added: 0098073
2017-07-14 08:38hgbotStatusscheduled => resolved
2017-07-14 08:38hgbotResolutionopen => fixed
2017-07-14 08:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q1.3/rev/cde2219b400ea2e0581228e8a4c02334e39163b3 [^]
2017-07-14 08:38alostaleReview Assigned ToAugustoMauch => caristu
2017-07-14 08:38alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15508#r15508
2017-07-19 11:45caristuNote Added: 0098130
2017-07-19 11:45caristuStatusresolved => closed
2017-07-19 11:45caristuFixed in Version => 3.0PR17Q1.3

Notes
(0098073)
hgbot   
2017-07-14 08:38   
Repository: erp/backports/3.0PR17Q1.3
Changeset: cde2219b400ea2e0581228e8a4c02334e39163b3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 11 09:13:34 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1.3/rev/cde2219b400ea2e0581228e8a4c02334e39163b3 [^]

fixed bug 36462: in grid can trigger save before FIC response is received

  While editing in grid mode, it is possible to trigger save action by clicking
  grid's save button while FIC response is not received yet. If this occurs, the
  data sent to backend misses information that FIC should update.

  If grid's save button is clicked while in FIC call, postpone save action till
  FIC return.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0098130)
caristu   
2017-07-19 11:45   
Code reviewed + testing OK: now is not possible to save a record in grid view without the data calculated by the callouts.