Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036455Openbravo ERP04. Warehouse managementpublic2017-07-11 11:082017-09-21 16:49
Reporterngarcia 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket47588
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036455: Cannot complete a goods shipment if the related sales order line has a stock reservation in draft status
DescriptionCannot complete a goods shipment if the related sales order line has a stock reservation in draft status
Steps To ReproduceAs group admin role:
   Set the Enable Stock Reservations preference to Y

   Log out and log in

   Create a sales order
   Add a product with stock to it
   Complete it
   Click on Manage Stock and reserve it
   Click again on manage stock and remove the reservation
   Go to Stock Reservation window and check a reservation in draft status and related with the sales order line exists
   Create a Goods Shipment header
   Select the previously created sales order in Create Lines From process
   Try to complete the Goods Shipment and check the following error is raised:
      'This action is not supported'

   Go to Stock Reservation window, remove the record in draft status and check you can complete the Goods Shipment now
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0032408 closed collazoandy4 Reservation header associated to a sales order line should be removed when the line is deleted 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-11 11:08ngarciaNew Issue
2017-07-11 11:08ngarciaAssigned To => Triage Finance
2017-07-11 11:08ngarciaOBNetwork customer => Yes
2017-07-11 11:08ngarciaModules => Core
2017-07-11 11:08ngarciaSupport ticket => 47588
2017-07-11 11:08ngarciaResolution time => 1501538400
2017-07-11 11:08ngarciaTriggers an Emergency Pack => No
2017-07-11 11:08ngarciaIssue Monitored: networkb
2017-07-11 14:00aferrazAssigned ToTriage Finance => collazoandy4
2017-07-11 16:01collazoandy4Statusnew => scheduled
2017-07-20 23:50collazoandy4Note Added: 0098158
2017-07-26 11:27hgbotCheckin
2017-07-26 11:27hgbotNote Added: 0098220
2017-07-26 11:27hgbotStatusscheduled => resolved
2017-07-26 11:27hgbotResolutionopen => fixed
2017-07-26 11:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6a599106f3992eb33f11feb8024119501f98854b [^]
2017-07-26 11:28aferrazReview Assigned To => aferraz
2017-07-26 11:28aferrazNote Added: 0098221
2017-07-26 11:28aferrazStatusresolved => closed
2017-07-26 11:28aferrazFixed in Version => 3.0PR17Q4
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099285
2017-12-26 09:27vmromanosRelationship addedhas duplicate 0032408

Notes
(0098158)
collazoandy4   
2017-07-20 23:50   
Test Plan
 As group admin role:
   Set the Enable Stock Reservations preference to Y
   Log out and log in

   Go to Sales order window and create a new record for Alimentos y Supermercados, S.A bp
     Create a new record in Lines tab:
       Product: Cerveza Ale 0,5L, Ordered Quantity: 10
     Complete the order
     Click on Manage Stock and reserve it
     Check in Stock reservation window a new record was created with
       Product: Cerveza Ale 0,5L, Ordered: 10, Reserverd qty: 10, Released: 0 and related to the orderline
     Click again on manage stock and remove the reservation
     Check the reservation was remove from Stock reservation window
   Go to Goods Shipment window and create a new record for Alimentos y Supermercados, S.A bp
     Select the previously created sales order in Create Lines From process
     Complete the the Goods Shipment and check the no error is raised
(0098220)
hgbot   
2017-07-26 11:27   
Repository: erp/devel/pi
Changeset: 6a599106f3992eb33f11feb8024119501f98854b
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 20 10:41:52 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/6a599106f3992eb33f11feb8024119501f98854b [^]

Fixes issue 36455: Cannot complete a shipment if related to a draft reservation

When a reservation was removed from Manage Reservation process in Sales Order,
the reservation keeps the association with the line and Not support operation
exception was raised because the reservation changes from DR to CL.

Now the Manage Reservation process in Sales Order removes the reservation
if the reservation has no lines.

Also the c_orderline2_trg only closes reservations in CO and HO status.

---
M src-db/database/model/triggers/C_ORDERLINE2_TRG.xml
M src/org/openbravo/common/actionhandler/ManageReservationActionHandler.java
---
(0098221)
aferraz   
2017-07-26 11:28   
Code review + Testing OK
(0099285)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test