Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036454Openbravo ERPA. Platformpublic2017-07-10 18:112017-09-21 16:49
Reporterngarcia 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036454: editing in grid record can be saved before callouts are applied
DescriptionIt is possible to save a record while editing it in grid before changes produced by callouts are applied to it, the result can be incorrect data being saved. This is easier to reproduce in case of slow network or slow callouts.
Steps To Reproduce* Alternative 1

Using chrome, open Developer Tools - Network and set Network conditions to GPRS (500ms, 50kb/s, 20bk/s)

As group admin role:
   1.1. Create a Sales Quotation header
   1.2. Insert Row in grid mode
   1.3. Select a product, click on save button in grid and while loading click on Cancel changes toolbar button
     -> Check the line is saved but the prices and amounts remain on 0, the default tax has not been modified...


* Alternative 2
  2.1. Add artificial delay in SL_Order_Product callout code: Thread.sleep(5_000L);
  2.2. Create a Sales Quotation header
  2.3. Insert Row in grid mode
  2.4. Select a product, click on save button before FIC request is completed
    -> Check the line is saved but the prices and amounts remain on 0, the default tax has not been modified...


Note if the same is performed in form view, save request is not performed until FIC response is received so that data is correct.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0020474 closed mtaal When you save a register in grid view, amounts fields change to the previous value 
related to defect 0032668 closed alostale Wrong Total Gross Amount, Total Net Amount and Tax information is obtained in order and invoices 
depends on backport 00364603.0PR17Q3 closed alostale editing in grid record can be saved before callouts are applied 
depends on backport 00364613.0PR17Q2.2 closed alostale editing in grid record can be saved before callouts are applied 
depends on backport 00364623.0PR17Q1.3 closed alostale editing in grid record can be saved before callouts are applied 
related to defect 0036457 closed alostale inconsistent grid state if cancelling changes before receiving FIC response 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-10 18:11ngarciaNew Issue
2017-07-10 18:11ngarciaAssigned To => platform
2017-07-10 18:11ngarciaModules => Core
2017-07-10 18:11ngarciaResolution time => 1501452000
2017-07-10 18:11ngarciaTriggers an Emergency Pack => No
2017-07-10 18:14ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15479#r15479
2017-07-10 18:14ngarciaIssue Monitored: networkb
2017-07-10 18:50ngarciaPriorityurgent => immediate
2017-07-11 07:52alostaleAssigned Toplatform => alostale
2017-07-11 09:04alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15480#r15480
2017-07-11 09:05alostaleRelationship addedrelated to 0020474
2017-07-11 09:06alostaleRelationship addedrelated to 0032668
2017-07-11 13:15alostaleRelationship addedrelated to 0036457
2017-07-11 15:05alostaleSummaryChanges from SL_Order_Product callout are not saved if the network is slow and the sales quotation line is canceled before saved => editing in grid record can be saved before callouts are applied
2017-07-11 15:05alostaleDescription Updatedbug_revision_view_page.php?rev_id=15485#r15485
2017-07-11 15:06alostaleReview Assigned To => AugustoMauch
2017-07-11 15:07alostaleStatusnew => scheduled
2017-07-11 16:07alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15486#r15486
2017-07-11 16:08alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15487#r15487
2017-07-12 08:20hgbotCheckin
2017-07-12 08:20hgbotNote Added: 0098031
2017-07-12 08:20hgbotStatusscheduled => resolved
2017-07-12 08:20hgbotResolutionopen => fixed
2017-07-12 08:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/699bc76591a429789bc5fc65589586a3ad1d9421 [^]
2017-07-12 11:26AugustoMauchNote Added: 0098040
2017-07-12 11:26AugustoMauchStatusresolved => closed
2017-07-14 08:18alostaleReview Assigned ToAugustoMauch => caristu
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099272

Notes
(0098031)
hgbot   
2017-07-12 08:20   
Repository: erp/devel/pi
Changeset: 699bc76591a429789bc5fc65589586a3ad1d9421
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 11 09:13:34 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/699bc76591a429789bc5fc65589586a3ad1d9421 [^]

fixed bug 36454: in grid can trigger save before FIC response is received

  While editing in grid mode, it is possible to trigger save action by clicking
  grid's save button while FIC response is not received yet. If this occurs, the
  data sent to backend misses information that FIC should update.

  If grid's save button is clicked while in FIC call, postpone save action till
  FIC return.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0098040)
AugustoMauch   
2017-07-12 11:26   
Code reviewed and verified in pi@5a4d53a0947f
(0099272)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test